All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>, Wen Yang <wen.yang99@zte.com.cn>
Cc: Wen Yang <yellowriver2010@hotmail.com>,
	Gilles Muller <Gilles.Muller@lip6.fr>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	Michal Marek <michal.lkml@markovi.net>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Cheng Shengyu <cheng.shengyu@zte.com.cn>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	cocci@systeme.lip6.fr
Subject: Re: [v6] coccinelle: semantic code search for missing put_device()
Date: Tue, 19 Feb 2019 09:12:11 +0100	[thread overview]
Message-ID: <fc48cfe9-3d01-8ab6-7bf0-a481b72f4a1a@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1902190804150.2570@hadrien>

>> Although we have tested these two methods in the existing kernel code,
>> considering the evolution of the kernel code, these special cases may occur, so we are willing to take them into account.
>> We plan to modify the code like this:
>>
>>  id = of_find_device_by_node@p1(x)
>> -... when != e = id
>> +... when != e = (T)id
>> +    when != id = (T)e
>
> This change is fine with me.

Thanks for another positive feedback on such software implementation details.

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>, Wen Yang <wen.yang99@zte.com.cn>
Cc: kernel-janitors@vger.kernel.org,
	Michal Marek <michal.lkml@markovi.net>,
	Wen Yang <yellowriver2010@hotmail.com>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	linux-kernel@vger.kernel.org,
	Cheng Shengyu <cheng.shengyu@zte.com.cn>,
	cocci@systeme.lip6.fr
Subject: Re: [v6] coccinelle: semantic code search for missing put_device()
Date: Tue, 19 Feb 2019 08:12:11 +0000	[thread overview]
Message-ID: <fc48cfe9-3d01-8ab6-7bf0-a481b72f4a1a@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1902190804150.2570@hadrien>

>> Although we have tested these two methods in the existing kernel code,
>> considering the evolution of the kernel code, these special cases may occur, so we are willing to take them into account.
>> We plan to modify the code like this:
>>
>>  id = of_find_device_by_node@p1(x)
>> -... when != e = id
>> +... when != e = (T)id
>> +    when != id = (T)e
>
> This change is fine with me.

Thanks for another positive feedback on such software implementation details.

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>, Wen Yang <wen.yang99@zte.com.cn>
Cc: kernel-janitors@vger.kernel.org,
	Michal Marek <michal.lkml@markovi.net>,
	Wen Yang <yellowriver2010@hotmail.com>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	linux-kernel@vger.kernel.org,
	Cheng Shengyu <cheng.shengyu@zte.com.cn>,
	cocci@systeme.lip6.fr
Subject: Re: [Cocci] [v6] coccinelle: semantic code search for missing put_device()
Date: Tue, 19 Feb 2019 09:12:11 +0100	[thread overview]
Message-ID: <fc48cfe9-3d01-8ab6-7bf0-a481b72f4a1a@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1902190804150.2570@hadrien>

>> Although we have tested these two methods in the existing kernel code,
>> considering the evolution of the kernel code, these special cases may occur, so we are willing to take them into account.
>> We plan to modify the code like this:
>>
>>  id = of_find_device_by_node@p1(x)
>> -... when != e = id
>> +... when != e = (T)id
>> +    when != id = (T)e
>
> This change is fine with me.

Thanks for another positive feedback on such software implementation details.

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  reply	other threads:[~2019-02-19  8:12 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-16 16:05 [Cocci] [PATCH v6] coccinelle: semantic code search for missing put_device() Wen Yang
2019-02-16 16:33 ` Julia Lawall
2019-02-16 16:33   ` [Cocci] " Julia Lawall
2019-02-16 18:39 ` [v6] " Markus Elfring
2019-02-16 18:39   ` [Cocci] " Markus Elfring
2019-02-16 18:39   ` Markus Elfring
2019-02-17  2:32   ` [Cocci] 答复: " Wen Yang
2019-02-17  7:42     ` Markus Elfring
2019-02-17  7:42       ` [Cocci] " Markus Elfring
2019-02-17  7:42       ` 答复: [v6] coccinelle: semantic code =?UTF-8?Q?_search_for_missing_p Markus Elfring
2019-02-17  9:50 ` [PATCH v6] coccinelle: semantic code search for missing put_device() Markus Elfring
2019-02-17  9:50   ` [Cocci] " Markus Elfring
2019-02-17  9:50   ` Markus Elfring
2019-02-17 11:37   ` Julia Lawall
2019-02-17 11:37     ` [Cocci] " Julia Lawall
2019-02-17 11:37     ` Julia Lawall
2019-02-17 11:42     ` Markus Elfring
2019-02-17 11:42       ` [Cocci] " Markus Elfring
2019-02-17 11:42       ` Markus Elfring
2019-02-17 11:48       ` Julia Lawall
2019-02-17 11:48         ` [Cocci] " Julia Lawall
2019-02-17 11:48         ` Julia Lawall
2019-02-17 12:00         ` [v6] " Markus Elfring
2019-02-17 12:00           ` [Cocci] " Markus Elfring
2019-02-17 12:00           ` Markus Elfring
2019-02-17 12:05           ` Julia Lawall
2019-02-17 12:05             ` [Cocci] " Julia Lawall
2019-02-17 12:05             ` Julia Lawall
2019-02-17 12:20             ` Markus Elfring
2019-02-17 12:20               ` [Cocci] " Markus Elfring
2019-02-17 12:20               ` Markus Elfring
2019-02-17 12:52               ` Julia Lawall
2019-02-17 12:52                 ` [Cocci] " Julia Lawall
2019-02-17 12:52                 ` Julia Lawall
2019-02-17 13:14                 ` Markus Elfring
2019-02-17 13:14                   ` [Cocci] " Markus Elfring
2019-02-17 13:14                   ` Markus Elfring
2019-02-18  3:22                   ` [Cocci] " wen.yang99
2019-02-18  6:43                     ` Julia Lawall
2019-02-18  6:43                       ` [Cocci] " Julia Lawall
2019-02-18  6:43                       ` Julia Lawall
2019-02-18  8:19                       ` Markus Elfring
2019-02-18  8:19                         ` [Cocci] " Markus Elfring
2019-02-18  8:19                         ` Markus Elfring
2019-02-19  2:14                         ` [Cocci] " wen.yang99
2019-02-19  7:04                           ` Julia Lawall
2019-02-19  7:04                             ` [Cocci] " Julia Lawall
2019-02-19  7:04                             ` Julia Lawall
2019-02-19  8:12                             ` Markus Elfring [this message]
2019-02-19  8:12                               ` [Cocci] " Markus Elfring
2019-02-19  8:12                               ` Markus Elfring
2019-02-19  8:29                           ` Markus Elfring
2019-02-19  8:29                             ` [Cocci] " Markus Elfring
2019-02-19  8:29                             ` Markus Elfring
2019-02-19  9:09                             ` [Cocci] " wen.yang99
2019-02-19  9:30                               ` Markus Elfring
2019-02-19  9:30                                 ` [Cocci] " Markus Elfring
2019-02-19  9:30                                 ` Markus Elfring
2019-03-06 11:18                           ` Markus Elfring
2019-03-06 11:18                             ` [Cocci] " Markus Elfring
2019-03-06 11:18                             ` Markus Elfring
2019-02-18 21:40                     ` Markus Elfring
2019-02-18 21:40                       ` [Cocci] " Markus Elfring
2019-02-18 21:40                       ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc48cfe9-3d01-8ab6-7bf0-a481b72f4a1a@web.de \
    --to=markus.elfring@web.de \
    --cc=Gilles.Muller@lip6.fr \
    --cc=cheng.shengyu@zte.com.cn \
    --cc=cocci@systeme.lip6.fr \
    --cc=julia.lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    --cc=wen.yang99@zte.com.cn \
    --cc=yamada.masahiro@socionext.com \
    --cc=yellowriver2010@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.