Add version info in the fan - json config

Add version info in the fan - json config

[Kumar Thangavel]

[-- Attachment #1: Type: text/plain, Size: 1602 bytes --]

Classification: Public
Hi All,

        Shall we have a new field "version" in the fan controller part in the Entity-Manager json file to identify the versions of the each fan controller updates.

        This will give us the idea about which versions we are using and fan config updates and tracking.

        So, dbus-sensors/FanMain.cpp code should be updated to handle this version info for the fan.

        Please let us know if any comments on this.

Thanks,
Kumar.


::DISCLAIMER::
________________________________
The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates. Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of authorized representative of HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.
________________________________

[-- Attachment #2: Type: text/html, Size: 4341 bytes --]

Re: Add version info in the fan - json config

[Ed Tanous]

On Tue, Dec 1, 2020 at 10:08 PM Kumar Thangavel <thangavel.k@hcl.com> wrote:
>
> Classification: Public
>
> Hi All,
>
>
>
>         Shall we have a new field “version” in the fan controller part in the Entity-Manager json file to identify the versions of the each fan controller updates.
>
>
>
>         This will give us the idea about which versions we are using and fan config updates and tracking.

Generally this is better tracked using the version of OpenBMC being
loaded than what version of the config files have been loaded.  While
this makes it a little bit of a pain for debug when loading multiple
copies of the same version, it helps us avoid having to track any
per-file version information.

With that said, how would you imagine the version information would be
exposed to the user?  What value would it serve to a user that's
unable to update the files (except through a firmware update).

>
>
>
>         So, dbus-sensors/FanMain.cpp code should be updated to handle this version info for the fan.
>
>
>
>         Please let us know if any comments on this.
>
>
>
> Thanks,
>
> Kumar.
>
>
>
>
>
> ::DISCLAIMER::
> ________________________________
> The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates. Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of authorized representative of HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.
> ________________________________

RE: Add version info in the fan - json config

[Kumar Thangavel]

Classification: Public

Classification: Public

 Hi Ed, 

Thanks for your response. Pls find my reponse below inline. 

Thanks,
Kumar.

-----Original Message-----
From: Ed Tanous <ed@tanous.net> 
Sent: Wednesday, December 2, 2020 9:50 PM
To: Kumar Thangavel <thangavel.k@hcl.com>
Cc: openbmc@lists.ozlabs.org; Velumani T-ERS,HCLTech <velumanit@hcl.com>; sdasari@fb.com; Patrick Williams <patrickw3@fb.com>; Vernon Mauery <vernon.mauery@linux.intel.com>; Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Subject: Re: Add version info in the fan - json config

[CAUTION: This Email is from outside the Organization. Unless you trust the sender, Don’t click links or open attachments as it may be a Phishing email, which can steal your Information and compromise your Computer.]

On Tue, Dec 1, 2020 at 10:08 PM Kumar Thangavel <thangavel.k@hcl.com> wrote:
>
> Classification: Public
>
> Hi All,
>
>
>
>         Shall we have a new field “version” in the fan controller part in the Entity-Manager json file to identify the versions of the each fan controller updates.
>
>
>
>         This will give us the idea about which versions we are using and fan config updates and tracking.

Generally this is better tracked using the version of OpenBMC being loaded than what version of the config files have been loaded.  While this makes it a little bit of a pain for debug when loading multiple copies of the same version, it helps us avoid having to track any per-file version information.

Kumar : Ok. Thanks for your suggestions. 

With that said, how would you imagine the version information would be exposed to the user?  What value would it serve to a user that's unable to update the files (except through a firmware update).

 Kumar : We can expose this to user as software version in the dbus if needed. 

>
>
>
>         So, dbus-sensors/FanMain.cpp code should be updated to handle this version info for the fan.
>
>
>
>         Please let us know if any comments on this.
>
>
>
> Thanks,
>
> Kumar.
>
>
>
>
>
> ::DISCLAIMER::
> ________________________________
> The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates. Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of authorized representative of HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.
> ________________________________