From: Dylan Hung <dylan_hung@aspeedtech.com> To: Krzysztof Kozlowski <krzk@kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "joel@jms.id.au" <joel@jms.id.au>, "andrew@aj.id.au" <andrew@aj.id.au>, "andrew@lunn.ch" <andrew@lunn.ch>, "hkallweit1@gmail.com" <hkallweit1@gmail.com>, "linux@armlinux.org.uk" <linux@armlinux.org.uk>, "davem@davemloft.net" <davem@davemloft.net>, "kuba@kernel.org" <kuba@kernel.org>, "pabeni@redhat.com" <pabeni@redhat.com>, "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org> Cc: BMC-SW <BMC-SW@aspeedtech.com>, "stable@vger.kernel.org" <stable@vger.kernel.org> Subject: RE: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes Date: Tue, 22 Mar 2022 08:44:43 +0000 [thread overview] Message-ID: <HK0PR06MB2834EDCF527EE9DE79C1A6AE9C179@HK0PR06MB2834.apcprd06.prod.outlook.com> (raw) In-Reply-To: <216b98d5-a254-4527-c569-9f3397811e70@kernel.org> > -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzk@kernel.org] > Sent: 2022年3月22日 4:40 PM > To: Dylan Hung <dylan_hung@aspeedtech.com>; robh+dt@kernel.org; > joel@jms.id.au; andrew@aj.id.au; andrew@lunn.ch; hkallweit1@gmail.com; > linux@armlinux.org.uk; davem@davemloft.net; kuba@kernel.org; > pabeni@redhat.com; p.zabel@pengutronix.de; devicetree@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; > linux-kernel@vger.kernel.org; netdev@vger.kernel.org > Cc: BMC-SW <BMC-SW@aspeedtech.com>; stable@vger.kernel.org > Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO > nodes > > On 22/03/2022 03:32, Dylan Hung wrote: > >> -----Original Message----- > >> From: Krzysztof Kozlowski [mailto:krzk@kernel.org] > >> Sent: 2022年3月21日 11:53 PM > >> To: Dylan Hung <dylan_hung@aspeedtech.com>; robh+dt@kernel.org; > >> joel@jms.id.au; andrew@aj.id.au; andrew@lunn.ch; > >> hkallweit1@gmail.com; linux@armlinux.org.uk; davem@davemloft.net; > >> kuba@kernel.org; pabeni@redhat.com; p.zabel@pengutronix.de; > >> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > >> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; > >> netdev@vger.kernel.org > >> Cc: BMC-SW <BMC-SW@aspeedtech.com>; stable@vger.kernel.org > >> Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties > >> into MDIO nodes > >> > >> On 21/03/2022 10:56, Dylan Hung wrote: > >>> Add reset control properties into MDIO nodes. The 4 MDIO > >>> controllers in > >>> AST2600 SOC share one reset control bit SCU50[3]. > >>> > >>> Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com> > >>> Cc: stable@vger.kernel.org > >> > >> Please describe the bug being fixed. See stable-kernel-rules. > > > > Thank you for your comment. > > The reset deassertion of the MDIO device was usually done by the > bootloader (u-boot). > > However, one of our clients uses proprietary bootloader and doesn't > > deassert the MDIO reset so failed to access the HW in kernel driver. > > The reset deassertion is missing in the kernel driver since it was created, > should I add a BugFix for the first commit of this driver? > > Or would it be better if I remove " Cc: stable@vger.kernel.org"? > > This rather looks like a missing feature, not a bug. Anyway any description > must be in commit message. Thank you. I will remove " Cc: stable@vger.kernel.org" and add more description in commit message in V3. > > > Best regards, > Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Dylan Hung <dylan_hung@aspeedtech.com> To: Krzysztof Kozlowski <krzk@kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "joel@jms.id.au" <joel@jms.id.au>, "andrew@aj.id.au" <andrew@aj.id.au>, "andrew@lunn.ch" <andrew@lunn.ch>, "hkallweit1@gmail.com" <hkallweit1@gmail.com>, "linux@armlinux.org.uk" <linux@armlinux.org.uk>, "davem@davemloft.net" <davem@davemloft.net>, "kuba@kernel.org" <kuba@kernel.org>, "pabeni@redhat.com" <pabeni@redhat.com>, "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org> Cc: BMC-SW <BMC-SW@aspeedtech.com>, "stable@vger.kernel.org" <stable@vger.kernel.org> Subject: RE: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes Date: Tue, 22 Mar 2022 08:44:43 +0000 [thread overview] Message-ID: <HK0PR06MB2834EDCF527EE9DE79C1A6AE9C179@HK0PR06MB2834.apcprd06.prod.outlook.com> (raw) In-Reply-To: <216b98d5-a254-4527-c569-9f3397811e70@kernel.org> > -----Original Message----- > From: Krzysztof Kozlowski [mailto:krzk@kernel.org] > Sent: 2022年3月22日 4:40 PM > To: Dylan Hung <dylan_hung@aspeedtech.com>; robh+dt@kernel.org; > joel@jms.id.au; andrew@aj.id.au; andrew@lunn.ch; hkallweit1@gmail.com; > linux@armlinux.org.uk; davem@davemloft.net; kuba@kernel.org; > pabeni@redhat.com; p.zabel@pengutronix.de; devicetree@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; > linux-kernel@vger.kernel.org; netdev@vger.kernel.org > Cc: BMC-SW <BMC-SW@aspeedtech.com>; stable@vger.kernel.org > Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO > nodes > > On 22/03/2022 03:32, Dylan Hung wrote: > >> -----Original Message----- > >> From: Krzysztof Kozlowski [mailto:krzk@kernel.org] > >> Sent: 2022年3月21日 11:53 PM > >> To: Dylan Hung <dylan_hung@aspeedtech.com>; robh+dt@kernel.org; > >> joel@jms.id.au; andrew@aj.id.au; andrew@lunn.ch; > >> hkallweit1@gmail.com; linux@armlinux.org.uk; davem@davemloft.net; > >> kuba@kernel.org; pabeni@redhat.com; p.zabel@pengutronix.de; > >> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > >> linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org; > >> netdev@vger.kernel.org > >> Cc: BMC-SW <BMC-SW@aspeedtech.com>; stable@vger.kernel.org > >> Subject: Re: [PATCH v2 3/3] ARM: dts: aspeed: add reset properties > >> into MDIO nodes > >> > >> On 21/03/2022 10:56, Dylan Hung wrote: > >>> Add reset control properties into MDIO nodes. The 4 MDIO > >>> controllers in > >>> AST2600 SOC share one reset control bit SCU50[3]. > >>> > >>> Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com> > >>> Cc: stable@vger.kernel.org > >> > >> Please describe the bug being fixed. See stable-kernel-rules. > > > > Thank you for your comment. > > The reset deassertion of the MDIO device was usually done by the > bootloader (u-boot). > > However, one of our clients uses proprietary bootloader and doesn't > > deassert the MDIO reset so failed to access the HW in kernel driver. > > The reset deassertion is missing in the kernel driver since it was created, > should I add a BugFix for the first commit of this driver? > > Or would it be better if I remove " Cc: stable@vger.kernel.org"? > > This rather looks like a missing feature, not a bug. Anyway any description > must be in commit message. Thank you. I will remove " Cc: stable@vger.kernel.org" and add more description in commit message in V3. > > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-22 8:44 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-21 9:56 [PATCH v2 0/3] Add reset deassertion for Aspeed MDIO Dylan Hung 2022-03-21 9:56 ` Dylan Hung 2022-03-21 9:56 ` [PATCH v2 1/3] dt-bindings: net: add reset property for aspeed, ast2600-mdio binding Dylan Hung 2022-03-21 9:56 ` Dylan Hung 2022-03-21 12:48 ` Andrew Lunn 2022-03-21 12:48 ` Andrew Lunn 2022-03-21 13:35 ` Rob Herring 2022-03-21 13:35 ` Rob Herring 2022-03-21 15:51 ` Krzysztof Kozlowski 2022-03-21 15:51 ` Krzysztof Kozlowski 2022-03-21 9:56 ` [PATCH v2 2/3] net: mdio: add reset control for Aspeed MDIO Dylan Hung 2022-03-21 9:56 ` Dylan Hung 2022-03-21 10:15 ` Philipp Zabel 2022-03-21 10:15 ` Philipp Zabel 2022-03-21 9:56 ` [PATCH v2 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes Dylan Hung 2022-03-21 9:56 ` Dylan Hung 2022-03-21 15:53 ` Krzysztof Kozlowski 2022-03-21 15:53 ` Krzysztof Kozlowski 2022-03-22 2:32 ` Dylan Hung 2022-03-22 2:32 ` Dylan Hung 2022-03-22 3:00 ` Andrew Lunn 2022-03-22 3:00 ` Andrew Lunn 2022-03-22 3:22 ` Dylan Hung 2022-03-22 3:22 ` Dylan Hung 2022-03-22 9:08 ` Philipp Zabel 2022-03-22 9:08 ` Philipp Zabel 2022-03-22 8:40 ` Krzysztof Kozlowski 2022-03-22 8:40 ` Krzysztof Kozlowski 2022-03-22 8:44 ` Dylan Hung [this message] 2022-03-22 8:44 ` Dylan Hung 2022-03-21 12:45 ` [PATCH v2 0/3] Add reset deassertion for Aspeed MDIO Andrew Lunn 2022-03-21 12:45 ` Andrew Lunn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=HK0PR06MB2834EDCF527EE9DE79C1A6AE9C179@HK0PR06MB2834.apcprd06.prod.outlook.com \ --to=dylan_hung@aspeedtech.com \ --cc=BMC-SW@aspeedtech.com \ --cc=andrew@aj.id.au \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=hkallweit1@gmail.com \ --cc=joel@jms.id.au \ --cc=krzk@kernel.org \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=netdev@vger.kernel.org \ --cc=p.zabel@pengutronix.de \ --cc=pabeni@redhat.com \ --cc=robh+dt@kernel.org \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.