All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neal Liu <neal_liu@aspeedtech.com>
To: Dhananjay Phadke <dphadke@linux.microsoft.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S . Miller" <davem@davemloft.net>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
	Johnny Huang <johnny_huang@aspeedtech.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 5/5] crypto: aspeed: add HACE crypto driver
Date: Mon, 13 Jun 2022 01:48:40 +0000	[thread overview]
Message-ID: <HK0PR06MB32022ABEDDDFD9FB24B8103D80AB9@HK0PR06MB3202.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <6f9e1481-db9c-cd5f-c38d-bdcd3040315f@linux.microsoft.com>

> On 6/6/2022 8:43 PM, Neal Liu wrote:
> >>> +struct aspeed_hace_alg {
> >>> +	struct aspeed_hace_dev		*hace_dev;
> >>> +	union {
> >>> +		struct skcipher_alg	skcipher;
> >>> +		struct aead_alg		aead;
> >>> +		struct ahash_alg	ahash;
> >>> +		struct kpp_alg		kpp;
> >>> +		struct akcipher_alg	akcipher;
> >>
> >> Your patch dont do any kpp or akcipher (and aead/skcipher also).
> >> Please drop this.
> >
> > I miss this part, I'll revise it in next patch, thanks.
> 
> Hi Neal,
> 
> Are you planning to submit aead separately? HW programming interface for
> aes-gcm is almost same as other aes modes except extra regs/fields for tag
> etc.
> 
> 
> Thanks,
> Dhananjay
> 
This engine do not support aead currently, so it needs to be removed.
Thanks

-Neal



WARNING: multiple messages have this Message-ID (diff)
From: Neal Liu <neal_liu@aspeedtech.com>
To: Dhananjay Phadke <dphadke@linux.microsoft.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S . Miller" <davem@davemloft.net>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
	Johnny Huang <johnny_huang@aspeedtech.com>
Cc: "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 5/5] crypto: aspeed: add HACE crypto driver
Date: Mon, 13 Jun 2022 01:48:40 +0000	[thread overview]
Message-ID: <HK0PR06MB32022ABEDDDFD9FB24B8103D80AB9@HK0PR06MB3202.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <6f9e1481-db9c-cd5f-c38d-bdcd3040315f@linux.microsoft.com>

> On 6/6/2022 8:43 PM, Neal Liu wrote:
> >>> +struct aspeed_hace_alg {
> >>> +	struct aspeed_hace_dev		*hace_dev;
> >>> +	union {
> >>> +		struct skcipher_alg	skcipher;
> >>> +		struct aead_alg		aead;
> >>> +		struct ahash_alg	ahash;
> >>> +		struct kpp_alg		kpp;
> >>> +		struct akcipher_alg	akcipher;
> >>
> >> Your patch dont do any kpp or akcipher (and aead/skcipher also).
> >> Please drop this.
> >
> > I miss this part, I'll revise it in next patch, thanks.
> 
> Hi Neal,
> 
> Are you planning to submit aead separately? HW programming interface for
> aes-gcm is almost same as other aes modes except extra regs/fields for tag
> etc.
> 
> 
> Thanks,
> Dhananjay
> 
This engine do not support aead currently, so it needs to be removed.
Thanks

-Neal


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-06-13  1:49 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-01  5:41 [PATCH 0/5] Add Aspeed crypto driver for hardware acceleration Neal Liu
2022-06-01  5:41 ` Neal Liu
2022-06-01  5:42 ` [PATCH 1/5] crypto: aspeed: Add HACE hash driver Neal Liu
2022-06-01  5:42   ` Neal Liu
2022-06-01  7:41   ` Corentin Labbe
2022-06-01  7:41     ` Corentin Labbe
2022-06-01  8:38     ` Neal Liu
2022-06-01  8:38       ` Neal Liu
2022-06-06  8:22       ` Corentin Labbe
2022-06-06  8:22         ` Corentin Labbe
2022-06-07  2:42         ` Neal Liu
2022-06-07  2:42           ` Neal Liu
2022-06-01 20:14   ` Christophe JAILLET
2022-06-01 20:14     ` Christophe JAILLET
2022-06-02  6:34     ` Neal Liu
2022-06-02  6:34       ` Neal Liu
2022-06-01  5:42 ` [PATCH 2/5] dt-bindings: clock: Add AST2600 HACE reset definition Neal Liu
2022-06-01  5:42   ` Neal Liu
2022-06-01  7:45   ` Krzysztof Kozlowski
2022-06-01  7:45     ` Krzysztof Kozlowski
2022-06-01  7:56     ` Neal Liu
2022-06-01  7:56       ` Neal Liu
2022-06-01  5:42 ` [PATCH 3/5] ARM: dts: aspeed: Add HACE device controller node Neal Liu
2022-06-01  5:42   ` Neal Liu
2022-06-01  5:42 ` [PATCH 4/5] dt-bindings: crypto: add documentation for aspeed hace Neal Liu
2022-06-01  5:42   ` Neal Liu
2022-06-01  7:44   ` Krzysztof Kozlowski
2022-06-01  7:44     ` Krzysztof Kozlowski
2022-06-01  8:01     ` Neal Liu
2022-06-01  8:01       ` Neal Liu
2022-06-01  9:19       ` Krzysztof Kozlowski
2022-06-01  9:19         ` Krzysztof Kozlowski
2022-06-01  9:33         ` Neal Liu
2022-06-01  9:33           ` Neal Liu
2022-06-01  5:42 ` [PATCH 5/5] crypto: aspeed: add HACE crypto driver Neal Liu
2022-06-01  5:42   ` Neal Liu
2022-06-01 20:30   ` Christophe JAILLET
2022-06-01 20:30     ` Christophe JAILLET
2022-06-02  6:53     ` Neal Liu
2022-06-02  6:53       ` Neal Liu
2022-06-08 19:33   ` Dhananjay Phadke
2022-06-08 19:33     ` Dhananjay Phadke
2022-06-13  1:48     ` Neal Liu [this message]
2022-06-13  1:48       ` Neal Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=HK0PR06MB32022ABEDDDFD9FB24B8103D80AB9@HK0PR06MB3202.apcprd06.prod.outlook.com \
    --to=neal_liu@aspeedtech.com \
    --cc=andrew@aj.id.au \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dphadke@linux.microsoft.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=joel@jms.id.au \
    --cc=johnny_huang@aspeedtech.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.