From: Neal Liu <neal_liu@aspeedtech.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Felipe Balbi <balbi@kernel.org>, Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>, Cai Huoqing <caihuoqing@baidu.com>, Tao Ren <rentao.bupt@gmail.com>, Julia Lawall <julia.lawall@inria.fr>, kernel test robot <lkp@intel.com>, Sasha Levin <sashal@kernel.org>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>, BMC-SW <BMC-SW@aspeedtech.com> Subject: RE: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor Date: Wed, 1 Dec 2021 05:43:16 +0000 [thread overview] Message-ID: <HK0PR06MB3202436CA49363FD3F60212380689@HK0PR06MB3202.apcprd06.prod.outlook.com> (raw) In-Reply-To: <YaYOvgCaO4FJ8r+z@kroah.com> > -----Original Message----- > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Sent: Tuesday, November 30, 2021 7:45 PM > To: Neal Liu <neal_liu@aspeedtech.com> > Cc: Felipe Balbi <balbi@kernel.org>; Joel Stanley <joel@jms.id.au>; Andrew > Jeffery <andrew@aj.id.au>; Cai Huoqing <caihuoqing@baidu.com>; Tao Ren > <rentao.bupt@gmail.com>; Julia Lawall <julia.lawall@inria.fr>; kernel test > robot <lkp@intel.com>; Sasha Levin <sashal@kernel.org>; > linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; BMC-SW > <BMC-SW@aspeedtech.com> > Subject: Re: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor > > On Tue, Nov 30, 2021 at 06:42:53PM +0800, Neal Liu wrote: > > Support qualifier descriptor to pass USB30CV compliance test. > > Please provide more information here in this description. This does not > explain what is happening here very well. > > Also, what is "USB30CV"? > USB 3 Command Verifier (USB3CV) is the official tool for USB 3 Hub and Device Framework testing. The USB3CV tool includes the xHCI Compliance Drivers for use with the USB3CV. We would like to pass USB3CV - Chapter 9 Test [USB 2 devices] - Device Qualifier Tests. A high-speed capable device that has different device information for full-speed and high-speed must have a Device Qualifier Descriptor. This patch is to support device qualifier, and the host will retrieve it through Get Descriptor request. > > > > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com> > > --- > > drivers/usb/gadget/udc/aspeed-vhub/hub.c | 24 > > +++++++++++++++++++++++ drivers/usb/gadget/udc/aspeed-vhub/vhub.h | > > 1 + > > 2 files changed, 25 insertions(+) > > > > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/hub.c > > b/drivers/usb/gadget/udc/aspeed-vhub/hub.c > > index b9960fdd8a51..93f27a745760 100644 > > --- a/drivers/usb/gadget/udc/aspeed-vhub/hub.c > > +++ b/drivers/usb/gadget/udc/aspeed-vhub/hub.c > > @@ -68,6 +68,18 @@ static const struct usb_device_descriptor > ast_vhub_dev_desc = { > > .bNumConfigurations = 1, > > }; > > > > +static const struct usb_qualifier_descriptor ast_vhub_qual_desc = { > > + .bLength = 0xA, > > + .bDescriptorType = USB_DT_DEVICE_QUALIFIER, > > + .bcdUSB = cpu_to_le16(0x0200), > > + .bDeviceClass = USB_CLASS_HUB, > > + .bDeviceSubClass = 0, > > + .bDeviceProtocol = 0, > > + .bMaxPacketSize0 = 64, > > + .bNumConfigurations = 1, > > + .bRESERVED = 0, > > Fields that are to be set to zero do not need to be set here, the compiler does it > for you. > > thanks, > > greg k-h This is more clear that we specify each member's value. Thanks -Neal
WARNING: multiple messages have this Message-ID (diff)
From: Neal Liu <neal_liu@aspeedtech.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Felipe Balbi <balbi@kernel.org>, Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>, Cai Huoqing <caihuoqing@baidu.com>, Tao Ren <rentao.bupt@gmail.com>, Julia Lawall <julia.lawall@inria.fr>, kernel test robot <lkp@intel.com>, Sasha Levin <sashal@kernel.org>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>, BMC-SW <BMC-SW@aspeedtech.com> Subject: RE: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor Date: Wed, 1 Dec 2021 05:43:16 +0000 [thread overview] Message-ID: <HK0PR06MB3202436CA49363FD3F60212380689@HK0PR06MB3202.apcprd06.prod.outlook.com> (raw) In-Reply-To: <YaYOvgCaO4FJ8r+z@kroah.com> > -----Original Message----- > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Sent: Tuesday, November 30, 2021 7:45 PM > To: Neal Liu <neal_liu@aspeedtech.com> > Cc: Felipe Balbi <balbi@kernel.org>; Joel Stanley <joel@jms.id.au>; Andrew > Jeffery <andrew@aj.id.au>; Cai Huoqing <caihuoqing@baidu.com>; Tao Ren > <rentao.bupt@gmail.com>; Julia Lawall <julia.lawall@inria.fr>; kernel test > robot <lkp@intel.com>; Sasha Levin <sashal@kernel.org>; > linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; BMC-SW > <BMC-SW@aspeedtech.com> > Subject: Re: [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor > > On Tue, Nov 30, 2021 at 06:42:53PM +0800, Neal Liu wrote: > > Support qualifier descriptor to pass USB30CV compliance test. > > Please provide more information here in this description. This does not > explain what is happening here very well. > > Also, what is "USB30CV"? > USB 3 Command Verifier (USB3CV) is the official tool for USB 3 Hub and Device Framework testing. The USB3CV tool includes the xHCI Compliance Drivers for use with the USB3CV. We would like to pass USB3CV - Chapter 9 Test [USB 2 devices] - Device Qualifier Tests. A high-speed capable device that has different device information for full-speed and high-speed must have a Device Qualifier Descriptor. This patch is to support device qualifier, and the host will retrieve it through Get Descriptor request. > > > > Signed-off-by: Neal Liu <neal_liu@aspeedtech.com> > > --- > > drivers/usb/gadget/udc/aspeed-vhub/hub.c | 24 > > +++++++++++++++++++++++ drivers/usb/gadget/udc/aspeed-vhub/vhub.h | > > 1 + > > 2 files changed, 25 insertions(+) > > > > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/hub.c > > b/drivers/usb/gadget/udc/aspeed-vhub/hub.c > > index b9960fdd8a51..93f27a745760 100644 > > --- a/drivers/usb/gadget/udc/aspeed-vhub/hub.c > > +++ b/drivers/usb/gadget/udc/aspeed-vhub/hub.c > > @@ -68,6 +68,18 @@ static const struct usb_device_descriptor > ast_vhub_dev_desc = { > > .bNumConfigurations = 1, > > }; > > > > +static const struct usb_qualifier_descriptor ast_vhub_qual_desc = { > > + .bLength = 0xA, > > + .bDescriptorType = USB_DT_DEVICE_QUALIFIER, > > + .bcdUSB = cpu_to_le16(0x0200), > > + .bDeviceClass = USB_CLASS_HUB, > > + .bDeviceSubClass = 0, > > + .bDeviceProtocol = 0, > > + .bMaxPacketSize0 = 64, > > + .bNumConfigurations = 1, > > + .bRESERVED = 0, > > Fields that are to be set to zero do not need to be set here, the compiler does it > for you. > > thanks, > > greg k-h This is more clear that we specify each member's value. Thanks -Neal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-01 5:43 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-30 10:42 [PATCH v2 0/4] Refactor Aspeed USB vhub driver Neal Liu 2021-11-30 10:42 ` Neal Liu 2021-11-30 10:42 ` [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor Neal Liu 2021-11-30 10:42 ` Neal Liu 2021-11-30 11:45 ` Greg Kroah-Hartman 2021-11-30 11:45 ` Greg Kroah-Hartman 2021-12-01 5:43 ` Neal Liu [this message] 2021-12-01 5:43 ` Neal Liu 2021-12-01 6:18 ` Greg Kroah-Hartman 2021-12-01 6:18 ` Greg Kroah-Hartman 2021-12-01 6:31 ` Neal Liu 2021-12-01 6:31 ` Neal Liu 2021-11-30 10:42 ` [PATCH v2 2/4] usb: aspeed-vhub: support auto remote wakeup feature Neal Liu 2021-11-30 10:42 ` Neal Liu 2021-11-30 10:42 ` [PATCH v2 3/4] usb: aspeed-vhub: fix ep0 OUT ack received wrong length issue Neal Liu 2021-11-30 10:42 ` Neal Liu 2021-11-30 11:47 ` Greg Kroah-Hartman 2021-11-30 11:47 ` Greg Kroah-Hartman 2021-12-01 2:17 ` Neal Liu 2021-12-01 2:17 ` Neal Liu 2021-11-30 10:42 ` [PATCH v2 4/4] usb: aspeed-vhub: support test mode feature Neal Liu 2021-11-30 10:42 ` Neal Liu 2021-11-30 11:47 ` Greg Kroah-Hartman 2021-11-30 11:47 ` Greg Kroah-Hartman 2021-12-01 3:36 ` Neal Liu 2021-12-01 3:36 ` Neal Liu 2021-11-30 11:38 [PATCH v2 0/4] Refactor Aspeed USB vhub driver Neal Liu 2021-11-30 11:38 ` [PATCH v2 1/4] usb: aspeed-vhub: add qualifier descriptor Neal Liu 2021-11-30 11:38 ` Neal Liu 2021-11-30 11:42 ` Greg Kroah-Hartman 2021-11-30 11:42 ` Greg Kroah-Hartman 2021-12-01 2:09 ` Neal Liu 2021-12-01 2:09 ` Neal Liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=HK0PR06MB3202436CA49363FD3F60212380689@HK0PR06MB3202.apcprd06.prod.outlook.com \ --to=neal_liu@aspeedtech.com \ --cc=BMC-SW@aspeedtech.com \ --cc=andrew@aj.id.au \ --cc=balbi@kernel.org \ --cc=caihuoqing@baidu.com \ --cc=gregkh@linuxfoundation.org \ --cc=joel@jms.id.au \ --cc=julia.lawall@inria.fr \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=lkp@intel.com \ --cc=rentao.bupt@gmail.com \ --cc=sashal@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.