All of lore.kernel.org
 help / color / mirror / Atom feed
* [Ocfs2-devel] [PATCH] ocfs2: Correct the offset comments of the structure ocfs2_dir_block_trailer.
@ 2018-05-08  9:46 Guozhonghua
  2018-05-08 14:53 ` Changwei Ge
  2018-05-09  1:01 ` Joseph Qi
  0 siblings, 2 replies; 5+ messages in thread
From: Guozhonghua @ 2018-05-08  9:46 UTC (permalink / raw)
  To: ocfs2-devel

Correct the offset comments of the structure ocfs2_dir_block_trailer.

Signed-off-by: guozhonghua <guozhonghua@h3c.com>
---
 fs/ocfs2/ocfs2_fs.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2/ocfs2_fs.h index 5bb4a89..14c60b0 100644
--- a/fs/ocfs2/ocfs2_fs.h
+++ b/fs/ocfs2/ocfs2_fs.h
@@ -808,10 +808,10 @@ struct ocfs2_dir_block_trailer {
 /*10*/	__u8		db_signature[8];	/* Signature for verification */
 	__le64		db_reserved2;
 	__le64		db_free_next;		/* Next block in list (unused) */
-/*20*/	__le64		db_blkno;		/* Offset on disk, in blocks */
+/*28*/	__le64		db_blkno;		/* Offset on disk, in blocks */
 	__le64		db_parent_dinode;	/* dinode which owns me, in
 						   blocks */
-/*30*/	struct ocfs2_block_check db_check;	/* Error checking */
+/*38*/	struct ocfs2_block_check db_check;	/* Error checking */
 /*40*/
 };
 
--
1.7.9.5

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2: Correct the offset comments of the structure ocfs2_dir_block_trailer.
  2018-05-08  9:46 [Ocfs2-devel] [PATCH] ocfs2: Correct the offset comments of the structure ocfs2_dir_block_trailer Guozhonghua
@ 2018-05-08 14:53 ` Changwei Ge
  2018-05-09  1:01 ` Joseph Qi
  1 sibling, 0 replies; 5+ messages in thread
From: Changwei Ge @ 2018-05-08 14:53 UTC (permalink / raw)
  To: ocfs2-devel

It looks good to me.


On 2018/5/8 5:46 PM, Guozhonghua wrote:
> Correct the offset comments of the structure ocfs2_dir_block_trailer.
Reviewed-by: Changwei Ge <ge.changwei@h3c.com>
>
> Signed-off-by: guozhonghua <guozhonghua@h3c.com>
> ---
>   fs/ocfs2/ocfs2_fs.h |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2/ocfs2_fs.h index 5bb4a89..14c60b0 100644
> --- a/fs/ocfs2/ocfs2_fs.h
> +++ b/fs/ocfs2/ocfs2_fs.h
> @@ -808,10 +808,10 @@ struct ocfs2_dir_block_trailer {
>   /*10*/	__u8		db_signature[8];	/* Signature for verification */
>   	__le64		db_reserved2;
>   	__le64		db_free_next;		/* Next block in list (unused) */
> -/*20*/	__le64		db_blkno;		/* Offset on disk, in blocks */
> +/*28*/	__le64		db_blkno;		/* Offset on disk, in blocks */
>   	__le64		db_parent_dinode;	/* dinode which owns me, in
>   						   blocks */
> -/*30*/	struct ocfs2_block_check db_check;	/* Error checking */
> +/*38*/	struct ocfs2_block_check db_check;	/* Error checking */
>   /*40*/
>   };
>   
> --
> 1.7.9.5
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2: Correct the offset comments of the structure ocfs2_dir_block_trailer.
  2018-05-08  9:46 [Ocfs2-devel] [PATCH] ocfs2: Correct the offset comments of the structure ocfs2_dir_block_trailer Guozhonghua
  2018-05-08 14:53 ` Changwei Ge
@ 2018-05-09  1:01 ` Joseph Qi
  2018-05-09  2:50   ` [Ocfs2-devel] 答复: " Guozhonghua
  1 sibling, 1 reply; 5+ messages in thread
From: Joseph Qi @ 2018-05-09  1:01 UTC (permalink / raw)
  To: ocfs2-devel

Umm... We always explicitly comment out the shift of 0x10, 0x20, ...,
IMO, we'd better move the comments to the correct place instead of
change it to something like 0x28.

Thanks,
Joseph

On 18/5/8 17:46, Guozhonghua wrote:
> Correct the offset comments of the structure ocfs2_dir_block_trailer.
> 
> Signed-off-by: guozhonghua <guozhonghua@h3c.com>
> ---
>  fs/ocfs2/ocfs2_fs.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2/ocfs2_fs.h index 5bb4a89..14c60b0 100644
> --- a/fs/ocfs2/ocfs2_fs.h
> +++ b/fs/ocfs2/ocfs2_fs.h
> @@ -808,10 +808,10 @@ struct ocfs2_dir_block_trailer {
>  /*10*/	__u8		db_signature[8];	/* Signature for verification */
>  	__le64		db_reserved2;
>  	__le64		db_free_next;		/* Next block in list (unused) */
> -/*20*/	__le64		db_blkno;		/* Offset on disk, in blocks */
> +/*28*/	__le64		db_blkno;		/* Offset on disk, in blocks */
>  	__le64		db_parent_dinode;	/* dinode which owns me, in
>  						   blocks */
> -/*30*/	struct ocfs2_block_check db_check;	/* Error checking */
> +/*38*/	struct ocfs2_block_check db_check;	/* Error checking */
>  /*40*/
>  };
>  
> --
> 1.7.9.5
> 
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Ocfs2-devel] 答复:  [PATCH] ocfs2: Correct the offset comments of the structure ocfs2_dir_block_trailer.
  2018-05-09  1:01 ` Joseph Qi
@ 2018-05-09  2:50   ` Guozhonghua
  2018-05-09  3:09     ` Changwei Ge
  0 siblings, 1 reply; 5+ messages in thread
From: Guozhonghua @ 2018-05-09  2:50 UTC (permalink / raw)
  To: ocfs2-devel

Good Idea, I will send patch v2 for review. 

Thanks.

Guozhonghua. 

-----????-----
???: Joseph Qi [mailto:jiangqi903 at gmail.com] 
????: 2018?5?9? 9:01
???: guozhonghua (Cloud); Andrew Morton (akpm at linux-foundation.org)
??: 'ocfs2-devel at oss.oracle.com' (ocfs2-devel at oss.oracle.com)
??: Re: [Ocfs2-devel] [PATCH] ocfs2: Correct the offset comments of the structure ocfs2_dir_block_trailer.

Umm... We always explicitly comment out the shift of 0x10, 0x20, ..., IMO, we'd better move the comments to the correct place instead of change it to something like 0x28.

Thanks,
Joseph

On 18/5/8 17:46, Guozhonghua wrote:
> Correct the offset comments of the structure ocfs2_dir_block_trailer.
> 
> Signed-off-by: guozhonghua <guozhonghua@h3c.com>
> ---
>  fs/ocfs2/ocfs2_fs.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2/ocfs2_fs.h index 
> 5bb4a89..14c60b0 100644
> --- a/fs/ocfs2/ocfs2_fs.h
> +++ b/fs/ocfs2/ocfs2_fs.h
> @@ -808,10 +808,10 @@ struct ocfs2_dir_block_trailer {
>  /*10*/	__u8		db_signature[8];	/* Signature for verification */
>  	__le64		db_reserved2;
>  	__le64		db_free_next;		/* Next block in list (unused) */
> -/*20*/	__le64		db_blkno;		/* Offset on disk, in blocks */
> +/*28*/	__le64		db_blkno;		/* Offset on disk, in blocks */
>  	__le64		db_parent_dinode;	/* dinode which owns me, in
>  						   blocks */
> -/*30*/	struct ocfs2_block_check db_check;	/* Error checking */
> +/*38*/	struct ocfs2_block_check db_check;	/* Error checking */
>  /*40*/
>  };
>  
> --
> 1.7.9.5
> 
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Ocfs2-devel] 答复: [PATCH] ocfs2: Correct the offset comments of the structure ocfs2_dir_block_trailer.
  2018-05-09  2:50   ` [Ocfs2-devel] 答复: " Guozhonghua
@ 2018-05-09  3:09     ` Changwei Ge
  0 siblings, 0 replies; 5+ messages in thread
From: Changwei Ge @ 2018-05-09  3:09 UTC (permalink / raw)
  To: ocfs2-devel

Hi Zhonghua and Jospeh,

I'm afraid that it can't be easy to find the offest 0x20 since 
::db_signature only occupy 8 bytes.

Thanks,
Changwei

On 2018/5/9 10:50, Guozhonghua wrote:
> Good Idea, I will send patch v2 for review.
>
> Thanks.
>
> Guozhonghua.
>
> -----????-----
> ???: Joseph Qi [mailto:jiangqi903 at gmail.com]
> ????: 2018?5?9? 9:01
> ???: guozhonghua (Cloud); Andrew Morton (akpm at linux-foundation.org)
> ??: 'ocfs2-devel at oss.oracle.com' (ocfs2-devel at oss.oracle.com)
> ??: Re: [Ocfs2-devel] [PATCH] ocfs2: Correct the offset comments of the structure ocfs2_dir_block_trailer.
>
> Umm... We always explicitly comment out the shift of 0x10, 0x20, ..., IMO, we'd better move the comments to the correct place instead of change it to something like 0x28.
>
> Thanks,
> Joseph
>
> On 18/5/8 17:46, Guozhonghua wrote:
>> Correct the offset comments of the structure ocfs2_dir_block_trailer.
>>
>> Signed-off-by: guozhonghua <guozhonghua@h3c.com>
>> ---
>>   fs/ocfs2/ocfs2_fs.h |    4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2/ocfs2_fs.h index
>> 5bb4a89..14c60b0 100644
>> --- a/fs/ocfs2/ocfs2_fs.h
>> +++ b/fs/ocfs2/ocfs2_fs.h
>> @@ -808,10 +808,10 @@ struct ocfs2_dir_block_trailer {
>>   /*10*/	__u8		db_signature[8];	/* Signature for verification */
>>   	__le64		db_reserved2;
>>   	__le64		db_free_next;		/* Next block in list (unused) */
>> -/*20*/	__le64		db_blkno;		/* Offset on disk, in blocks */
>> +/*28*/	__le64		db_blkno;		/* Offset on disk, in blocks */
>>   	__le64		db_parent_dinode;	/* dinode which owns me, in
>>   						   blocks */
>> -/*30*/	struct ocfs2_block_check db_check;	/* Error checking */
>> +/*38*/	struct ocfs2_block_check db_check;	/* Error checking */
>>   /*40*/
>>   };
>>   
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> Ocfs2-devel mailing list
>> Ocfs2-devel at oss.oracle.com
>> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
>>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-09  3:09 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-08  9:46 [Ocfs2-devel] [PATCH] ocfs2: Correct the offset comments of the structure ocfs2_dir_block_trailer Guozhonghua
2018-05-08 14:53 ` Changwei Ge
2018-05-09  1:01 ` Joseph Qi
2018-05-09  2:50   ` [Ocfs2-devel] 答复: " Guozhonghua
2018-05-09  3:09     ` Changwei Ge

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.