RE: [PATCH v10 1/2] ethdev: add query and update sync and async function calls

From: Gregory Etelson <getelson@nvidia.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Matan Azrad <matan@nvidia.com>,
	Raslan Darawsheh <rasland@nvidia.com>, Ori Kam <orika@nvidia.com>,
	"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
	Lior Margalit <lmargalit@nvidia.com>
Subject: RE: [PATCH v10 1/2] ethdev: add query and update sync and async function calls
Date: Mon, 13 Feb 2023 12:30:23 +0000	[thread overview]
Message-ID: <IA1PR12MB63322D27B30DC411368CBB13A5DD9@IA1PR12MB6332.namprd12.prod.outlook.com> (raw)
In-Reply-To: <IA1PR12MB63329BE7A8017C1127DDD601A5DC9@IA1PR12MB6332.namprd12.prod.outlook.com>

Hello Andrew,

What holds merge of https://patches.dpdk.org/project/dpdk/list/?series=26763 ?

Regards,
Gregory

> -----Original Message-----
> From: Gregory Etelson
> Sent: Sunday, 12 February 2023 13:13
> To: Ferruh Yigit <ferruh.yigit@amd.com>; dev@dpdk.org; Andrew
> Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Cc: Matan Azrad <matan@nvidia.com>; Raslan Darawsheh
> <rasland@nvidia.com>; Ori Kam <orika@nvidia.com>; NBU-Contact-Thomas
> Monjalon (EXTERNAL) <thomas@monjalon.net>
> Subject: RE: [PATCH v10 1/2] ethdev: add query and update sync and async
> function calls
> 
> Hello Ferruh,
> 
> What holds merge of
> https://patches.dpdk.org/project/dpdk/list/?series=26763 ?
> 
> Regards,
> Gregory
> 
> > -----Original Message-----
> > From: Ferruh Yigit <ferruh.yigit@amd.com>
> > Sent: Thursday, 9 February 2023 17:14
> > To: Gregory Etelson <getelson@nvidia.com>; dev@dpdk.org; Andrew
> > Rybchenko <andrew.rybchenko@oktetlabs.ru>
> > Cc: Matan Azrad <matan@nvidia.com>; Raslan Darawsheh
> > <rasland@nvidia.com>; Ori Kam <orika@nvidia.com>; NBU-Contact-
> Thomas
> > Monjalon (EXTERNAL) <thomas@monjalon.net>
> > Subject: Re: [PATCH v10 1/2] ethdev: add query and update sync and
> async
> > function calls
> >
> > External email: Use caution opening links or attachments
> >
> >
> > On 2/2/2023 1:47 PM, Gregory Etelson wrote:
> > > Current API allows either query or update indirect flow action.
> > > If indirect action must be conditionally updated according to it's
> > > present state application must first issue action query then
> > > analyze returned data and if needed issue update request.
> > > When the update will be processed, action state can change and
> > > the update can invalidate the action.
> > >
> > > Add `rte_flow_action_handle_query_update` function call,
> > > and it's async version `rte_flow_async_action_handle_query_update`
> > > to atomically query and update flow action.
> > >
> > > Application can control query and update order, if that is supported
> > > by port hardware, by setting `qu_mode` parameter to
> > > RTE_FLOW_QU_QUERY_FIRST or RTE_FLOW_QU_UPDATE_FIRST.
> > >
> > > Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> > > Acked-by: Ori Kam <orika@nvidia.com>
> > > ---
> > > v2: Remove RTE_FLOW_QU_DEFAULT query-update mode.
> > > v3: Update release release notes.
> > >     Fix doxygen errors.
> > > v4: Add returned errno codes.
> > > v5: Update the patch description.
> > >     Fix typos.
> > > v6: Resolve merge conflict with the main branch.
> > > v7: Update documentation.
> > > v8: Style fixes.
> > > v9: Add parameters validation.
> > > v10: Code update.
> >
> > it seems there were some comments from Andrew to previous version,
> are
> > they resolved now?
> >
> > @Andrew, do you have any objection/comment on this version?