Re: [PATCH v8 1/2] ethdev: add query_update sync and async function calls

From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Gregory Etelson <getelson@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>,
	Raslan Darawsheh <rasland@nvidia.com>, Ori Kam <orika@nvidia.com>,
	"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
	Ferruh Yigit <ferruh.yigit@amd.com>
Subject: Re: [PATCH v8 1/2] ethdev: add query_update sync and async function calls
Date: Thu, 2 Feb 2023 13:47:36 +0300	[thread overview]
Message-ID: <c29ac2f7-08f8-fde3-c790-f0562f6f8c3c@oktetlabs.ru> (raw)
In-Reply-To: <IA1PR12MB63329539076088AA4A5DFD77A5D69@IA1PR12MB6332.namprd12.prod.outlook.com>

On 2/2/23 13:44, Gregory Etelson wrote:
> Hello Andrew,
> 
> []
> 
>> On 2/2/23 13:24, Gregory Etelson wrote:
>>>> On 2/1/23 18:16, Gregory Etelson wrote:
>>>>> +     ops = rte_flow_ops_get(port_id, error);
>>>>> +     if (!ops || !ops->action_handle_query_update)
>>>>> +             return -ENOTSUP;
>>>>
>>>> May be it makes sense to use single-operation callbacks if
>>>> another operation input is NULL. I guess it could be
>>>> convenient in some cases. Just an idea.
>>>>
>>>
>>> There is a plan to deprecate indirect query and update functions
>>> and replace them with a single query_update.
>>
>> So, will you add corresponding code? Just want to clarify.
>>
> 
> There is ongoing work on next stage of indirect action functions.
> The plan is to deprecate existing API when all updates will be introduced.

IMHO nothing prevents to add handling right now. It will allow
to use query_update instead of just query or update from the
very beginning. Not a strong requirement. Just nice to have
from my point of view.