* Re: [PATCH v2 4/4] arm64: dts: qcom: sm8250: Drop tcsr_mutex syscon
@ 2021-12-25 14:57 David Heidelberg
2021-12-29 15:42 ` Bjorn Andersson
0 siblings, 1 reply; 5+ messages in thread
From: David Heidelberg @ 2021-12-25 14:57 UTC (permalink / raw)
To: Bjorn Andersson
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
Andy Gross, Ohad Ben-Cohen, Baolin Wang, Rob Herring
Hello,
any particular reason, why you did applied this patch only to sm8250?
Is it safe to convert rest of tcsr-mutex nodes to new schema without
additional testing?
Thanks
David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 4/4] arm64: dts: qcom: sm8250: Drop tcsr_mutex syscon
2021-12-25 14:57 [PATCH v2 4/4] arm64: dts: qcom: sm8250: Drop tcsr_mutex syscon David Heidelberg
@ 2021-12-29 15:42 ` Bjorn Andersson
0 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2021-12-29 15:42 UTC (permalink / raw)
To: 20200622075956.171058-5-bjorn.andersson
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel,
Andy Gross, Ohad Ben-Cohen, Baolin Wang, Rob Herring
On Sat 25 Dec 06:57 PST 2021, David Heidelberg wrote:
> Hello,
>
> any particular reason, why you did applied this patch only to sm8250?
>
I was working on a 8250 board when this annoyed me, and I wanted to keep
the "example" clean so I only did that platform and then forgot to go
back and clean up the rest. (Same thing with the smem compatible moving
to reserved-memory).
> Is it safe to convert rest of tcsr-mutex nodes to new schema without
> additional testing?
>
I can't think of any reason it wouldn't be safe, so please feel free to
prepare a patch.
Thanks,
Bjorn
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 0/4] hwspinlock: qcom: Allow dropping the intermediate TCSR mutex syscon
@ 2020-06-22 7:59 Bjorn Andersson
2020-06-22 7:59 ` [PATCH v2 4/4] arm64: dts: qcom: sm8250: Drop tcsr_mutex syscon Bjorn Andersson
0 siblings, 1 reply; 5+ messages in thread
From: Bjorn Andersson @ 2020-06-22 7:59 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Ohad Ben-Cohen, Baolin Wang, Rob Herring
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel
In modern Qualcomm platforms the mutex region of the TCSR is forked off into
its own block, all with a offset of 0 and stride of 4096, and in some of these
platforms no other registers in this region is accessed from Linux. Update the
binding and the implementation to allow the TCSR mutex to be represented
without an intermediate syscon node.
Bjorn Andersson (4):
dt-bindings: hwlock: qcom: Migrate binding to YAML
dt-bindings: hwlock: qcom: Allow device on mmio bus
hwspinlock: qcom: Allow mmio usage in addition to syscon
arm64: dts: qcom: sm8250: Drop tcsr_mutex syscon
.../bindings/hwlock/qcom-hwspinlock.txt | 39 -----------
.../bindings/hwlock/qcom-hwspinlock.yaml | 65 +++++++++++++++++
arch/arm64/boot/dts/qcom/sm8250.dtsi | 17 ++---
drivers/hwspinlock/qcom_hwspinlock.c | 70 ++++++++++++++-----
4 files changed, 125 insertions(+), 66 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.txt
create mode 100644 Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.yaml
--
2.26.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 4/4] arm64: dts: qcom: sm8250: Drop tcsr_mutex syscon
2020-06-22 7:59 [PATCH v2 0/4] hwspinlock: qcom: Allow dropping the intermediate TCSR mutex syscon Bjorn Andersson
@ 2020-06-22 7:59 ` Bjorn Andersson
2020-07-15 19:36 ` Dmitry Baryshkov
2020-07-16 2:59 ` Manivannan Sadhasivam
0 siblings, 2 replies; 5+ messages in thread
From: Bjorn Andersson @ 2020-06-22 7:59 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Ohad Ben-Cohen, Baolin Wang, Rob Herring
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel
Now that we don't need the intermediate syscon to represent the TCSR
mutexes, update the dts to describe the TCSR mutex directly under /soc.
The change also fixes the sort order of the nodes.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
Changs since v1:
- Adjusted sort order of the nodes
arch/arm64/boot/dts/qcom/sm8250.dtsi | 17 ++++++-----------
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index 7050adba7995..67a1b6f3301b 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -144,12 +144,6 @@ scm: scm {
};
};
- tcsr_mutex: hwlock {
- compatible = "qcom,tcsr-mutex";
- syscon = <&tcsr_mutex_regs 0 0x1000>;
- #hwlock-cells = <1>;
- };
-
memory@80000000 {
device_type = "memory";
/* We expect the bootloader to fill in the size */
@@ -376,6 +370,12 @@ ufs_mem_phy_lanes: lanes@1d87400 {
};
};
+ tcsr_mutex: hwlock@1f40000 {
+ compatible = "qcom,tcsr-mutex";
+ reg = <0x0 0x01f40000 0x0 0x40000>;
+ #hwlock-cells = <1>;
+ };
+
intc: interrupt-controller@17a00000 {
compatible = "arm,gic-v3";
#interrupt-cells = <3>;
@@ -486,11 +486,6 @@ rpmhpd_opp_turbo_l1: opp10 {
};
};
- tcsr_mutex_regs: syscon@1f40000 {
- compatible = "syscon";
- reg = <0x0 0x01f40000 0x0 0x40000>;
- };
-
timer@17c20000 {
#address-cells = <2>;
#size-cells = <2>;
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 4/4] arm64: dts: qcom: sm8250: Drop tcsr_mutex syscon
2020-06-22 7:59 ` [PATCH v2 4/4] arm64: dts: qcom: sm8250: Drop tcsr_mutex syscon Bjorn Andersson
@ 2020-07-15 19:36 ` Dmitry Baryshkov
2020-07-16 2:59 ` Manivannan Sadhasivam
1 sibling, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2020-07-15 19:36 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, Ohad Ben-Cohen, Baolin Wang, Rob Herring,
open list:DRM DRIVER FOR MSM ADRENO GPU, linux-remoteproc,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
On Mon, 22 Jun 2020 at 11:00, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> Now that we don't need the intermediate syscon to represent the TCSR
> mutexes, update the dts to describe the TCSR mutex directly under /soc.
>
> The change also fixes the sort order of the nodes.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 4/4] arm64: dts: qcom: sm8250: Drop tcsr_mutex syscon
2020-06-22 7:59 ` [PATCH v2 4/4] arm64: dts: qcom: sm8250: Drop tcsr_mutex syscon Bjorn Andersson
2020-07-15 19:36 ` Dmitry Baryshkov
@ 2020-07-16 2:59 ` Manivannan Sadhasivam
1 sibling, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2020-07-16 2:59 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, Ohad Ben-Cohen, Baolin Wang, Rob Herring,
linux-arm-msm, linux-remoteproc, devicetree, linux-kernel
On Mon, Jun 22, 2020 at 12:59:56AM -0700, Bjorn Andersson wrote:
> Now that we don't need the intermediate syscon to represent the TCSR
> mutexes, update the dts to describe the TCSR mutex directly under /soc.
>
> The change also fixes the sort order of the nodes.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
>
> Changs since v1:
> - Adjusted sort order of the nodes
>
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 17 ++++++-----------
> 1 file changed, 6 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 7050adba7995..67a1b6f3301b 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -144,12 +144,6 @@ scm: scm {
> };
> };
>
> - tcsr_mutex: hwlock {
> - compatible = "qcom,tcsr-mutex";
> - syscon = <&tcsr_mutex_regs 0 0x1000>;
> - #hwlock-cells = <1>;
> - };
> -
> memory@80000000 {
> device_type = "memory";
> /* We expect the bootloader to fill in the size */
> @@ -376,6 +370,12 @@ ufs_mem_phy_lanes: lanes@1d87400 {
> };
> };
>
> + tcsr_mutex: hwlock@1f40000 {
> + compatible = "qcom,tcsr-mutex";
> + reg = <0x0 0x01f40000 0x0 0x40000>;
> + #hwlock-cells = <1>;
> + };
> +
> intc: interrupt-controller@17a00000 {
> compatible = "arm,gic-v3";
> #interrupt-cells = <3>;
> @@ -486,11 +486,6 @@ rpmhpd_opp_turbo_l1: opp10 {
> };
> };
>
> - tcsr_mutex_regs: syscon@1f40000 {
> - compatible = "syscon";
> - reg = <0x0 0x01f40000 0x0 0x40000>;
> - };
> -
> timer@17c20000 {
> #address-cells = <2>;
> #size-cells = <2>;
> --
> 2.26.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-12-29 15:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-25 14:57 [PATCH v2 4/4] arm64: dts: qcom: sm8250: Drop tcsr_mutex syscon David Heidelberg
2021-12-29 15:42 ` Bjorn Andersson
-- strict thread matches above, loose matches on Subject: below --
2020-06-22 7:59 [PATCH v2 0/4] hwspinlock: qcom: Allow dropping the intermediate TCSR mutex syscon Bjorn Andersson
2020-06-22 7:59 ` [PATCH v2 4/4] arm64: dts: qcom: sm8250: Drop tcsr_mutex syscon Bjorn Andersson
2020-07-15 19:36 ` Dmitry Baryshkov
2020-07-16 2:59 ` Manivannan Sadhasivam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.