* [PATCH] drm/amd/display: Align dcn314_smu logging with other DCNs
@ 2022-11-14 21:07 Roman.Li
2022-11-14 21:15 ` Limonciello, Mario
0 siblings, 1 reply; 5+ messages in thread
From: Roman.Li @ 2022-11-14 21:07 UTC (permalink / raw)
To: amd-gfx, Alexander.Deucher, harry.wentland, mario.limonciello,
SyedSaaem.Rizvi
Cc: Roman Li
From: Roman Li <roman.li@amd.com>
[Why]
Assert on non-OK response from SMU is unnecessary.
It was replaced with respective log message on other asics
in the past with commit:
"drm/amd/display: Removing assert statements for Linux"
[How]
Remove asert and add dbg logging as on other DCNs.
CC: Saaem Rizvi <SyedSaaem.Rizvi@amd.com>
Signed-off-by: Roman Li <roman.li@amd.com>
---
.../drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
index ef0795b14a1f..2db595672a46 100644
--- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
+++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
@@ -123,9 +123,10 @@ static int dcn314_smu_send_msg_with_param(struct clk_mgr_internal *clk_mgr,
uint32_t result;
result = dcn314_smu_wait_for_response(clk_mgr, 10, 200000);
- ASSERT(result == VBIOSSMC_Result_OK);
- smu_print("SMU response after wait: %d\n", result);
+ if (result != VBIOSSMC_Result_OK)
+ smu_print("SMU Response was not OK. SMU response after wait received is: %d\n",
+ result);
if (result == VBIOSSMC_Status_BUSY)
return -1;
@@ -216,6 +217,12 @@ int dcn314_smu_set_hard_min_dcfclk(struct clk_mgr_internal *clk_mgr, int request
VBIOSSMC_MSG_SetHardMinDcfclkByFreq,
khz_to_mhz_ceil(requested_dcfclk_khz));
+#ifdef DBG
+ smu_print("actual_dcfclk_set_mhz %d is set to : %d\n",
+ actual_dcfclk_set_mhz,
+ actual_dcfclk_set_mhz * 1000);
+#endif
+
return actual_dcfclk_set_mhz * 1000;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH] drm/amd/display: Align dcn314_smu logging with other DCNs
2022-11-14 21:07 [PATCH] drm/amd/display: Align dcn314_smu logging with other DCNs Roman.Li
@ 2022-11-14 21:15 ` Limonciello, Mario
2022-11-15 17:51 ` Li, Roman
0 siblings, 1 reply; 5+ messages in thread
From: Limonciello, Mario @ 2022-11-14 21:15 UTC (permalink / raw)
To: Li, Roman, amd-gfx, Deucher, Alexander, Wentland, Harry, Rizvi, Saaem
Cc: Li, Roman
[Public]
Conceptually makes sense to me, but please see below comments:
> -----Original Message-----
> From: Roman.Li@amd.com <Roman.Li@amd.com>
> Sent: Monday, November 14, 2022 15:07
> To: amd-gfx@lists.freedesktop.org; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Wentland, Harry
> <Harry.Wentland@amd.com>; Limonciello, Mario
> <Mario.Limonciello@amd.com>; Rizvi, Saaem <SyedSaaem.Rizvi@amd.com>
> Cc: Li, Roman <Roman.Li@amd.com>
> Subject: [PATCH] drm/amd/display: Align dcn314_smu logging with other
> DCNs
>
> From: Roman Li <roman.li@amd.com>
>
> [Why]
> Assert on non-OK response from SMU is unnecessary.
> It was replaced with respective log message on other asics
> in the past with commit:
> "drm/amd/display: Removing assert statements for Linux"
>
> [How]
> Remove asert and add dbg logging as on other DCNs.
>
> CC: Saaem Rizvi <SyedSaaem.Rizvi@amd.com>
> Signed-off-by: Roman Li <roman.li@amd.com>
> ---
> .../drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
> b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
> index ef0795b14a1f..2db595672a46 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
> @@ -123,9 +123,10 @@ static int
> dcn314_smu_send_msg_with_param(struct clk_mgr_internal *clk_mgr,
> uint32_t result;
>
> result = dcn314_smu_wait_for_response(clk_mgr, 10, 200000);
> - ASSERT(result == VBIOSSMC_Result_OK);
Does this flow actually happen still? I thought the assertion should have gone
away as a result of 83293f7f3d15fc56e86bd5067a2c88b6b233ac3a.
Maybe we want to also undo the REG_WRITE() call there if pulling this in.
>
> - smu_print("SMU response after wait: %d\n", result);
> + if (result != VBIOSSMC_Result_OK)
> + smu_print("SMU Response was not OK. SMU response after
> wait received is: %d\n",
> + result);
>
> if (result == VBIOSSMC_Status_BUSY)
> return -1;
I think what is missing to clean up recent asserts is actually a little bit further
in the code than this. It should be part of the error flow introduced by
03ad3093c7c069d6ab4403730009ebafeea9ee37
> @@ -216,6 +217,12 @@ int dcn314_smu_set_hard_min_dcfclk(struct
> clk_mgr_internal *clk_mgr, int request
> VBIOSSMC_MSG_SetHardMinDcfclkByFreq,
> khz_to_mhz_ceil(requested_dcfclk_khz));
>
> +#ifdef DBG
> + smu_print("actual_dcfclk_set_mhz %d is set to : %d\n",
> + actual_dcfclk_set_mhz,
> + actual_dcfclk_set_mhz * 1000);
> +#endif
> +
> return actual_dcfclk_set_mhz * 1000;
> }
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] drm/amd/display: Align dcn314_smu logging with other DCNs
2022-11-14 21:15 ` Limonciello, Mario
@ 2022-11-15 17:51 ` Li, Roman
2022-11-15 18:02 ` Limonciello, Mario
0 siblings, 1 reply; 5+ messages in thread
From: Li, Roman @ 2022-11-15 17:51 UTC (permalink / raw)
To: Limonciello, Mario, amd-gfx, Deucher, Alexander, Wentland, Harry,
Rizvi, Saaem
Hi Mario,
Thanks for your comments.
I replied inline.
> -----Original Message-----
> From: Limonciello, Mario <Mario.Limonciello@amd.com>
> Sent: Monday, November 14, 2022 4:16 PM
> To: Li, Roman <Roman.Li@amd.com>; amd-gfx@lists.freedesktop.org;
> Deucher, Alexander <Alexander.Deucher@amd.com>; Wentland, Harry
> <Harry.Wentland@amd.com>; Rizvi, Saaem <SyedSaaem.Rizvi@amd.com>
> Cc: Li, Roman <Roman.Li@amd.com>
> Subject: RE: [PATCH] drm/amd/display: Align dcn314_smu logging with other
> DCNs
>
> [Public]
>
> Conceptually makes sense to me, but please see below comments:
>
> > -----Original Message-----
> > From: Roman.Li@amd.com <Roman.Li@amd.com>
> > Sent: Monday, November 14, 2022 15:07
> > To: amd-gfx@lists.freedesktop.org; Deucher, Alexander
> > <Alexander.Deucher@amd.com>; Wentland, Harry
> <Harry.Wentland@amd.com>;
> > Limonciello, Mario <Mario.Limonciello@amd.com>; Rizvi, Saaem
> > <SyedSaaem.Rizvi@amd.com>
> > Cc: Li, Roman <Roman.Li@amd.com>
> > Subject: [PATCH] drm/amd/display: Align dcn314_smu logging with other
> > DCNs
> >
> > From: Roman Li <roman.li@amd.com>
> >
> > [Why]
> > Assert on non-OK response from SMU is unnecessary.
> > It was replaced with respective log message on other asics in the past
> > with commit:
> > "drm/amd/display: Removing assert statements for Linux"
> >
> > [How]
> > Remove asert and add dbg logging as on other DCNs.
I will fix "assert" spelling before merging.
> >
> > CC: Saaem Rizvi <SyedSaaem.Rizvi@amd.com>
> > Signed-off-by: Roman Li <roman.li@amd.com>
> > ---
> > .../drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c | 11 +++++++++-
> -
> > 1 file changed, 9 insertions(+), 2 deletions(-)
> >
> > diff --git
> > a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
> > b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
> > index ef0795b14a1f..2db595672a46 100644
> > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
> > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
> > @@ -123,9 +123,10 @@ static int
> > dcn314_smu_send_msg_with_param(struct clk_mgr_internal *clk_mgr,
> > uint32_t result;
> >
> > result = dcn314_smu_wait_for_response(clk_mgr, 10, 200000);
> > - ASSERT(result == VBIOSSMC_Result_OK);
>
> Does this flow actually happen still? I thought the assertion should have
> gone away as a result of 83293f7f3d15fc56e86bd5067a2c88b6b233ac3a.
>
Happens or not, we don't assert here on other asics.
I don't try to fix any bugs with this patch, just align the dcn314 logging/bug reporting with other asics.
> Maybe we want to also undo the REG_WRITE() call there if pulling this in.
>
> >
> > - smu_print("SMU response after wait: %d\n", result);
> > + if (result != VBIOSSMC_Result_OK)
> > + smu_print("SMU Response was not OK. SMU response after
> > wait received is: %d\n",
> > + result);
> >
> > if (result == VBIOSSMC_Status_BUSY)
> > return -1;
>
> I think what is missing to clean up recent asserts is actually a little bit further
> in the code than this. It should be part of the error flow introduced by
> 03ad3093c7c069d6ab4403730009ebafeea9ee37
03ad3093c7c069d6a is for dcn3.1 initially.
If there's an issue with it (which I didn't experience) it should be addressed on all dcn3x, that reuse it, in a separate patch.
>
> > @@ -216,6 +217,12 @@ int dcn314_smu_set_hard_min_dcfclk(struct
> > clk_mgr_internal *clk_mgr, int request
> > VBIOSSMC_MSG_SetHardMinDcfclkByFreq,
> > khz_to_mhz_ceil(requested_dcfclk_khz));
> >
> > +#ifdef DBG
> > + smu_print("actual_dcfclk_set_mhz %d is set to : %d\n",
> > + actual_dcfclk_set_mhz,
> > + actual_dcfclk_set_mhz * 1000);
> > +#endif
> > +
> > return actual_dcfclk_set_mhz * 1000; }
> >
> > --
> > 2.17.1
Thanks,
Roman
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] drm/amd/display: Align dcn314_smu logging with other DCNs
2022-11-15 17:51 ` Li, Roman
@ 2022-11-15 18:02 ` Limonciello, Mario
2022-11-15 19:21 ` Rizvi, Saaem
0 siblings, 1 reply; 5+ messages in thread
From: Limonciello, Mario @ 2022-11-15 18:02 UTC (permalink / raw)
To: Li, Roman, amd-gfx, Deucher, Alexander, Wentland, Harry, Rizvi, Saaem
[Public]
> -----Original Message-----
> From: Li, Roman <Roman.Li@amd.com>
> Sent: Tuesday, November 15, 2022 11:52
> To: Limonciello, Mario <Mario.Limonciello@amd.com>; amd-
> gfx@lists.freedesktop.org; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Wentland, Harry
> <Harry.Wentland@amd.com>; Rizvi, Saaem <SyedSaaem.Rizvi@amd.com>
> Subject: RE: [PATCH] drm/amd/display: Align dcn314_smu logging with other
> DCNs
>
> Hi Mario,
>
> Thanks for your comments.
> I replied inline.
>
> > -----Original Message-----
> > From: Limonciello, Mario <Mario.Limonciello@amd.com>
> > Sent: Monday, November 14, 2022 4:16 PM
> > To: Li, Roman <Roman.Li@amd.com>; amd-gfx@lists.freedesktop.org;
> > Deucher, Alexander <Alexander.Deucher@amd.com>; Wentland, Harry
> > <Harry.Wentland@amd.com>; Rizvi, Saaem <SyedSaaem.Rizvi@amd.com>
> > Cc: Li, Roman <Roman.Li@amd.com>
> > Subject: RE: [PATCH] drm/amd/display: Align dcn314_smu logging with
> other
> > DCNs
> >
> > [Public]
> >
> > Conceptually makes sense to me, but please see below comments:
> >
> > > -----Original Message-----
> > > From: Roman.Li@amd.com <Roman.Li@amd.com>
> > > Sent: Monday, November 14, 2022 15:07
> > > To: amd-gfx@lists.freedesktop.org; Deucher, Alexander
> > > <Alexander.Deucher@amd.com>; Wentland, Harry
> > <Harry.Wentland@amd.com>;
> > > Limonciello, Mario <Mario.Limonciello@amd.com>; Rizvi, Saaem
> > > <SyedSaaem.Rizvi@amd.com>
> > > Cc: Li, Roman <Roman.Li@amd.com>
> > > Subject: [PATCH] drm/amd/display: Align dcn314_smu logging with other
> > > DCNs
> > >
> > > From: Roman Li <roman.li@amd.com>
> > >
> > > [Why]
> > > Assert on non-OK response from SMU is unnecessary.
> > > It was replaced with respective log message on other asics in the past
> > > with commit:
> > > "drm/amd/display: Removing assert statements for Linux"
> > >
> > > [How]
> > > Remove asert and add dbg logging as on other DCNs.
>
> I will fix "assert" spelling before merging.
>
> > >
> > > CC: Saaem Rizvi <SyedSaaem.Rizvi@amd.com>
> > > Signed-off-by: Roman Li <roman.li@amd.com>
> > > ---
> > > .../drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c | 11
> +++++++++-
> > -
> > > 1 file changed, 9 insertions(+), 2 deletions(-)
> > >
> > > diff --git
> > > a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
> > > b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
> > > index ef0795b14a1f..2db595672a46 100644
> > > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
> > > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
> > > @@ -123,9 +123,10 @@ static int
> > > dcn314_smu_send_msg_with_param(struct clk_mgr_internal *clk_mgr,
> > > uint32_t result;
> > >
> > > result = dcn314_smu_wait_for_response(clk_mgr, 10, 200000);
> > > - ASSERT(result == VBIOSSMC_Result_OK);
> >
> > Does this flow actually happen still? I thought the assertion should have
> > gone away as a result of 83293f7f3d15fc56e86bd5067a2c88b6b233ac3a.
> >
> Happens or not, we don't assert here on other asics.
> I don't try to fix any bugs with this patch, just align the dcn314 logging/bug
> reporting with other asics.
Got it thanks.
>
> > Maybe we want to also undo the REG_WRITE() call there if pulling this in.
> >
> > >
> > > - smu_print("SMU response after wait: %d\n", result);
> > > + if (result != VBIOSSMC_Result_OK)
> > > + smu_print("SMU Response was not OK. SMU response after
> > > wait received is: %d\n",
> > > + result);
> > >
> > > if (result == VBIOSSMC_Status_BUSY)
> > > return -1;
> >
> > I think what is missing to clean up recent asserts is actually a little bit further
> > in the code than this. It should be part of the error flow introduced by
> > 03ad3093c7c069d6ab4403730009ebafeea9ee37
>
> 03ad3093c7c069d6a is for dcn3.1 initially.
> If there's an issue with it (which I didn't experience) it should be addressed
> on all dcn3x, that reuse it, in a separate patch.
OK.
>
>
> >
> > > @@ -216,6 +217,12 @@ int dcn314_smu_set_hard_min_dcfclk(struct
> > > clk_mgr_internal *clk_mgr, int request
> > > VBIOSSMC_MSG_SetHardMinDcfclkByFreq,
> > > khz_to_mhz_ceil(requested_dcfclk_khz));
> > >
> > > +#ifdef DBG
> > > + smu_print("actual_dcfclk_set_mhz %d is set to : %d\n",
> > > + actual_dcfclk_set_mhz,
> > > + actual_dcfclk_set_mhz * 1000);
> > > +#endif
> > > +
> > > return actual_dcfclk_set_mhz * 1000; }
> > >
> > > --
> > > 2.17.1
>
> Thanks,
> Roman
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] drm/amd/display: Align dcn314_smu logging with other DCNs
2022-11-15 18:02 ` Limonciello, Mario
@ 2022-11-15 19:21 ` Rizvi, Saaem
0 siblings, 0 replies; 5+ messages in thread
From: Rizvi, Saaem @ 2022-11-15 19:21 UTC (permalink / raw)
To: Limonciello, Mario, Li, Roman, amd-gfx, Deucher, Alexander,
Wentland, Harry
[-- Attachment #1: Type: text/plain, Size: 5154 bytes --]
[Public]
Reviewed-by: Saaem Rizvi <SyedSaaem.Rizvi@amd.com>
From: Limonciello, Mario<mailto:Mario.Limonciello@amd.com>
Sent: Tuesday, November 15, 2022 1:02 PM
To: Li, Roman<mailto:Roman.Li@amd.com>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>; Deucher, Alexander<mailto:Alexander.Deucher@amd.com>; Wentland, Harry<mailto:Harry.Wentland@amd.com>; Rizvi, Saaem<mailto:SyedSaaem.Rizvi@amd.com>
Subject: RE: [PATCH] drm/amd/display: Align dcn314_smu logging with other DCNs
[Public]
> -----Original Message-----
> From: Li, Roman <Roman.Li@amd.com>
> Sent: Tuesday, November 15, 2022 11:52
> To: Limonciello, Mario <Mario.Limonciello@amd.com>; amd-
> gfx@lists.freedesktop.org; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Wentland, Harry
> <Harry.Wentland@amd.com>; Rizvi, Saaem <SyedSaaem.Rizvi@amd.com>
> Subject: RE: [PATCH] drm/amd/display: Align dcn314_smu logging with other
> DCNs
>
> Hi Mario,
>
> Thanks for your comments.
> I replied inline.
>
> > -----Original Message-----
> > From: Limonciello, Mario <Mario.Limonciello@amd.com>
> > Sent: Monday, November 14, 2022 4:16 PM
> > To: Li, Roman <Roman.Li@amd.com>; amd-gfx@lists.freedesktop.org;
> > Deucher, Alexander <Alexander.Deucher@amd.com>; Wentland, Harry
> > <Harry.Wentland@amd.com>; Rizvi, Saaem <SyedSaaem.Rizvi@amd.com>
> > Cc: Li, Roman <Roman.Li@amd.com>
> > Subject: RE: [PATCH] drm/amd/display: Align dcn314_smu logging with
> other
> > DCNs
> >
> > [Public]
> >
> > Conceptually makes sense to me, but please see below comments:
> >
> > > -----Original Message-----
> > > From: Roman.Li@amd.com <Roman.Li@amd.com>
> > > Sent: Monday, November 14, 2022 15:07
> > > To: amd-gfx@lists.freedesktop.org; Deucher, Alexander
> > > <Alexander.Deucher@amd.com>; Wentland, Harry
> > <Harry.Wentland@amd.com>;
> > > Limonciello, Mario <Mario.Limonciello@amd.com>; Rizvi, Saaem
> > > <SyedSaaem.Rizvi@amd.com>
> > > Cc: Li, Roman <Roman.Li@amd.com>
> > > Subject: [PATCH] drm/amd/display: Align dcn314_smu logging with other
> > > DCNs
> > >
> > > From: Roman Li <roman.li@amd.com>
> > >
> > > [Why]
> > > Assert on non-OK response from SMU is unnecessary.
> > > It was replaced with respective log message on other asics in the past
> > > with commit:
> > > "drm/amd/display: Removing assert statements for Linux"
> > >
> > > [How]
> > > Remove asert and add dbg logging as on other DCNs.
>
> I will fix "assert" spelling before merging.
>
> > >
> > > CC: Saaem Rizvi <SyedSaaem.Rizvi@amd.com>
> > > Signed-off-by: Roman Li <roman.li@amd.com>
> > > ---
> > > .../drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c | 11
> +++++++++-
> > -
> > > 1 file changed, 9 insertions(+), 2 deletions(-)
> > >
> > > diff --git
> > > a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
> > > b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
> > > index ef0795b14a1f..2db595672a46 100644
> > > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
> > > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn314/dcn314_smu.c
> > > @@ -123,9 +123,10 @@ static int
> > > dcn314_smu_send_msg_with_param(struct clk_mgr_internal *clk_mgr,
> > > uint32_t result;
> > >
> > > result = dcn314_smu_wait_for_response(clk_mgr, 10, 200000);
> > > - ASSERT(result == VBIOSSMC_Result_OK);
> >
> > Does this flow actually happen still? I thought the assertion should have
> > gone away as a result of 83293f7f3d15fc56e86bd5067a2c88b6b233ac3a.
> >
> Happens or not, we don't assert here on other asics.
> I don't try to fix any bugs with this patch, just align the dcn314 logging/bug
> reporting with other asics.
Got it thanks.
>
> > Maybe we want to also undo the REG_WRITE() call there if pulling this in.
> >
> > >
> > > - smu_print("SMU response after wait: %d\n", result);
> > > + if (result != VBIOSSMC_Result_OK)
> > > + smu_print("SMU Response was not OK. SMU response after
> > > wait received is: %d\n",
> > > + result);
> > >
> > > if (result == VBIOSSMC_Status_BUSY)
> > > return -1;
> >
> > I think what is missing to clean up recent asserts is actually a little bit further
> > in the code than this. It should be part of the error flow introduced by
> > 03ad3093c7c069d6ab4403730009ebafeea9ee37
>
> 03ad3093c7c069d6a is for dcn3.1 initially.
> If there's an issue with it (which I didn't experience) it should be addressed
> on all dcn3x, that reuse it, in a separate patch.
OK.
>
>
> >
> > > @@ -216,6 +217,12 @@ int dcn314_smu_set_hard_min_dcfclk(struct
> > > clk_mgr_internal *clk_mgr, int request
> > > VBIOSSMC_MSG_SetHardMinDcfclkByFreq,
> > > khz_to_mhz_ceil(requested_dcfclk_khz));
> > >
> > > +#ifdef DBG
> > > + smu_print("actual_dcfclk_set_mhz %d is set to : %d\n",
> > > + actual_dcfclk_set_mhz,
> > > + actual_dcfclk_set_mhz * 1000);
> > > +#endif
> > > +
> > > return actual_dcfclk_set_mhz * 1000; }
> > >
> > > --
> > > 2.17.1
>
> Thanks,
> Roman
[-- Attachment #2: Type: text/html, Size: 9054 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-11-15 19:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-14 21:07 [PATCH] drm/amd/display: Align dcn314_smu logging with other DCNs Roman.Li
2022-11-14 21:15 ` Limonciello, Mario
2022-11-15 17:51 ` Li, Roman
2022-11-15 18:02 ` Limonciello, Mario
2022-11-15 19:21 ` Rizvi, Saaem
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.