From: Naga Sureshkumar Relli <nagasure@xilinx.com> To: "Tudor.Ambarus@microchip.com" <Tudor.Ambarus@microchip.com>, "boris.brezillon@collabora.com" <boris.brezillon@collabora.com>, "marek.vasut@gmail.com" <marek.vasut@gmail.com>, "vigneshr@ti.com" <vigneshr@ti.com> Cc: "richard@nod.at" <richard@nod.at>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>, "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>, "computersforpeace@gmail.com" <computersforpeace@gmail.com>, "dwmw2@infradead.org" <dwmw2@infradead.org> Subject: RE: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups() Date: Thu, 1 Aug 2019 04:47:48 +0000 [thread overview] Message-ID: <MN2PR02MB5727B99A02E915AEFE89D318AFDE0@MN2PR02MB5727.namprd02.prod.outlook.com> (raw) In-Reply-To: <cfe63aee-2c48-c321-53b7-3997c97dc215@microchip.com> Hi Tudor, > -----Original Message----- > From: Tudor.Ambarus@microchip.com <Tudor.Ambarus@microchip.com> > Sent: Wednesday, July 31, 2019 6:37 PM > To: Naga Sureshkumar Relli <nagasure@xilinx.com>; boris.brezillon@collabora.com; > marek.vasut@gmail.com; vigneshr@ti.com > Cc: richard@nod.at; linux-kernel@vger.kernel.org; linux-mtd@lists.infradead.org; > miquel.raynal@bootlin.com; computersforpeace@gmail.com; dwmw2@infradead.org > Subject: Re: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups() > > Hi, Naga, > > On 07/31/2019 03:31 PM, Naga Sureshkumar Relli wrote: > >> + if (nor->info->flags & SPI_S3AN) > >> + s3an_post_sfdp_fixups(nor); > >> } > >> > > Instead of checking the flags, why can't we call directly the nor_fixups? > > like Boris implementation nor->info->fixups->post_sfdp() > > https://patchwork.ozlabs.org/patch/1009291/ > > This check will vanish and nor->info->fixups->post_sfdp() will be called directly once I'll > respin the manufacturer driver part. post_sfdp() will set just flash parameters. Check Boris' > patch at https://patchwork.ozlabs.org/patch/1009295/ > > I'll try to respin the rest of Boris' patches sometime at the beginning of the next week. Ok, Thanks. Regards, Naga Sureshkumar Relli > > Cheers, > ta
WARNING: multiple messages have this Message-ID (diff)
From: Naga Sureshkumar Relli <nagasure@xilinx.com> To: "Tudor.Ambarus@microchip.com" <Tudor.Ambarus@microchip.com>, "boris.brezillon@collabora.com" <boris.brezillon@collabora.com>, "marek.vasut@gmail.com" <marek.vasut@gmail.com>, "vigneshr@ti.com" <vigneshr@ti.com> Cc: "richard@nod.at" <richard@nod.at>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>, "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>, "computersforpeace@gmail.com" <computersforpeace@gmail.com>, "dwmw2@infradead.org" <dwmw2@infradead.org> Subject: RE: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups() Date: Thu, 1 Aug 2019 04:47:48 +0000 [thread overview] Message-ID: <MN2PR02MB5727B99A02E915AEFE89D318AFDE0@MN2PR02MB5727.namprd02.prod.outlook.com> (raw) In-Reply-To: <cfe63aee-2c48-c321-53b7-3997c97dc215@microchip.com> Hi Tudor, > -----Original Message----- > From: Tudor.Ambarus@microchip.com <Tudor.Ambarus@microchip.com> > Sent: Wednesday, July 31, 2019 6:37 PM > To: Naga Sureshkumar Relli <nagasure@xilinx.com>; boris.brezillon@collabora.com; > marek.vasut@gmail.com; vigneshr@ti.com > Cc: richard@nod.at; linux-kernel@vger.kernel.org; linux-mtd@lists.infradead.org; > miquel.raynal@bootlin.com; computersforpeace@gmail.com; dwmw2@infradead.org > Subject: Re: [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups() > > Hi, Naga, > > On 07/31/2019 03:31 PM, Naga Sureshkumar Relli wrote: > >> + if (nor->info->flags & SPI_S3AN) > >> + s3an_post_sfdp_fixups(nor); > >> } > >> > > Instead of checking the flags, why can't we call directly the nor_fixups? > > like Boris implementation nor->info->fixups->post_sfdp() > > https://patchwork.ozlabs.org/patch/1009291/ > > This check will vanish and nor->info->fixups->post_sfdp() will be called directly once I'll > respin the manufacturer driver part. post_sfdp() will set just flash parameters. Check Boris' > patch at https://patchwork.ozlabs.org/patch/1009295/ > > I'll try to respin the rest of Boris' patches sometime at the beginning of the next week. Ok, Thanks. Regards, Naga Sureshkumar Relli > > Cheers, > ta ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-08-01 4:48 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-31 9:12 [PATCH 0/6] mtd: spi-nor: move manuf out of the core - batch 2 Tudor.Ambarus 2019-07-31 9:12 ` Tudor.Ambarus 2019-07-31 9:12 ` [PATCH 1/6] mtd: spi-nor: Add post_sfdp() hook to tweak flash config Tudor.Ambarus 2019-07-31 9:12 ` Tudor.Ambarus 2019-07-31 9:12 ` [PATCH 2/6] mtd: spi-nor: Add spansion_post_sfdp_fixups() Tudor.Ambarus 2019-07-31 9:12 ` Tudor.Ambarus 2019-07-31 9:12 ` [PATCH 3/6] mtd: spi-nor: Add a ->convert_addr() method Tudor.Ambarus 2019-07-31 9:12 ` Tudor.Ambarus 2019-07-31 9:12 ` [PATCH 4/6] mtd: spi_nor: Add nor->setup() method Tudor.Ambarus 2019-07-31 9:12 ` Tudor.Ambarus 2019-08-01 6:36 ` Boris Brezillon 2019-08-01 6:36 ` Boris Brezillon 2019-08-05 6:37 ` Tudor.Ambarus 2019-08-05 6:37 ` Tudor.Ambarus 2019-07-31 9:12 ` [PATCH 5/6] mtd: spi-nor: Add s3an_post_sfdp_fixups() Tudor.Ambarus 2019-07-31 9:12 ` Tudor.Ambarus 2019-07-31 12:31 ` Naga Sureshkumar Relli 2019-07-31 12:31 ` Naga Sureshkumar Relli 2019-07-31 12:38 ` Boris Brezillon 2019-07-31 12:38 ` Boris Brezillon 2019-08-01 4:47 ` Naga Sureshkumar Relli 2019-08-01 4:47 ` Naga Sureshkumar Relli 2019-07-31 13:06 ` Tudor.Ambarus 2019-07-31 13:06 ` Tudor.Ambarus 2019-08-01 4:47 ` Naga Sureshkumar Relli [this message] 2019-08-01 4:47 ` Naga Sureshkumar Relli 2019-08-01 6:42 ` Boris Brezillon 2019-08-01 6:42 ` Boris Brezillon 2019-08-05 6:40 ` Tudor.Ambarus 2019-08-05 6:40 ` Tudor.Ambarus 2019-07-31 9:12 ` [PATCH 6/6] mtd: spi-nor: Add the SPI_NOR_XSR_RDY flag Tudor.Ambarus 2019-07-31 9:12 ` Tudor.Ambarus 2019-08-05 5:14 ` Vignesh Raghavendra 2019-08-05 5:14 ` Vignesh Raghavendra 2019-08-05 7:32 ` Tudor.Ambarus 2019-08-05 7:32 ` Tudor.Ambarus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=MN2PR02MB5727B99A02E915AEFE89D318AFDE0@MN2PR02MB5727.namprd02.prod.outlook.com \ --to=nagasure@xilinx.com \ --cc=Tudor.Ambarus@microchip.com \ --cc=boris.brezillon@collabora.com \ --cc=computersforpeace@gmail.com \ --cc=dwmw2@infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=marek.vasut@gmail.com \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.