All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-wired-lan] [PATCH] ice: rearm other interrupt cause register after enabling VFs
@ 2021-07-12 11:54 Paul Greenwalt
  2021-11-02 23:04 ` Brelinski, Tony
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Greenwalt @ 2021-07-12 11:54 UTC (permalink / raw)
  To: intel-wired-lan

The other interrupt cause register (OICR), global interrupt 0, is
disabled when enabling VFs to prevent handling VFLR. If the OICR is
not rearmed then the VF cannot communicate with the PF.

Rearm the OICR after enabling VFs.

Signed-off-by: Paul Greenwalt <paul.greenwalt@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
index 501331b6f70b..0a2e0b2c9227 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
@@ -1952,6 +1952,10 @@ static int ice_ena_vfs(struct ice_pf *pf, u16 num_vfs)
 	if (ice_eswitch_configure(pf))
 		goto err_unroll_sriov;
 
+	/* rearm global interrupts */
+	if (test_and_clear_bit(ICE_OICR_INTR_DIS, pf->state))
+		ice_irq_dynamic_ena(hw, NULL, NULL);
+
 	return 0;
 
 err_unroll_sriov:
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Intel-wired-lan] [PATCH] ice: rearm other interrupt cause register after enabling VFs
  2021-07-12 11:54 [Intel-wired-lan] [PATCH] ice: rearm other interrupt cause register after enabling VFs Paul Greenwalt
@ 2021-11-02 23:04 ` Brelinski, Tony
  0 siblings, 0 replies; 2+ messages in thread
From: Brelinski, Tony @ 2021-11-02 23:04 UTC (permalink / raw)
  To: intel-wired-lan

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Greenwalt, Paul
> Sent: Monday, July 12, 2021 4:54 AM
> To: intel-wired-lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [PATCH] ice: rearm other interrupt cause register
> after enabling VFs
> 
> The other interrupt cause register (OICR), global interrupt 0, is disabled when
> enabling VFs to prevent handling VFLR. If the OICR is not rearmed then the
> VF cannot communicate with the PF.
> 
> Rearm the OICR after enabling VFs.
> 
> Signed-off-by: Paul Greenwalt <paul.greenwalt@intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 4 ++++
>  1 file changed, 4 insertions(+)

Tested-by: Tony Brelinski <tony.brelinski@intel.com>



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-02 23:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-12 11:54 [Intel-wired-lan] [PATCH] ice: rearm other interrupt cause register after enabling VFs Paul Greenwalt
2021-11-02 23:04 ` Brelinski, Tony

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.