All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chen, Mike Ximing" <mike.ximing.chen@intel.com>
To: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Carrillo, Erik G" <erik.g.carrillo@intel.com>,
	"Eads, Gage" <gage.eads@intel.com>,
	"Van Haaren,  Harry" <harry.van.haaren@intel.com>,
	"jerinj@marvell.com" <jerinj@marvell.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] event/dlb: do not free memzone if port create	succeeds
Date: Wed, 11 Nov 2020 21:04:55 +0000	[thread overview]
Message-ID: <MN2PR11MB44315C3FD838629CAA7C305BD9E80@MN2PR11MB4431.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1605126422-522-3-git-send-email-timothy.mcdaniel@intel.com>



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Timothy McDaniel
> Sent: Wednesday, November 11, 2020 3:27 PM
> Cc: dev@dpdk.org; Carrillo, Erik G <erik.g.carrillo@intel.com>; Eads, Gage
> <gage.eads@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>;
> jerinj@marvell.com; thomas@monjalon.net; david.marchand@redhat.com
> Subject: [dpdk-dev] [PATCH] event/dlb: do not free memzone if port create
> succeeds
> 
> Add missing returns so that the memzone free is not called if port create is
> successful.
> 
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
> ---
>  drivers/event/dlb/pf/dlb_pf.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/event/dlb/pf/dlb_pf.c b/drivers/event/dlb/pf/dlb_pf.c index
> cf88c49..3aeef6f 100644
> --- a/drivers/event/dlb/pf/dlb_pf.c
> +++ b/drivers/event/dlb/pf/dlb_pf.c
> @@ -342,6 +342,7 @@ dlb_pf_ldb_port_create(struct dlb_hw_dev *handle,
>  	*(struct dlb_cmd_response *)cfg->response = response;
> 
>  	DLB_INFO(dev->dlb_device, "Exiting %s() with ret=%d\n", __func__, ret);
> +	return 0;
> 
>  create_port_err:
> 
> @@ -419,6 +420,7 @@ dlb_pf_dir_port_create(struct dlb_hw_dev *handle,
>  	*(struct dlb_cmd_response *)cfg->response = response;
> 
>  	DLB_INFO(dev->dlb_device, "Exiting %s() with ret=%d\n", __func__, ret);
> +	return 0;
> 
>  create_port_err:
> 
> --
> 2.6.4

Reviewed-by: Mike Ximing Chen <mike.ximing.chen@intel.com>


  reply	other threads:[~2020-11-11 21:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11 20:26 [dpdk-dev] [PATCH] event/dlb2: add missing delayed token pop logic Timothy McDaniel
2020-11-11 20:27 ` [dpdk-dev] [PATCH] event/dlb2: remove duplicate/unused PCI code and constants Timothy McDaniel
2020-11-11 20:27 ` [dpdk-dev] [PATCH] event/dlb: do not free memzone if port create succeeds Timothy McDaniel
2020-11-11 21:04   ` Chen, Mike Ximing [this message]
2020-11-11 20:27 ` [dpdk-dev] [PATCH] event/dlb: remove duplicate/unused PCI code and constants Timothy McDaniel
2020-11-11 21:12 ` [dpdk-dev] [PATCH] event/dlb2: add missing delayed token pop logic Chen, Mike Ximing
2020-11-13  9:53   ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB44315C3FD838629CAA7C305BD9E80@MN2PR11MB4431.namprd11.prod.outlook.com \
    --to=mike.ximing.chen@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=erik.g.carrillo@intel.com \
    --cc=gage.eads@intel.com \
    --cc=harry.van.haaren@intel.com \
    --cc=jerinj@marvell.com \
    --cc=thomas@monjalon.net \
    --cc=timothy.mcdaniel@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.