* [PATCH v2] drm/amdgpu: Need to free discovery memory
@ 2019-11-04 3:03 ` Emily Deng
0 siblings, 0 replies; 8+ messages in thread
From: Emily Deng @ 2019-11-04 3:03 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Emily Deng
When unloading driver, need to free discovery memory.
Signed-off-by: Emily Deng <Emily.Deng@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index 28b09f6..7cbe6d9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -2106,9 +2106,6 @@ void amdgpu_ttm_late_init(struct amdgpu_device *adev)
void *stolen_vga_buf;
/* return the VGA stolen memory (if any) back to VRAM */
amdgpu_bo_free_kernel(&adev->stolen_vga_memory, NULL, &stolen_vga_buf);
-
- /* return the IP Discovery TMR memory back to VRAM */
- amdgpu_bo_free_kernel(&adev->discovery_memory, NULL, NULL);
}
/**
@@ -2121,7 +2118,10 @@ void amdgpu_ttm_fini(struct amdgpu_device *adev)
amdgpu_ttm_debugfs_fini(adev);
amdgpu_ttm_training_reserve_vram_fini(adev);
+ /* return the IP Discovery TMR memory back to VRAM */
+ amdgpu_bo_free_kernel(&adev->discovery_memory, NULL, NULL);
amdgpu_ttm_fw_reserve_vram_fini(adev);
+
if (adev->mman.aper_base_kaddr)
iounmap(adev->mman.aper_base_kaddr);
adev->mman.aper_base_kaddr = NULL;
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2] drm/amdgpu: Need to free discovery memory
@ 2019-11-04 3:03 ` Emily Deng
0 siblings, 0 replies; 8+ messages in thread
From: Emily Deng @ 2019-11-04 3:03 UTC (permalink / raw)
To: amd-gfx; +Cc: Emily Deng
When unloading driver, need to free discovery memory.
Signed-off-by: Emily Deng <Emily.Deng@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index 28b09f6..7cbe6d9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -2106,9 +2106,6 @@ void amdgpu_ttm_late_init(struct amdgpu_device *adev)
void *stolen_vga_buf;
/* return the VGA stolen memory (if any) back to VRAM */
amdgpu_bo_free_kernel(&adev->stolen_vga_memory, NULL, &stolen_vga_buf);
-
- /* return the IP Discovery TMR memory back to VRAM */
- amdgpu_bo_free_kernel(&adev->discovery_memory, NULL, NULL);
}
/**
@@ -2121,7 +2118,10 @@ void amdgpu_ttm_fini(struct amdgpu_device *adev)
amdgpu_ttm_debugfs_fini(adev);
amdgpu_ttm_training_reserve_vram_fini(adev);
+ /* return the IP Discovery TMR memory back to VRAM */
+ amdgpu_bo_free_kernel(&adev->discovery_memory, NULL, NULL);
amdgpu_ttm_fw_reserve_vram_fini(adev);
+
if (adev->mman.aper_base_kaddr)
iounmap(adev->mman.aper_base_kaddr);
adev->mman.aper_base_kaddr = NULL;
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drm/amdgpu: Need to free discovery memory
@ 2019-11-04 3:41 ` Yuan, Xiaojie
0 siblings, 0 replies; 8+ messages in thread
From: Yuan, Xiaojie @ 2019-11-04 3:41 UTC (permalink / raw)
To: Deng, Emily, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Please use 'drm/amdgpu/discovery: ' prefix in commit message to let us easily track all discovery-releated changes.
Other than this, patch is Reviewed-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
BR,
Xiaojie
________________________________________
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Emily Deng <Emily.Deng@amd.com>
Sent: Monday, November 4, 2019 11:03 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deng, Emily
Subject: [PATCH v2] drm/amdgpu: Need to free discovery memory
When unloading driver, need to free discovery memory.
Signed-off-by: Emily Deng <Emily.Deng@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index 28b09f6..7cbe6d9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -2106,9 +2106,6 @@ void amdgpu_ttm_late_init(struct amdgpu_device *adev)
void *stolen_vga_buf;
/* return the VGA stolen memory (if any) back to VRAM */
amdgpu_bo_free_kernel(&adev->stolen_vga_memory, NULL, &stolen_vga_buf);
-
- /* return the IP Discovery TMR memory back to VRAM */
- amdgpu_bo_free_kernel(&adev->discovery_memory, NULL, NULL);
}
/**
@@ -2121,7 +2118,10 @@ void amdgpu_ttm_fini(struct amdgpu_device *adev)
amdgpu_ttm_debugfs_fini(adev);
amdgpu_ttm_training_reserve_vram_fini(adev);
+ /* return the IP Discovery TMR memory back to VRAM */
+ amdgpu_bo_free_kernel(&adev->discovery_memory, NULL, NULL);
amdgpu_ttm_fw_reserve_vram_fini(adev);
+
if (adev->mman.aper_base_kaddr)
iounmap(adev->mman.aper_base_kaddr);
adev->mman.aper_base_kaddr = NULL;
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drm/amdgpu: Need to free discovery memory
@ 2019-11-04 3:41 ` Yuan, Xiaojie
0 siblings, 0 replies; 8+ messages in thread
From: Yuan, Xiaojie @ 2019-11-04 3:41 UTC (permalink / raw)
To: Deng, Emily, amd-gfx
Please use 'drm/amdgpu/discovery: ' prefix in commit message to let us easily track all discovery-releated changes.
Other than this, patch is Reviewed-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
BR,
Xiaojie
________________________________________
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Emily Deng <Emily.Deng@amd.com>
Sent: Monday, November 4, 2019 11:03 AM
To: amd-gfx@lists.freedesktop.org
Cc: Deng, Emily
Subject: [PATCH v2] drm/amdgpu: Need to free discovery memory
When unloading driver, need to free discovery memory.
Signed-off-by: Emily Deng <Emily.Deng@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index 28b09f6..7cbe6d9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -2106,9 +2106,6 @@ void amdgpu_ttm_late_init(struct amdgpu_device *adev)
void *stolen_vga_buf;
/* return the VGA stolen memory (if any) back to VRAM */
amdgpu_bo_free_kernel(&adev->stolen_vga_memory, NULL, &stolen_vga_buf);
-
- /* return the IP Discovery TMR memory back to VRAM */
- amdgpu_bo_free_kernel(&adev->discovery_memory, NULL, NULL);
}
/**
@@ -2121,7 +2118,10 @@ void amdgpu_ttm_fini(struct amdgpu_device *adev)
amdgpu_ttm_debugfs_fini(adev);
amdgpu_ttm_training_reserve_vram_fini(adev);
+ /* return the IP Discovery TMR memory back to VRAM */
+ amdgpu_bo_free_kernel(&adev->discovery_memory, NULL, NULL);
amdgpu_ttm_fw_reserve_vram_fini(adev);
+
if (adev->mman.aper_base_kaddr)
iounmap(adev->mman.aper_base_kaddr);
adev->mman.aper_base_kaddr = NULL;
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [PATCH v2] drm/amdgpu: Need to free discovery memory
@ 2019-11-04 4:45 ` Deng, Emily
0 siblings, 0 replies; 8+ messages in thread
From: Deng, Emily @ 2019-11-04 4:45 UTC (permalink / raw)
To: Yuan, Xiaojie, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Thanks, done.
Best wishes
Emily Deng
>-----Original Message-----
>From: Yuan, Xiaojie <Xiaojie.Yuan@amd.com>
>Sent: Monday, November 4, 2019 11:41 AM
>To: Deng, Emily <Emily.Deng@amd.com>; amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH v2] drm/amdgpu: Need to free discovery memory
>
>Please use 'drm/amdgpu/discovery: ' prefix in commit message to let us easily
>track all discovery-releated changes.
>Other than this, patch is Reviewed-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
>
>BR,
>Xiaojie
>
>________________________________________
>From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Emily
>Deng <Emily.Deng@amd.com>
>Sent: Monday, November 4, 2019 11:03 AM
>To: amd-gfx@lists.freedesktop.org
>Cc: Deng, Emily
>Subject: [PATCH v2] drm/amdgpu: Need to free discovery memory
>
>When unloading driver, need to free discovery memory.
>
>Signed-off-by: Emily Deng <Emily.Deng@amd.com>
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>index 28b09f6..7cbe6d9 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>@@ -2106,9 +2106,6 @@ void amdgpu_ttm_late_init(struct amdgpu_device
>*adev)
> void *stolen_vga_buf;
> /* return the VGA stolen memory (if any) back to VRAM */
> amdgpu_bo_free_kernel(&adev->stolen_vga_memory, NULL,
>&stolen_vga_buf);
>-
>- /* return the IP Discovery TMR memory back to VRAM */
>- amdgpu_bo_free_kernel(&adev->discovery_memory, NULL, NULL);
> }
>
> /**
>@@ -2121,7 +2118,10 @@ void amdgpu_ttm_fini(struct amdgpu_device
>*adev)
>
> amdgpu_ttm_debugfs_fini(adev);
> amdgpu_ttm_training_reserve_vram_fini(adev);
>+ /* return the IP Discovery TMR memory back to VRAM */
>+ amdgpu_bo_free_kernel(&adev->discovery_memory, NULL, NULL);
> amdgpu_ttm_fw_reserve_vram_fini(adev);
>+
> if (adev->mman.aper_base_kaddr)
> iounmap(adev->mman.aper_base_kaddr);
> adev->mman.aper_base_kaddr = NULL;
>--
>2.7.4
>
>_______________________________________________
>amd-gfx mailing list
>amd-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2] drm/amdgpu: Need to free discovery memory
@ 2019-11-04 4:45 ` Deng, Emily
0 siblings, 0 replies; 8+ messages in thread
From: Deng, Emily @ 2019-11-04 4:45 UTC (permalink / raw)
To: Yuan, Xiaojie, amd-gfx
Thanks, done.
Best wishes
Emily Deng
>-----Original Message-----
>From: Yuan, Xiaojie <Xiaojie.Yuan@amd.com>
>Sent: Monday, November 4, 2019 11:41 AM
>To: Deng, Emily <Emily.Deng@amd.com>; amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH v2] drm/amdgpu: Need to free discovery memory
>
>Please use 'drm/amdgpu/discovery: ' prefix in commit message to let us easily
>track all discovery-releated changes.
>Other than this, patch is Reviewed-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
>
>BR,
>Xiaojie
>
>________________________________________
>From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Emily
>Deng <Emily.Deng@amd.com>
>Sent: Monday, November 4, 2019 11:03 AM
>To: amd-gfx@lists.freedesktop.org
>Cc: Deng, Emily
>Subject: [PATCH v2] drm/amdgpu: Need to free discovery memory
>
>When unloading driver, need to free discovery memory.
>
>Signed-off-by: Emily Deng <Emily.Deng@amd.com>
>---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>index 28b09f6..7cbe6d9 100644
>--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>@@ -2106,9 +2106,6 @@ void amdgpu_ttm_late_init(struct amdgpu_device
>*adev)
> void *stolen_vga_buf;
> /* return the VGA stolen memory (if any) back to VRAM */
> amdgpu_bo_free_kernel(&adev->stolen_vga_memory, NULL,
>&stolen_vga_buf);
>-
>- /* return the IP Discovery TMR memory back to VRAM */
>- amdgpu_bo_free_kernel(&adev->discovery_memory, NULL, NULL);
> }
>
> /**
>@@ -2121,7 +2118,10 @@ void amdgpu_ttm_fini(struct amdgpu_device
>*adev)
>
> amdgpu_ttm_debugfs_fini(adev);
> amdgpu_ttm_training_reserve_vram_fini(adev);
>+ /* return the IP Discovery TMR memory back to VRAM */
>+ amdgpu_bo_free_kernel(&adev->discovery_memory, NULL, NULL);
> amdgpu_ttm_fw_reserve_vram_fini(adev);
>+
> if (adev->mman.aper_base_kaddr)
> iounmap(adev->mman.aper_base_kaddr);
> adev->mman.aper_base_kaddr = NULL;
>--
>2.7.4
>
>_______________________________________________
>amd-gfx mailing list
>amd-gfx@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drm/amdgpu: Need to free discovery memory
@ 2019-11-04 11:50 ` Christian König
0 siblings, 0 replies; 8+ messages in thread
From: Christian König @ 2019-11-04 11:50 UTC (permalink / raw)
To: Deng, Emily, Yuan, Xiaojie, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
> Please use 'drm/amdgpu/discovery: ' prefix in commit message to let us easily
> track all discovery-releated changes.
Actually please don't. The prefix is to denote which driver/code base is
changed.
IP discovery is just a feature and not limited to a certain code base
inside the driver.
Mentioning "discovery memory" in the commit message should be fine already.
Regards,
Christian.
Am 04.11.19 um 05:45 schrieb Deng, Emily:
> Thanks, done.
>
> Best wishes
> Emily Deng
>
>
>
>> -----Original Message-----
>> From: Yuan, Xiaojie <Xiaojie.Yuan@amd.com>
>> Sent: Monday, November 4, 2019 11:41 AM
>> To: Deng, Emily <Emily.Deng@amd.com>; amd-gfx@lists.freedesktop.org
>> Subject: Re: [PATCH v2] drm/amdgpu: Need to free discovery memory
>>
>> Please use 'drm/amdgpu/discovery: ' prefix in commit message to let us easily
>> track all discovery-releated changes.
>> Other than this, patch is Reviewed-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
>>
>> BR,
>> Xiaojie
>>
>> ________________________________________
>> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Emily
>> Deng <Emily.Deng@amd.com>
>> Sent: Monday, November 4, 2019 11:03 AM
>> To: amd-gfx@lists.freedesktop.org
>> Cc: Deng, Emily
>> Subject: [PATCH v2] drm/amdgpu: Need to free discovery memory
>>
>> When unloading driver, need to free discovery memory.
>>
>> Signed-off-by: Emily Deng <Emily.Deng@amd.com>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>> index 28b09f6..7cbe6d9 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>> @@ -2106,9 +2106,6 @@ void amdgpu_ttm_late_init(struct amdgpu_device
>> *adev)
>> void *stolen_vga_buf;
>> /* return the VGA stolen memory (if any) back to VRAM */
>> amdgpu_bo_free_kernel(&adev->stolen_vga_memory, NULL,
>> &stolen_vga_buf);
>> -
>> - /* return the IP Discovery TMR memory back to VRAM */
>> - amdgpu_bo_free_kernel(&adev->discovery_memory, NULL, NULL);
>> }
>>
>> /**
>> @@ -2121,7 +2118,10 @@ void amdgpu_ttm_fini(struct amdgpu_device
>> *adev)
>>
>> amdgpu_ttm_debugfs_fini(adev);
>> amdgpu_ttm_training_reserve_vram_fini(adev);
>> + /* return the IP Discovery TMR memory back to VRAM */
>> + amdgpu_bo_free_kernel(&adev->discovery_memory, NULL, NULL);
>> amdgpu_ttm_fw_reserve_vram_fini(adev);
>> +
>> if (adev->mman.aper_base_kaddr)
>> iounmap(adev->mman.aper_base_kaddr);
>> adev->mman.aper_base_kaddr = NULL;
>> --
>> 2.7.4
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drm/amdgpu: Need to free discovery memory
@ 2019-11-04 11:50 ` Christian König
0 siblings, 0 replies; 8+ messages in thread
From: Christian König @ 2019-11-04 11:50 UTC (permalink / raw)
To: Deng, Emily, Yuan, Xiaojie, amd-gfx
> Please use 'drm/amdgpu/discovery: ' prefix in commit message to let us easily
> track all discovery-releated changes.
Actually please don't. The prefix is to denote which driver/code base is
changed.
IP discovery is just a feature and not limited to a certain code base
inside the driver.
Mentioning "discovery memory" in the commit message should be fine already.
Regards,
Christian.
Am 04.11.19 um 05:45 schrieb Deng, Emily:
> Thanks, done.
>
> Best wishes
> Emily Deng
>
>
>
>> -----Original Message-----
>> From: Yuan, Xiaojie <Xiaojie.Yuan@amd.com>
>> Sent: Monday, November 4, 2019 11:41 AM
>> To: Deng, Emily <Emily.Deng@amd.com>; amd-gfx@lists.freedesktop.org
>> Subject: Re: [PATCH v2] drm/amdgpu: Need to free discovery memory
>>
>> Please use 'drm/amdgpu/discovery: ' prefix in commit message to let us easily
>> track all discovery-releated changes.
>> Other than this, patch is Reviewed-by: Xiaojie Yuan <xiaojie.yuan@amd.com>
>>
>> BR,
>> Xiaojie
>>
>> ________________________________________
>> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Emily
>> Deng <Emily.Deng@amd.com>
>> Sent: Monday, November 4, 2019 11:03 AM
>> To: amd-gfx@lists.freedesktop.org
>> Cc: Deng, Emily
>> Subject: [PATCH v2] drm/amdgpu: Need to free discovery memory
>>
>> When unloading driver, need to free discovery memory.
>>
>> Signed-off-by: Emily Deng <Emily.Deng@amd.com>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>> index 28b09f6..7cbe6d9 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
>> @@ -2106,9 +2106,6 @@ void amdgpu_ttm_late_init(struct amdgpu_device
>> *adev)
>> void *stolen_vga_buf;
>> /* return the VGA stolen memory (if any) back to VRAM */
>> amdgpu_bo_free_kernel(&adev->stolen_vga_memory, NULL,
>> &stolen_vga_buf);
>> -
>> - /* return the IP Discovery TMR memory back to VRAM */
>> - amdgpu_bo_free_kernel(&adev->discovery_memory, NULL, NULL);
>> }
>>
>> /**
>> @@ -2121,7 +2118,10 @@ void amdgpu_ttm_fini(struct amdgpu_device
>> *adev)
>>
>> amdgpu_ttm_debugfs_fini(adev);
>> amdgpu_ttm_training_reserve_vram_fini(adev);
>> + /* return the IP Discovery TMR memory back to VRAM */
>> + amdgpu_bo_free_kernel(&adev->discovery_memory, NULL, NULL);
>> amdgpu_ttm_fw_reserve_vram_fini(adev);
>> +
>> if (adev->mman.aper_base_kaddr)
>> iounmap(adev->mman.aper_base_kaddr);
>> adev->mman.aper_base_kaddr = NULL;
>> --
>> 2.7.4
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-11-04 11:50 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-04 3:03 [PATCH v2] drm/amdgpu: Need to free discovery memory Emily Deng
2019-11-04 3:03 ` Emily Deng
[not found] ` <1572836597-31265-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org>
2019-11-04 3:41 ` Yuan, Xiaojie
2019-11-04 3:41 ` Yuan, Xiaojie
[not found] ` <MN2PR12MB3087E540D23C1A98B8269239897F0-rweVpJHSKTpSqPH+ASrJYAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-11-04 4:45 ` Deng, Emily
2019-11-04 4:45 ` Deng, Emily
[not found] ` <MN2PR12MB29751F7D33E9D6398FEF7D508F7F0-rweVpJHSKToFlvJWC7EAqwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-11-04 11:50 ` Christian König
2019-11-04 11:50 ` Christian König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.