[PATCH 2/2] drm/amdgpu: Set proper function to set xgmi pstate

[PATCH 2/2] drm/amdgpu: Set proper function to set xgmi pstate

[Liu, Shaoyun]

Driver need to call SMU to set xgmi pstate

Change-Id: Iad7fd0e3b3155e45be8fe9119686c5bafa3c176c
Signed-off-by: shaoyunl <shaoyun.liu@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
index 3368347..a48c84c 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
@@ -24,6 +24,7 @@
 #include <linux/list.h>
 #include "amdgpu.h"
 #include "amdgpu_xgmi.h"
+#include "amdgpu_smu.h"
 
 
 static DEFINE_MUTEX(xgmi_mutex);
@@ -216,7 +217,17 @@ int amdgpu_xgmi_set_pstate(struct amdgpu_device *adev, int pstate)
 
 	if (hive->pstate == pstate)
 		return 0;
-	/* Todo : sent the message to SMU for pstate change */
+
+	dev_dbg(adev->dev, "Set xgmi pstate %d.\n", pstate);
+
+	if (is_support_sw_smu(adev))
+		ret = smu_set_xgmi_pstate(&adev->smu, pstate);
+	if (ret)
+		dev_err(adev->dev,
+			"XGMI: Set pstate failure on device %llx, hive %llx, ret %d",
+			adev->gmc.xgmi.node_id,
+			adev->gmc.xgmi.hive_id, ret);
+
 	return ret;
 }
 
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 2/2] drm/amdgpu: Set proper function to set xgmi pstate

[Liu, Shaoyun]

ping

On 2019-04-05 12:01 p.m., Liu, Shaoyun wrote:
> Driver need to call SMU to set xgmi pstate
>
> Change-Id: Iad7fd0e3b3155e45be8fe9119686c5bafa3c176c
> Signed-off-by: shaoyunl <shaoyun.liu@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 13 ++++++++++++-
>   1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> index 3368347..a48c84c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> @@ -24,6 +24,7 @@
>   #include <linux/list.h>
>   #include "amdgpu.h"
>   #include "amdgpu_xgmi.h"
> +#include "amdgpu_smu.h"
>   
>   
>   static DEFINE_MUTEX(xgmi_mutex);
> @@ -216,7 +217,17 @@ int amdgpu_xgmi_set_pstate(struct amdgpu_device *adev, int pstate)
>   
>   	if (hive->pstate == pstate)
>   		return 0;
> -	/* Todo : sent the message to SMU for pstate change */
> +
> +	dev_dbg(adev->dev, "Set xgmi pstate %d.\n", pstate);
> +
> +	if (is_support_sw_smu(adev))
> +		ret = smu_set_xgmi_pstate(&adev->smu, pstate);
> +	if (ret)
> +		dev_err(adev->dev,
> +			"XGMI: Set pstate failure on device %llx, hive %llx, ret %d",
> +			adev->gmc.xgmi.node_id,
> +			adev->gmc.xgmi.hive_id, ret);
> +
>   	return ret;
>   }
>   
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH 2/2] drm/amdgpu: Set proper function to set xgmi pstate

[Quan, Evan]

'pstate' here (int) is with different data type from the 1st patch of this series(uint32_t there).
Please check whether that can cause any potential issues.
With that confirmed, the patch is reviewed-by: Evan Quan <evan.quan@amd.com>

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Liu,
> Shaoyun
> Sent: Saturday, April 06, 2019 12:02 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Shaoyun <Shaoyun.Liu@amd.com>
> Subject: [PATCH 2/2] drm/amdgpu: Set proper function to set xgmi pstate
> 
> Driver need to call SMU to set xgmi pstate
> 
> Change-Id: Iad7fd0e3b3155e45be8fe9119686c5bafa3c176c
> Signed-off-by: shaoyunl <shaoyun.liu@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> index 3368347..a48c84c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c
> @@ -24,6 +24,7 @@
>  #include <linux/list.h>
>  #include "amdgpu.h"
>  #include "amdgpu_xgmi.h"
> +#include "amdgpu_smu.h"
> 
> 
>  static DEFINE_MUTEX(xgmi_mutex);
> @@ -216,7 +217,17 @@ int amdgpu_xgmi_set_pstate(struct amdgpu_device
> *adev, int pstate)
> 
>  	if (hive->pstate == pstate)
>  		return 0;
> -	/* Todo : sent the message to SMU for pstate change */
> +
> +	dev_dbg(adev->dev, "Set xgmi pstate %d.\n", pstate);
> +
> +	if (is_support_sw_smu(adev))
> +		ret = smu_set_xgmi_pstate(&adev->smu, pstate);
> +	if (ret)
> +		dev_err(adev->dev,
> +			"XGMI: Set pstate failure on device %llx, hive %llx,
> ret %d",
> +			adev->gmc.xgmi.node_id,
> +			adev->gmc.xgmi.hive_id, ret);
> +
>  	return ret;
>  }
> 
> --
> 2.7.4
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx