All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/powerplay: modify the parameters of SMU_MSG_PowerUpVcn to 0
@ 2019-10-24  8:59 ` chen gong
  0 siblings, 0 replies; 6+ messages in thread
From: chen gong @ 2019-10-24  8:59 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: chen gong

The parameters what SMU_MSG_PowerUpVcn need is 0, not 1

Signed-off-by: chen gong <curry.gong@amd.com>
---
 drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
index 45c5f54..4a97519 100644
--- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
+++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
@@ -282,7 +282,7 @@ static int renoir_dpm_set_uvd_enable(struct smu_context *smu, bool enable)
 	if (enable) {
 		/* vcn dpm on is a prerequisite for vcn power gate messages */
 		if (smu_feature_is_enabled(smu, SMU_FEATURE_VCN_PG_BIT)) {
-			ret = smu_send_smc_msg_with_param(smu, SMU_MSG_PowerUpVcn, 1);
+			ret = smu_send_smc_msg_with_param(smu, SMU_MSG_PowerUpVcn, 0);
 			if (ret)
 				return ret;
 		}
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] drm/amd/powerplay: modify the parameters of SMU_MSG_PowerUpVcn to 0
@ 2019-10-24  8:59 ` chen gong
  0 siblings, 0 replies; 6+ messages in thread
From: chen gong @ 2019-10-24  8:59 UTC (permalink / raw)
  To: amd-gfx; +Cc: chen gong

The parameters what SMU_MSG_PowerUpVcn need is 0, not 1

Signed-off-by: chen gong <curry.gong@amd.com>
---
 drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
index 45c5f54..4a97519 100644
--- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
+++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
@@ -282,7 +282,7 @@ static int renoir_dpm_set_uvd_enable(struct smu_context *smu, bool enable)
 	if (enable) {
 		/* vcn dpm on is a prerequisite for vcn power gate messages */
 		if (smu_feature_is_enabled(smu, SMU_FEATURE_VCN_PG_BIT)) {
-			ret = smu_send_smc_msg_with_param(smu, SMU_MSG_PowerUpVcn, 1);
+			ret = smu_send_smc_msg_with_param(smu, SMU_MSG_PowerUpVcn, 0);
 			if (ret)
 				return ret;
 		}
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* RE: [PATCH] drm/amd/powerplay: modify the parameters of SMU_MSG_PowerUpVcn to 0
@ 2019-10-24  9:13     ` Liu, Aaron
  0 siblings, 0 replies; 6+ messages in thread
From: Liu, Aaron @ 2019-10-24  9:13 UTC (permalink / raw)
  To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Gong, Curry

Reviewed-by: Aaron Liu <aaron.liu@amd.com>

BR,
Aaron Liu

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of chen
> gong
> Sent: Thursday, October 24, 2019 4:59 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Gong, Curry <Curry.Gong@amd.com>
> Subject: [PATCH] drm/amd/powerplay: modify the parameters of
> SMU_MSG_PowerUpVcn to 0
> 
> The parameters what SMU_MSG_PowerUpVcn need is 0, not 1
> 
> Signed-off-by: chen gong <curry.gong@amd.com>
> ---
>  drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> index 45c5f54..4a97519 100644
> --- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> @@ -282,7 +282,7 @@ static int renoir_dpm_set_uvd_enable(struct
> smu_context *smu, bool enable)
>  	if (enable) {
>  		/* vcn dpm on is a prerequisite for vcn power gate messages
> */
>  		if (smu_feature_is_enabled(smu,
> SMU_FEATURE_VCN_PG_BIT)) {
> -			ret = smu_send_smc_msg_with_param(smu,
> SMU_MSG_PowerUpVcn, 1);
> +			ret = smu_send_smc_msg_with_param(smu,
> SMU_MSG_PowerUpVcn, 0);
>  			if (ret)
>  				return ret;
>  		}
> --
> 2.7.4
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [PATCH] drm/amd/powerplay: modify the parameters of SMU_MSG_PowerUpVcn to 0
@ 2019-10-24  9:13     ` Liu, Aaron
  0 siblings, 0 replies; 6+ messages in thread
From: Liu, Aaron @ 2019-10-24  9:13 UTC (permalink / raw)
  To: Gong, Curry, amd-gfx; +Cc: Gong, Curry

Reviewed-by: Aaron Liu <aaron.liu@amd.com>

BR,
Aaron Liu

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of chen
> gong
> Sent: Thursday, October 24, 2019 4:59 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Gong, Curry <Curry.Gong@amd.com>
> Subject: [PATCH] drm/amd/powerplay: modify the parameters of
> SMU_MSG_PowerUpVcn to 0
> 
> The parameters what SMU_MSG_PowerUpVcn need is 0, not 1
> 
> Signed-off-by: chen gong <curry.gong@amd.com>
> ---
>  drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> index 45c5f54..4a97519 100644
> --- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> @@ -282,7 +282,7 @@ static int renoir_dpm_set_uvd_enable(struct
> smu_context *smu, bool enable)
>  	if (enable) {
>  		/* vcn dpm on is a prerequisite for vcn power gate messages
> */
>  		if (smu_feature_is_enabled(smu,
> SMU_FEATURE_VCN_PG_BIT)) {
> -			ret = smu_send_smc_msg_with_param(smu,
> SMU_MSG_PowerUpVcn, 1);
> +			ret = smu_send_smc_msg_with_param(smu,
> SMU_MSG_PowerUpVcn, 0);
>  			if (ret)
>  				return ret;
>  		}
> --
> 2.7.4
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [PATCH] drm/amd/powerplay: modify the parameters of SMU_MSG_PowerUpVcn to 0
@ 2019-10-25  0:29         ` Quan, Evan
  0 siblings, 0 replies; 6+ messages in thread
From: Quan, Evan @ 2019-10-25  0:29 UTC (permalink / raw)
  To: Liu, Aaron, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Gong, Curry

Acked-by: Evan Quan <evan.quan@amd.com>

-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Liu, Aaron
Sent: Thursday, October 24, 2019 5:13 PM
To: Gong, Curry <Curry.Gong@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Gong, Curry <Curry.Gong@amd.com>
Subject: RE: [PATCH] drm/amd/powerplay: modify the parameters of SMU_MSG_PowerUpVcn to 0

Reviewed-by: Aaron Liu <aaron.liu@amd.com>

BR,
Aaron Liu

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of 
> chen gong
> Sent: Thursday, October 24, 2019 4:59 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Gong, Curry <Curry.Gong@amd.com>
> Subject: [PATCH] drm/amd/powerplay: modify the parameters of 
> SMU_MSG_PowerUpVcn to 0
> 
> The parameters what SMU_MSG_PowerUpVcn need is 0, not 1
> 
> Signed-off-by: chen gong <curry.gong@amd.com>
> ---
>  drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> index 45c5f54..4a97519 100644
> --- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> @@ -282,7 +282,7 @@ static int renoir_dpm_set_uvd_enable(struct 
> smu_context *smu, bool enable)
>  	if (enable) {
>  		/* vcn dpm on is a prerequisite for vcn power gate messages */
>  		if (smu_feature_is_enabled(smu,
> SMU_FEATURE_VCN_PG_BIT)) {
> -			ret = smu_send_smc_msg_with_param(smu,
> SMU_MSG_PowerUpVcn, 1);
> +			ret = smu_send_smc_msg_with_param(smu,
> SMU_MSG_PowerUpVcn, 0);
>  			if (ret)
>  				return ret;
>  		}
> --
> 2.7.4
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [PATCH] drm/amd/powerplay: modify the parameters of SMU_MSG_PowerUpVcn to 0
@ 2019-10-25  0:29         ` Quan, Evan
  0 siblings, 0 replies; 6+ messages in thread
From: Quan, Evan @ 2019-10-25  0:29 UTC (permalink / raw)
  To: Liu, Aaron, Gong, Curry, amd-gfx; +Cc: Gong, Curry

Acked-by: Evan Quan <evan.quan@amd.com>

-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Liu, Aaron
Sent: Thursday, October 24, 2019 5:13 PM
To: Gong, Curry <Curry.Gong@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Gong, Curry <Curry.Gong@amd.com>
Subject: RE: [PATCH] drm/amd/powerplay: modify the parameters of SMU_MSG_PowerUpVcn to 0

Reviewed-by: Aaron Liu <aaron.liu@amd.com>

BR,
Aaron Liu

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of 
> chen gong
> Sent: Thursday, October 24, 2019 4:59 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Gong, Curry <Curry.Gong@amd.com>
> Subject: [PATCH] drm/amd/powerplay: modify the parameters of 
> SMU_MSG_PowerUpVcn to 0
> 
> The parameters what SMU_MSG_PowerUpVcn need is 0, not 1
> 
> Signed-off-by: chen gong <curry.gong@amd.com>
> ---
>  drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> index 45c5f54..4a97519 100644
> --- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c
> @@ -282,7 +282,7 @@ static int renoir_dpm_set_uvd_enable(struct 
> smu_context *smu, bool enable)
>  	if (enable) {
>  		/* vcn dpm on is a prerequisite for vcn power gate messages */
>  		if (smu_feature_is_enabled(smu,
> SMU_FEATURE_VCN_PG_BIT)) {
> -			ret = smu_send_smc_msg_with_param(smu,
> SMU_MSG_PowerUpVcn, 1);
> +			ret = smu_send_smc_msg_with_param(smu,
> SMU_MSG_PowerUpVcn, 0);
>  			if (ret)
>  				return ret;
>  		}
> --
> 2.7.4
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-25  0:29 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-24  8:59 [PATCH] drm/amd/powerplay: modify the parameters of SMU_MSG_PowerUpVcn to 0 chen gong
2019-10-24  8:59 ` chen gong
     [not found] ` <1571907564-18087-1-git-send-email-curry.gong-5C7GfCeVMHo@public.gmane.org>
2019-10-24  9:13   ` Liu, Aaron
2019-10-24  9:13     ` Liu, Aaron
     [not found]     ` <MN2PR12MB3838E06D487F8BE6792A9569F06A0-rweVpJHSKTrcE+Ck/nypMAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-10-25  0:29       ` Quan, Evan
2019-10-25  0:29         ` Quan, Evan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.