* [PATCH 1/3] drm/amdgpu/powerplay/vega20: call PrepareMp1ForUnload in power_off_asic
@ 2019-07-23 17:00 Alex Deucher
[not found] ` <20190723170049.9143-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Alex Deucher @ 2019-07-23 17:00 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Alex Deucher
Needed to make sure the smu is idle when resetting. This fixes
sporatic failures with GPU reset.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
index f27c6fbb192e..e16d6654692f 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c
@@ -3764,6 +3764,11 @@ static int vega20_power_off_asic(struct pp_hwmgr *hwmgr)
);
data->water_marks_bitmap &= ~(WaterMarksLoaded);
+ PP_ASSERT_WITH_CODE((result = smum_send_msg_to_smc(hwmgr,
+ PPSMC_MSG_PrepareMp1ForUnload)) == 0,
+ "[PrepareMp1ForUnload] Failed!",
+ return result);
+
return result;
}
--
2.20.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/3] drm/amdgpu/powerplay/vega10: call PrepareMp1ForUnload in power_off_asic
[not found] ` <20190723170049.9143-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
@ 2019-07-23 17:00 ` Alex Deucher
2019-07-23 17:00 ` [PATCH 3/3] drm/amdgpu/powerplay/vega12: " Alex Deucher
1 sibling, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2019-07-23 17:00 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Alex Deucher
Needed to make sure the smu is idle when resetting. This may fix
sporatic failures with GPU reset.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
index 1d9bb29adaef..a6066d92de78 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
@@ -4740,6 +4740,11 @@ static int vega10_power_off_asic(struct pp_hwmgr *hwmgr)
);
data->water_marks_bitmap &= ~(WaterMarksLoaded);
+ PP_ASSERT_WITH_CODE((result = smum_send_msg_to_smc(hwmgr,
+ PPSMC_MSG_PrepareMp1ForUnload)) == 0,
+ "[PrepareMp1ForUnload] Failed!",
+ return result);
+
return result;
}
--
2.20.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/3] drm/amdgpu/powerplay/vega12: call PrepareMp1ForUnload in power_off_asic
[not found] ` <20190723170049.9143-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2019-07-23 17:00 ` [PATCH 2/3] drm/amdgpu/powerplay/vega10: " Alex Deucher
@ 2019-07-23 17:00 ` Alex Deucher
[not found] ` <20190723170049.9143-3-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
1 sibling, 1 reply; 5+ messages in thread
From: Alex Deucher @ 2019-07-23 17:00 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Alex Deucher
Needed to make sure the smu is idle when resetting. This may fix
sporatic failures with GPU reset.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
index efb6d3762feb..3d3504411b63 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
@@ -2468,6 +2468,11 @@ static int vega12_power_off_asic(struct pp_hwmgr *hwmgr)
);
data->water_marks_bitmap &= ~(WaterMarksLoaded);
+ PP_ASSERT_WITH_CODE((result = smum_send_msg_to_smc(hwmgr,
+ PPSMC_MSG_PrepareMp1ForUnload)) == 0,
+ "[PrepareMp1ForUnload] Failed!",
+ return result);
+
return result;
}
--
2.20.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 3/3] drm/amdgpu/powerplay/vega12: call PrepareMp1ForUnload in power_off_asic
[not found] ` <20190723170049.9143-3-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
@ 2019-07-23 20:00 ` Grodzovsky, Andrey
[not found] ` <bda866af-42f0-d40d-baf3-ffbfcb2867e2-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Grodzovsky, Andrey @ 2019-07-23 20:00 UTC (permalink / raw)
To: Alex Deucher, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Deucher, Alexander
Series is Acked-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Andrey
On 7/23/19 1:00 PM, Alex Deucher wrote:
> Needed to make sure the smu is idle when resetting. This may fix
> sporatic failures with GPU reset.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
> index efb6d3762feb..3d3504411b63 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
> @@ -2468,6 +2468,11 @@ static int vega12_power_off_asic(struct pp_hwmgr *hwmgr)
> );
> data->water_marks_bitmap &= ~(WaterMarksLoaded);
>
> + PP_ASSERT_WITH_CODE((result = smum_send_msg_to_smc(hwmgr,
> + PPSMC_MSG_PrepareMp1ForUnload)) == 0,
> + "[PrepareMp1ForUnload] Failed!",
> + return result);
> +
> return result;
> }
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 3/3] drm/amdgpu/powerplay/vega12: call PrepareMp1ForUnload in power_off_asic
[not found] ` <bda866af-42f0-d40d-baf3-ffbfcb2867e2-5C7GfCeVMHo@public.gmane.org>
@ 2019-07-24 1:31 ` Quan, Evan
0 siblings, 0 replies; 5+ messages in thread
From: Quan, Evan @ 2019-07-24 1:31 UTC (permalink / raw)
To: Grodzovsky, Andrey, Alex Deucher,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: Deucher, Alexander
No. Hold on. Let me discuss this internally.
Regards,
Evan
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Grodzovsky, Andrey
> Sent: Wednesday, July 24, 2019 4:01 AM
> To: Alex Deucher <alexdeucher@gmail.com>; amd-
> gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>
> Subject: Re: [PATCH 3/3] drm/amdgpu/powerplay/vega12: call
> PrepareMp1ForUnload in power_off_asic
>
> Series is Acked-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
>
> Andrey
>
> On 7/23/19 1:00 PM, Alex Deucher wrote:
> > Needed to make sure the smu is idle when resetting. This may fix
> > sporatic failures with GPU reset.
> >
> > Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> > ---
> > drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
> > b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
> > index efb6d3762feb..3d3504411b63 100644
> > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
> > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c
> > @@ -2468,6 +2468,11 @@ static int vega12_power_off_asic(struct
> pp_hwmgr *hwmgr)
> > );
> > data->water_marks_bitmap &= ~(WaterMarksLoaded);
> >
> > + PP_ASSERT_WITH_CODE((result = smum_send_msg_to_smc(hwmgr,
> > + PPSMC_MSG_PrepareMp1ForUnload)) == 0,
> > + "[PrepareMp1ForUnload] Failed!",
> > + return result);
> > +
> > return result;
> > }
> >
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-24 1:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-23 17:00 [PATCH 1/3] drm/amdgpu/powerplay/vega20: call PrepareMp1ForUnload in power_off_asic Alex Deucher
[not found] ` <20190723170049.9143-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2019-07-23 17:00 ` [PATCH 2/3] drm/amdgpu/powerplay/vega10: " Alex Deucher
2019-07-23 17:00 ` [PATCH 3/3] drm/amdgpu/powerplay/vega12: " Alex Deucher
[not found] ` <20190723170049.9143-3-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2019-07-23 20:00 ` Grodzovsky, Andrey
[not found] ` <bda866af-42f0-d40d-baf3-ffbfcb2867e2-5C7GfCeVMHo@public.gmane.org>
2019-07-24 1:31 ` Quan, Evan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.