All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] drm/amdkfd: Bump KFD API version
@ 2021-03-09 20:06 Felix Kuehling
  2021-03-09 20:12 ` Russell, Kent
  2021-03-09 20:17 ` Deucher, Alexander
  0 siblings, 2 replies; 4+ messages in thread
From: Felix Kuehling @ 2021-03-09 20:06 UTC (permalink / raw)
  To: amd-gfx; +Cc: sean.keely

Indicate the availability reliable SRAM EDC state in the new bit
in the device properties.

Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
---
 include/uapi/linux/kfd_ioctl.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/uapi/linux/kfd_ioctl.h b/include/uapi/linux/kfd_ioctl.h
index 18449f746097..bf5e7d7846dd 100644
--- a/include/uapi/linux/kfd_ioctl.h
+++ b/include/uapi/linux/kfd_ioctl.h
@@ -29,9 +29,10 @@
 /*
  * - 1.1 - initial version
  * - 1.3 - Add SMI events support
+ * - 1.4 - Indicate new SRAM EDC bit in device properties
  */
 #define KFD_IOCTL_MAJOR_VERSION 1
-#define KFD_IOCTL_MINOR_VERSION 3
+#define KFD_IOCTL_MINOR_VERSION 4
 
 struct kfd_ioctl_get_version_args {
 	__u32 major_version;	/* from KFD */
-- 
2.30.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* RE: [PATCH 1/1] drm/amdkfd: Bump KFD API version
  2021-03-09 20:06 [PATCH 1/1] drm/amdkfd: Bump KFD API version Felix Kuehling
@ 2021-03-09 20:12 ` Russell, Kent
  2021-03-09 20:17 ` Deucher, Alexander
  1 sibling, 0 replies; 4+ messages in thread
From: Russell, Kent @ 2021-03-09 20:12 UTC (permalink / raw)
  To: Kuehling, Felix, amd-gfx; +Cc: Keely, Sean

[AMD Public Use]

Reviewed-by: Kent Russell <kent.russell@amd.com>

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Felix Kuehling
> Sent: Tuesday, March 9, 2021 3:07 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Keely, Sean <Sean.Keely@amd.com>
> Subject: [PATCH 1/1] drm/amdkfd: Bump KFD API version
> 
> Indicate the availability reliable SRAM EDC state in the new bit
> in the device properties.
> 
> Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
>  include/uapi/linux/kfd_ioctl.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/kfd_ioctl.h b/include/uapi/linux/kfd_ioctl.h
> index 18449f746097..bf5e7d7846dd 100644
> --- a/include/uapi/linux/kfd_ioctl.h
> +++ b/include/uapi/linux/kfd_ioctl.h
> @@ -29,9 +29,10 @@
>  /*
>   * - 1.1 - initial version
>   * - 1.3 - Add SMI events support
> + * - 1.4 - Indicate new SRAM EDC bit in device properties
>   */
>  #define KFD_IOCTL_MAJOR_VERSION 1
> -#define KFD_IOCTL_MINOR_VERSION 3
> +#define KFD_IOCTL_MINOR_VERSION 4
> 
>  struct kfd_ioctl_get_version_args {
>  	__u32 major_version;	/* from KFD */
> --
> 2.30.0
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.or
> g%2Fmailman%2Flistinfo%2Famd-
> gfx&amp;data=04%7C01%7Ckent.russell%40amd.com%7C8bb8eefe2ce04a31f74a08d8e336f
> ada%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637509172574069509%7CUnk
> nown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXV
> CI6Mn0%3D%7C1000&amp;sdata=DmZmiISmcNY7rEvli49s5d6JFIvanYqCLFmeM1azFUk%3D
> &amp;reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] drm/amdkfd: Bump KFD API version
  2021-03-09 20:06 [PATCH 1/1] drm/amdkfd: Bump KFD API version Felix Kuehling
  2021-03-09 20:12 ` Russell, Kent
@ 2021-03-09 20:17 ` Deucher, Alexander
  2021-03-11 18:42   ` Felix Kuehling
  1 sibling, 1 reply; 4+ messages in thread
From: Deucher, Alexander @ 2021-03-09 20:17 UTC (permalink / raw)
  To: Kuehling, Felix, amd-gfx; +Cc: Keely, Sean


[-- Attachment #1.1: Type: text/plain, Size: 1870 bytes --]

[AMD Official Use Only - Internal Distribution Only]

If you have a link to the userspace patches that use this, it would be good to include in the patch description.

Alex

________________________________
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Felix Kuehling <Felix.Kuehling@amd.com>
Sent: Tuesday, March 9, 2021 3:06 PM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Keely, Sean <Sean.Keely@amd.com>
Subject: [PATCH 1/1] drm/amdkfd: Bump KFD API version

Indicate the availability reliable SRAM EDC state in the new bit
in the device properties.

Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
---
 include/uapi/linux/kfd_ioctl.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/uapi/linux/kfd_ioctl.h b/include/uapi/linux/kfd_ioctl.h
index 18449f746097..bf5e7d7846dd 100644
--- a/include/uapi/linux/kfd_ioctl.h
+++ b/include/uapi/linux/kfd_ioctl.h
@@ -29,9 +29,10 @@
 /*
  * - 1.1 - initial version
  * - 1.3 - Add SMI events support
+ * - 1.4 - Indicate new SRAM EDC bit in device properties
  */
 #define KFD_IOCTL_MAJOR_VERSION 1
-#define KFD_IOCTL_MINOR_VERSION 3
+#define KFD_IOCTL_MINOR_VERSION 4

 struct kfd_ioctl_get_version_args {
         __u32 major_version;    /* from KFD */
--
2.30.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=04%7C01%7Calexander.deucher%40amd.com%7C08c1668cc28a4b5400ec08d8e336f9e7%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637509172551256043%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=WGCf9mTBpRHKQmLrDIr25Ua78aDEhn0OVxhGBRSgwAk%3D&amp;reserved=0

[-- Attachment #1.2: Type: text/html, Size: 3763 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] drm/amdkfd: Bump KFD API version
  2021-03-09 20:17 ` Deucher, Alexander
@ 2021-03-11 18:42   ` Felix Kuehling
  0 siblings, 0 replies; 4+ messages in thread
From: Felix Kuehling @ 2021-03-11 18:42 UTC (permalink / raw)
  To: Deucher, Alexander, amd-gfx; +Cc: Keely, Sean

The Thunk change that uses the updated capability bit is available here: 
https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/commit/7cdd63475c36bb9f49bb960f90f9a8cdb7e80a21


ROCr will check the KFD API version in order to know whether the SRAM 
ECC capability reported by the Thunk is reliable.


Regards,
   Felix


On 2021-03-09 3:17 p.m., Deucher, Alexander wrote:
>
> [AMD Official Use Only - Internal Distribution Only]
>
>
> If you have a link to the userspace patches that use this, it would be 
> good to include in the patch description.
>
> Alex
>
> ------------------------------------------------------------------------
> *From:* amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of 
> Felix Kuehling <Felix.Kuehling@amd.com>
> *Sent:* Tuesday, March 9, 2021 3:06 PM
> *To:* amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
> *Cc:* Keely, Sean <Sean.Keely@amd.com>
> *Subject:* [PATCH 1/1] drm/amdkfd: Bump KFD API version
> Indicate the availability reliable SRAM EDC state in the new bit
> in the device properties.
>
> Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
>  include/uapi/linux/kfd_ioctl.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/kfd_ioctl.h 
> b/include/uapi/linux/kfd_ioctl.h
> index 18449f746097..bf5e7d7846dd 100644
> --- a/include/uapi/linux/kfd_ioctl.h
> +++ b/include/uapi/linux/kfd_ioctl.h
> @@ -29,9 +29,10 @@
>  /*
>   * - 1.1 - initial version
>   * - 1.3 - Add SMI events support
> + * - 1.4 - Indicate new SRAM EDC bit in device properties
>   */
>  #define KFD_IOCTL_MAJOR_VERSION 1
> -#define KFD_IOCTL_MINOR_VERSION 3
> +#define KFD_IOCTL_MINOR_VERSION 4
>
>  struct kfd_ioctl_get_version_args {
>          __u32 major_version;    /* from KFD */
> -- 
> 2.30.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-11 18:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-09 20:06 [PATCH 1/1] drm/amdkfd: Bump KFD API version Felix Kuehling
2021-03-09 20:12 ` Russell, Kent
2021-03-09 20:17 ` Deucher, Alexander
2021-03-11 18:42   ` Felix Kuehling

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.