[PATCH ] amd/powerplay: arcturus baco reset disable all features

[PATCH ] amd/powerplay: arcturus baco reset disable all features

[Clements, John]

[-- Attachment #1.1: Type: text/plain, Size: 295 bytes --]

[AMD Official Use Only - Internal Distribution Only]

Submitting patch for review to issue smu cmd disable all features upon baco entry sequence in arcturus.

This helps resolve issue with I2C controller not being disengaged properly on GPU reset affecting RAS eeprom stability on re-entry

[-- Attachment #1.2: Type: text/html, Size: 2094 bytes --]

[-- Attachment #2: 0001-amd-powerplay-arcturus-baco-reset-disable-all-featur.patch --]
[-- Type: application/octet-stream, Size: 1791 bytes --]

From de7725a86238132a4738dc157d0b9f922932ff14 Mon Sep 17 00:00:00 2001
From: John Clements <john.clements@amd.com>
Date: Wed, 18 Mar 2020 22:07:22 +0800
Subject: [PATCH ] amd/powerplay: arcturus baco reset disable all features

issue smu cmd to disable all features upon baco entry for arcturus
to mitigate potential dirty I2C controller on boot

Signed-off-by: John Clements <john.clements@amd.com>
Change-Id: Ic4813be6c5614243481d14d378f9cfc6da35a52b
---
 drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
index 0273c63baf8e..f6d4b0ef46ad 100644
--- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
@@ -1470,21 +1470,26 @@ static int smu_disable_dpm(struct smu_context *smu)
 	}
 
 	/*
-	 * For baco on Arcturus, this operation
-	 * (disable all smu feature) will be handled by SMU FW.
+	 * Disable all enabled SMU features.
+	 * This should be handled in SMU FW, as a backup
+	 * driver can issue call to SMU FW until sequence
+	 * in SMU FW is operational.
 	 */
-	if (adev->asic_type == CHIP_ARCTURUS) {
-		if (use_baco && (smu_version > 0x360e00))
-			return 0;
-	}
-
-	/* Disable all enabled SMU features */
 	ret = smu_system_features_control(smu, false);
 	if (ret) {
 		pr_err("Failed to disable smu features.\n");
 		return ret;
 	}
 
+	/*
+	 * Arcturus does not have BACO bit in disable feature mask.
+	 * Enablement of BACO bit on Arcturus should be skipped.
+	 */
+	if (adev->asic_type == CHIP_ARCTURUS) {
+		if (use_baco && (smu_version > 0x360e00))
+			return 0;
+	}
+
 	/* For baco, need to leave BACO feature enabled */
 	if (use_baco) {
 		/*
-- 
2.17.1


[-- Attachment #3: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH ] amd/powerplay: arcturus baco reset disable all features

[Deucher, Alexander]

[-- Attachment #1.1: Type: text/plain, Size: 745 bytes --]

[AMD Public Use]

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
________________________________
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Clements, John <John.Clements@amd.com>
Sent: Wednesday, March 18, 2020 10:11 AM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; Zhang, Hawking <Hawking.Zhang@amd.com>
Subject: [PATCH ] amd/powerplay: arcturus baco reset disable all features


[AMD Official Use Only - Internal Distribution Only]


Submitting patch for review to issue smu cmd disable all features upon baco entry sequence in arcturus.



This helps resolve issue with I2C controller not being disengaged properly on GPU reset affecting RAS eeprom stability on re-entry

[-- Attachment #1.2: Type: text/html, Size: 2302 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx