* keep-alive timeout zero value
@ 2020-08-17 16:19 Engel, Amit
2020-08-18 6:33 ` hch
0 siblings, 1 reply; 2+ messages in thread
From: Engel, Amit @ 2020-08-17 16:19 UTC (permalink / raw)
To: Sagi Grimberg, linux-nvme, hch; +Cc: Engel, Amit
Hi,
keep-alive timeout is allowed (by spec) to be set to 0h
In this case, the timer will be started ('nvmet_start_keep_alive_timer') where ctrl->kato = 0.
This will lead to an immediate timer expiration
We thought that in case of a zero keep alive timeout,
ctrl->kato should be set to a default NVMET_DISC_KATO value
(core.c , 'nvmet_alloc_ctrl')
this way we will avoid stating the timer with a zero timeout value
(This is correct for both NVME_NQN_DISC and NVME_NQN_NVME)
What are your thoughts?
Thanks
Amit Engel
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: keep-alive timeout zero value
2020-08-17 16:19 keep-alive timeout zero value Engel, Amit
@ 2020-08-18 6:33 ` hch
0 siblings, 0 replies; 2+ messages in thread
From: hch @ 2020-08-18 6:33 UTC (permalink / raw)
To: Engel, Amit; +Cc: Sagi Grimberg, linux-nvme, hch
On Mon, Aug 17, 2020 at 04:19:36PM +0000, Engel, Amit wrote:
> Hi,
>
> keep-alive timeout is allowed (by spec) to be set to 0h
> In this case, the timer will be started ('nvmet_start_keep_alive_timer') where ctrl->kato = 0.
> This will lead to an immediate timer expiration
>
> We thought that in case of a zero keep alive timeout,
> ctrl->kato should be set to a default NVMET_DISC_KATO value
> (core.c , 'nvmet_alloc_ctrl')
> this way we will avoid stating the timer with a zero timeout value
> (This is correct for both NVME_NQN_DISC and NVME_NQN_NVME)
>
> What are your thoughts?
Yes. Can you send a patch?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-18 6:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-17 16:19 keep-alive timeout zero value Engel, Amit
2020-08-18 6:33 ` hch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.