All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Kelley <mikelley@microsoft.com>
To: Boqun Feng <boqun.feng@gmail.com>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Cc: KY Srinivasan <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	Wei Liu <wei.liu@kernel.org>, Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"will@kernel.org" <will@kernel.org>,
	"ardb@kernel.org" <ardb@kernel.org>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"Mark.Rutland@arm.com" <Mark.Rutland@arm.com>,
	"maz@kernel.org" <maz@kernel.org>
Subject: RE: [PATCH v3 08/11] Input: hyperv-keyboard: Make ringbuffer at least take two pages
Date: Sat, 12 Sep 2020 19:37:23 +0000	[thread overview]
Message-ID: <MW2PR2101MB1052688710B98D8C31191A8DD7250@MW2PR2101MB1052.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20200910143455.109293-9-boqun.feng@gmail.com>

From: Boqun Feng <boqun.feng@gmail.com> Sent: Thursday, September 10, 2020 7:35 AM

> 
> When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at
> least 2 * PAGE_SIZE: one page for the header and at least one page of
> the data part (because of the alignment requirement for double mapping).
> 
> So make sure the ringbuffer sizes to be at least 2 * PAGE_SIZE when
> using vmbus_open() to establish the vmbus connection.
> 
> Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
> ---
>  drivers/input/serio/hyperv-keyboard.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Michael Kelley <mikelley@microsoft.com>

WARNING: multiple messages have this Message-ID (diff)
From: Michael Kelley <mikelley@microsoft.com>
To: Boqun Feng <boqun.feng@gmail.com>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Cc: "Mark.Rutland@arm.com" <Mark.Rutland@arm.com>,
	"maz@kernel.org" <maz@kernel.org>, Wei Liu <wei.liu@kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"will@kernel.org" <will@kernel.org>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Jiri Kosina <jikos@kernel.org>,
	"ardb@kernel.org" <ardb@kernel.org>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	Jakub Kicinski <kuba@kernel.org>,
	KY Srinivasan <kys@microsoft.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: RE: [PATCH v3 08/11] Input: hyperv-keyboard: Make ringbuffer at least take two pages
Date: Sat, 12 Sep 2020 19:37:23 +0000	[thread overview]
Message-ID: <MW2PR2101MB1052688710B98D8C31191A8DD7250@MW2PR2101MB1052.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20200910143455.109293-9-boqun.feng@gmail.com>

From: Boqun Feng <boqun.feng@gmail.com> Sent: Thursday, September 10, 2020 7:35 AM

> 
> When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at
> least 2 * PAGE_SIZE: one page for the header and at least one page of
> the data part (because of the alignment requirement for double mapping).
> 
> So make sure the ringbuffer sizes to be at least 2 * PAGE_SIZE when
> using vmbus_open() to establish the vmbus connection.
> 
> Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
> ---
>  drivers/input/serio/hyperv-keyboard.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Michael Kelley <mikelley@microsoft.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-09-12 19:37 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10 14:34 [PATCH v3 00/11] Hyper-V: Support PAGE_SIZE larger than 4K Boqun Feng
2020-09-10 14:34 ` Boqun Feng
2020-09-10 14:34 ` [PATCH v3 01/11] Drivers: hv: vmbus: Always use HV_HYP_PAGE_SIZE for gpadl Boqun Feng
2020-09-10 14:34   ` Boqun Feng
2020-09-12 19:23   ` Michael Kelley
2020-09-12 19:23     ` Michael Kelley
2020-09-10 14:34 ` [PATCH v3 02/11] Drivers: hv: vmbus: Move __vmbus_open() Boqun Feng
2020-09-10 14:34   ` Boqun Feng
2020-09-12 19:24   ` Michael Kelley
2020-09-12 19:24     ` Michael Kelley
2020-09-10 14:34 ` [PATCH v3 03/11] Drivers: hv: vmbus: Introduce types of GPADL Boqun Feng
2020-09-10 14:34   ` Boqun Feng
2020-09-12 19:29   ` Michael Kelley
2020-09-12 19:29     ` Michael Kelley
2020-09-10 14:34 ` [PATCH v3 04/11] Drivers: hv: Use HV_HYP_PAGE in hv_synic_enable_regs() Boqun Feng
2020-09-10 14:34   ` Boqun Feng
2020-09-12 19:30   ` Michael Kelley
2020-09-12 19:30     ` Michael Kelley
2020-09-10 14:34 ` [PATCH v3 05/11] Drivers: hv: vmbus: Move virt_to_hvpfn() to hyperv header Boqun Feng
2020-09-10 14:34   ` Boqun Feng
2020-09-12 19:32   ` Michael Kelley
2020-09-12 19:32     ` Michael Kelley
2020-09-10 14:34 ` [PATCH v3 06/11] hv: hyperv.h: Introduce some hvpfn helper functions Boqun Feng
2020-09-10 14:34   ` Boqun Feng
2020-09-12 19:33   ` Michael Kelley
2020-09-12 19:33     ` Michael Kelley
2020-09-10 14:34 ` [PATCH v3 07/11] hv_netvsc: Use HV_HYP_PAGE_SIZE for Hyper-V communication Boqun Feng
2020-09-10 14:34   ` Boqun Feng
2020-09-12 19:36   ` Michael Kelley
2020-09-12 19:36     ` Michael Kelley
2020-09-10 14:34 ` [PATCH v3 08/11] Input: hyperv-keyboard: Make ringbuffer at least take two pages Boqun Feng
2020-09-10 14:34   ` Boqun Feng
2020-09-12 19:37   ` Michael Kelley [this message]
2020-09-12 19:37     ` Michael Kelley
2020-09-13 16:59     ` Dmitry Torokhov
2020-09-13 16:59       ` Dmitry Torokhov
2020-09-14  8:46   ` Boqun Feng
2020-09-14  8:46     ` Boqun Feng
2020-09-14  9:30     ` Wei Liu
2020-09-14  9:30       ` Wei Liu
2020-09-14 10:22       ` Boqun Feng
2020-09-14 10:22         ` Boqun Feng
2020-09-10 14:34 ` [PATCH v3 09/11] HID: hyperv: " Boqun Feng
2020-09-10 14:34   ` Boqun Feng
2020-09-12 19:38   ` Michael Kelley
2020-09-12 19:38     ` Michael Kelley
2020-09-10 14:34 ` [PATCH v3 10/11] Driver: hv: util: " Boqun Feng
2020-09-10 14:34   ` Boqun Feng
2020-09-12 19:40   ` Michael Kelley
2020-09-12 19:40     ` Michael Kelley
2020-09-10 14:34 ` [PATCH v3 11/11] scsi: storvsc: Support PAGE_SIZE larger than 4K Boqun Feng
2020-09-10 14:34   ` Boqun Feng
2020-09-12 19:55   ` Michael Kelley
2020-09-12 19:55     ` Michael Kelley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW2PR2101MB1052688710B98D8C31191A8DD7250@MW2PR2101MB1052.namprd21.prod.outlook.com \
    --to=mikelley@microsoft.com \
    --cc=Mark.Rutland@arm.com \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=benjamin.tissoires@redhat.com \
    --cc=boqun.feng@gmail.com \
    --cc=catalin.marinas@arm.com \
    --cc=davem@davemloft.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=haiyangz@microsoft.com \
    --cc=jejb@linux.ibm.com \
    --cc=jikos@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kys@microsoft.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=maz@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sthemmin@microsoft.com \
    --cc=wei.liu@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.