From: "Xiong, Jianxin" <jianxin.xiong@intel.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Leon Romanovsky <leon@kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Doug Ledford <dledford@redhat.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
Christian Koenig <christian.koenig@amd.com>,
"Vetter, Daniel" <daniel.vetter@intel.com>
Subject: RE: [PATCH v13 1/4] RDMA/umem: Support importing dma-buf as user memory region
Date: Tue, 8 Dec 2020 19:33:02 +0000 [thread overview]
Message-ID: <MW3PR11MB4555793868036FEB1E600F05E5CD0@MW3PR11MB4555.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201208185915.GO5487@ziepe.ca>
> -----Original Message-----
> From: Jason Gunthorpe <jgg@ziepe.ca>
> Sent: Tuesday, December 08, 2020 10:59 AM
> To: Xiong, Jianxin <jianxin.xiong@intel.com>
> Cc: Leon Romanovsky <leon@kernel.org>; linux-rdma@vger.kernel.org; dri-devel@lists.freedesktop.org; Doug Ledford
> <dledford@redhat.com>; Sumit Semwal <sumit.semwal@linaro.org>; Christian Koenig <christian.koenig@amd.com>; Vetter, Daniel
> <daniel.vetter@intel.com>
> Subject: Re: [PATCH v13 1/4] RDMA/umem: Support importing dma-buf as user memory region
>
> On Tue, Dec 08, 2020 at 06:13:20PM +0000, Xiong, Jianxin wrote:
>
> > > > +static inline struct ib_umem *ib_umem_dmabuf_get(struct ib_device *device,
> > > > + unsigned long offset,
> > > > + size_t size, int fd,
> > > > + int access,
> > > > + struct dma_buf_attach_ops *ops) {
> > > > + return ERR_PTR(-EINVAL);
> > >
> > > Probably, It should be EOPNOTSUPP and not EINVAL.
> >
> > EINVAL is used here to be consistent with existing definitions in the same file.
>
> They may be wrong, EOPNOTSUPP is right for this situation
Ok, let me change all of them to EOPNOTSUPP.
WARNING: multiple messages have this Message-ID (diff)
From: "Xiong, Jianxin" <jianxin.xiong@intel.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Leon Romanovsky <leon@kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Doug Ledford <dledford@redhat.com>,
"Vetter, Daniel" <daniel.vetter@intel.com>,
Christian Koenig <christian.koenig@amd.com>
Subject: RE: [PATCH v13 1/4] RDMA/umem: Support importing dma-buf as user memory region
Date: Tue, 8 Dec 2020 19:33:02 +0000 [thread overview]
Message-ID: <MW3PR11MB4555793868036FEB1E600F05E5CD0@MW3PR11MB4555.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201208185915.GO5487@ziepe.ca>
> -----Original Message-----
> From: Jason Gunthorpe <jgg@ziepe.ca>
> Sent: Tuesday, December 08, 2020 10:59 AM
> To: Xiong, Jianxin <jianxin.xiong@intel.com>
> Cc: Leon Romanovsky <leon@kernel.org>; linux-rdma@vger.kernel.org; dri-devel@lists.freedesktop.org; Doug Ledford
> <dledford@redhat.com>; Sumit Semwal <sumit.semwal@linaro.org>; Christian Koenig <christian.koenig@amd.com>; Vetter, Daniel
> <daniel.vetter@intel.com>
> Subject: Re: [PATCH v13 1/4] RDMA/umem: Support importing dma-buf as user memory region
>
> On Tue, Dec 08, 2020 at 06:13:20PM +0000, Xiong, Jianxin wrote:
>
> > > > +static inline struct ib_umem *ib_umem_dmabuf_get(struct ib_device *device,
> > > > + unsigned long offset,
> > > > + size_t size, int fd,
> > > > + int access,
> > > > + struct dma_buf_attach_ops *ops) {
> > > > + return ERR_PTR(-EINVAL);
> > >
> > > Probably, It should be EOPNOTSUPP and not EINVAL.
> >
> > EINVAL is used here to be consistent with existing definitions in the same file.
>
> They may be wrong, EOPNOTSUPP is right for this situation
Ok, let me change all of them to EOPNOTSUPP.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-12-08 20:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 22:15 [PATCH v13 0/4] RDMA: Add dma-buf support Jianxin Xiong
2020-12-07 22:15 ` Jianxin Xiong
2020-12-07 22:15 ` [PATCH v13 1/4] RDMA/umem: Support importing dma-buf as user memory region Jianxin Xiong
2020-12-07 22:15 ` Jianxin Xiong
2020-12-08 7:05 ` Leon Romanovsky
2020-12-08 7:05 ` Leon Romanovsky
2020-12-08 7:10 ` Xiong, Jianxin
2020-12-08 7:10 ` Xiong, Jianxin
2020-12-08 18:13 ` Xiong, Jianxin
2020-12-08 18:13 ` Xiong, Jianxin
2020-12-08 18:59 ` Jason Gunthorpe
2020-12-08 18:59 ` Jason Gunthorpe
2020-12-08 19:33 ` Xiong, Jianxin [this message]
2020-12-08 19:33 ` Xiong, Jianxin
2020-12-08 19:02 ` Leon Romanovsky
2020-12-08 19:02 ` Leon Romanovsky
2020-12-07 22:15 ` [PATCH v13 2/4] RDMA/core: Add device method for registering dma-buf based " Jianxin Xiong
2020-12-07 22:15 ` Jianxin Xiong
2020-12-08 7:12 ` Leon Romanovsky
2020-12-08 7:12 ` Leon Romanovsky
2020-12-07 22:15 ` [PATCH v13 3/4] RDMA/uverbs: Add uverbs command for dma-buf based MR registration Jianxin Xiong
2020-12-07 22:15 ` Jianxin Xiong
2020-12-08 7:15 ` Leon Romanovsky
2020-12-08 7:15 ` Leon Romanovsky
2020-12-07 22:15 ` [PATCH v13 4/4] RDMA/mlx5: Support dma-buf based userspace memory region Jianxin Xiong
2020-12-07 22:15 ` Jianxin Xiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW3PR11MB4555793868036FEB1E600F05E5CD0@MW3PR11MB4555.namprd11.prod.outlook.com \
--to=jianxin.xiong@intel.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@intel.com \
--cc=dledford@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.