RE: [PATCH v16 0/4] RDMA: Add dma-buf support

From: "Xiong, Jianxin" <jianxin.xiong@intel.com>
To: Yishai Hadas <yishaih@nvidia.com>, Alex Deucher <alexdeucher@gmail.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"Doug Ledford" <dledford@redhat.com>,
	"Vetter, Daniel" <daniel.vetter@intel.com>,
	Christian Koenig <christian.koenig@amd.com>
Subject: RE: [PATCH v16 0/4] RDMA: Add dma-buf support
Date: Tue, 12 Jan 2021 18:11:27 +0000	[thread overview]
Message-ID: <MW3PR11MB4555CBDC7BB290C39FE61DEAE5AA0@MW3PR11MB4555.namprd11.prod.outlook.com> (raw)
In-Reply-To: <8aa96c52-f31f-b8d8-bf16-897775bd9c78@nvidia.com>

 -----Original Message-----
> From: Yishai Hadas <yishaih@nvidia.com>
> Sent: Tuesday, January 12, 2021 4:49 AM
> To: Xiong, Jianxin <jianxin.xiong@intel.com>; Alex Deucher <alexdeucher@gmail.com>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>; Leon Romanovsky <leon@kernel.org>; linux-rdma@vger.kernel.org; dri-devel@lists.freedesktop.org;
> Doug Ledford <dledford@redhat.com>; Vetter, Daniel <daniel.vetter@intel.com>; Christian Koenig <christian.koenig@amd.com>; Yishai
> Hadas <yishaih@nvidia.com>
> Subject: Re: [PATCH v16 0/4] RDMA: Add dma-buf support
> 
> On 1/11/2021 7:55 PM, Xiong, Jianxin wrote:
> >> -----Original Message-----
> >> From: Alex Deucher <alexdeucher@gmail.com>
> >> Sent: Monday, January 11, 2021 9:47 AM
> >> To: Xiong, Jianxin <jianxin.xiong@intel.com>
> >> Cc: Jason Gunthorpe <jgg@ziepe.ca>; Leon Romanovsky
> >> <leon@kernel.org>; linux-rdma@vger.kernel.org;
> >> dri-devel@lists.freedesktop.org; Doug Ledford <dledford@redhat.com>;
> >> Vetter, Daniel <daniel.vetter@intel.com>; Christian Koenig
> >> <christian.koenig@amd.com>
> >> Subject: Re: [PATCH v16 0/4] RDMA: Add dma-buf support
> >>
> >> On Mon, Jan 11, 2021 at 12:44 PM Xiong, Jianxin <jianxin.xiong@intel.com> wrote:
> >>>> -----Original Message-----
> >>>> From: Jason Gunthorpe <jgg@ziepe.ca>
> >>>> Sent: Monday, January 11, 2021 7:43 AM
> >>>> To: Xiong, Jianxin <jianxin.xiong@intel.com>
> >>>> Cc: linux-rdma@vger.kernel.org; dri-devel@lists.freedesktop.org;
> >>>> Doug Ledford <dledford@redhat.com>; Leon Romanovsky
> >>>> <leon@kernel.org>; Sumit Semwal <sumit.semwal@linaro.org>;
> >>>> Christian Koenig <christian.koenig@amd.com>; Vetter, Daniel
> >>>> <daniel.vetter@intel.com>
> >>>> Subject: Re: [PATCH v16 0/4] RDMA: Add dma-buf support
> >>>>
> >>>> On Mon, Jan 11, 2021 at 03:24:18PM +0000, Xiong, Jianxin wrote:
> >>>>> Jason, will this series be able to get into 5.12?
> >>>> I was going to ask you where things are after the break?
> >>>>
> >>>> Did everyone agree the userspace stuff is OK now? Is Edward OK with
> >>>> the pyverbs changes, etc
> >>>>
> >>> There is no new comment on the both the kernel and userspace series.
> >>> I assume silence means no objection. I will ask for opinions on the userspace thread.
> >> Do you have a link to the userspace thread?
> >>
> > https://www.spinics.net/lists/linux-rdma/msg98135.html
> >
> Any reason why the 'fork' comment that was given few times wasn't not handled / answered ?
> 
> Specifically,
> 
> ibv_reg_dmabuf_mr() doesn't call ibv_dontfork_range() but ibv_dereg_mr does call its opposite API (i.e. ibv_dofork_range())
> 

Sorry, that part was missed. Strangely enough, a few of your replies didn't reach my inbox and I just found them in the web archives:  https://www.spinics.net/lists/linux-rdma/msg97973.html, and https://www.spinics.net/lists/linux-rdma/msg98133.html

I will add check to ibv_dereg_mr() to avoid calling ibv_ibv_dofork_range() for dmabuf case.

Thanks a lot for bring this up again.

Jianxin