[igt-dev] [PATCH 0/2] HAX add test description for gem_render_tiled_blits

[igt-dev] [PATCH 0/2] HAX add test description for gem_render_tiled_blits

[janga.rahul.kumar]

From: "Kumar, Janga Rahul" <janga.rahul.kumar@intel.com>

Add test description to gem_render_tiled_blits

Kumar, Janga Rahul (2):
  tests/i915/gem_render_tiled_blits : Added subtests description
  HAX: don't do full run

 tests/i915/gem_render_tiled_blits.c   |  11 +-
 tests/intel-ci/fast-feedback.testlist | 185 +-------------------------
 2 files changed, 11 insertions(+), 185 deletions(-)

-- 
2.25.1

[igt-dev] [PATCH 1/2] tests/i915/gem_render_tiled_blits : Added subtests description

[janga.rahul.kumar]

From: "Kumar, Janga Rahul" <janga.rahul.kumar@intel.com>

Added test description to all the available subtests and
Updated file name in the file description comments.

Signed-off-by: Kumar, Janga Rahul <janga.rahul.kumar@intel.com>
---
 tests/i915/gem_render_tiled_blits.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/tests/i915/gem_render_tiled_blits.c b/tests/i915/gem_render_tiled_blits.c
index 187714d6..61ae9a80 100644
--- a/tests/i915/gem_render_tiled_blits.c
+++ b/tests/i915/gem_render_tiled_blits.c
@@ -25,7 +25,7 @@
  *
  */
 
-/** @file gem_linear_render_blits.c
+/** @file gem_render_tiled_blits.c
  *
  * This is a test of doing many blits, with a working set
  * larger than the aperture size.
@@ -49,6 +49,10 @@
 #include "i915/gem.h"
 #include "igt.h"
 
+IGT_TEST_DESCRIPTION("Tests performs Cyclic forward, backward and random blits on tiled buffer "
+		      "objects using render engine with various working set sizes and compares "
+		      "the blits outputs with expected outputs. ");
+
 #define WIDTH 512
 #define STRIDE (WIDTH*4)
 #define HEIGHT 512
@@ -205,16 +209,20 @@ igt_main
 		igt_require(gem_available_fences(fd) > 0);
 	}
 
+	igt_describe("Check with working set size 2.");
 	igt_subtest("basic") {
 		run_test(fd, 2);
 	}
 
+	igt_describe("Check with working set size larger than aperture size.");
 	igt_subtest("aperture-thrash") {
 		count = 3 * gem_aperture_size(fd) / SIZE / 2;
 		intel_require_memory(count, SIZE, CHECK_RAM);
 		run_test(fd, count);
 	}
 
+	igt_describe("Check with working set size larger than aperture size and "
+		     "helper process to shrink the aperture.");
 	igt_subtest("aperture-shrink") {
 		igt_fork_shrink_helper(fd);
 
@@ -225,6 +233,7 @@ igt_main
 		igt_stop_shrink_helper();
 	}
 
+	igt_describe("Check with working set size larger than swap memory size.");
 	igt_subtest("swap-thrash") {
 		uint64_t swap_mb = intel_get_total_swap_mb();
 		igt_require(swap_mb > 0);
-- 
2.25.1

[igt-dev] [PATCH 2/2] HAX: don't do full run

[janga.rahul.kumar]

From: "Kumar, Janga Rahul" <janga.rahul.kumar@intel.com>

Just for test description, no full run is necessary.
---
 tests/intel-ci/fast-feedback.testlist | 185 +-------------------------
 1 file changed, 1 insertion(+), 184 deletions(-)

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index b579c20a..9f8e18ce 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -1,184 +1 @@
-# Keep alphabetically sorted by default
-
-igt@core_auth@basic-auth
-igt@debugfs_test@read_all_entries
-igt@fbdev@eof
-igt@fbdev@info
-igt@fbdev@nullptr
-igt@fbdev@read
-igt@fbdev@write
-igt@gem_basic@bad-close
-igt@gem_basic@create-close
-igt@gem_basic@create-fd-close
-igt@gem_busy@busy@all
-igt@gem_close_race@basic-process
-igt@gem_close_race@basic-threads
-igt@gem_ctx_create@basic
-igt@gem_ctx_create@basic-files
-igt@gem_ctx_exec@basic
-igt@gem_exec_basic@basic
-igt@gem_exec_create@basic
-igt@gem_exec_fence@basic-busy
-igt@gem_exec_fence@basic-wait
-igt@gem_exec_fence@basic-await
-igt@gem_exec_fence@nb-await
-igt@gem_exec_gttfill@basic
-igt@gem_exec_parallel@engines
-igt@gem_exec_store@basic
-igt@gem_flink_basic@bad-flink
-igt@gem_flink_basic@bad-open
-igt@gem_flink_basic@basic
-igt@gem_flink_basic@double-flink
-igt@gem_flink_basic@flink-lifetime
-igt@gem_huc_copy@huc-copy
-igt@gem_linear_blits@basic
-igt@gem_mmap@basic
-igt@gem_mmap_gtt@basic
-igt@gem_render_linear_blits@basic
-igt@gem_render_tiled_blits@basic
-igt@gem_ringfill@basic-all
-igt@gem_softpin@allocator-basic
-igt@gem_softpin@allocator-basic-reserve
-igt@gem_softpin@safe-alignment
-igt@gem_sync@basic-all
-igt@gem_sync@basic-each
-igt@gem_tiled_blits@basic
-igt@gem_tiled_fence_blits@basic
-igt@gem_tiled_pread_basic
-igt@gem_wait@busy@all
-igt@gem_wait@wait@all
-igt@i915_getparams_basic@basic-eu-total
-igt@i915_getparams_basic@basic-subslice-total
-igt@i915_hangman@error-state-basic
-igt@kms_addfb_basic@addfb25-bad-modifier
-igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling
-igt@kms_addfb_basic@addfb25-modifier-no-flag
-igt@kms_addfb_basic@addfb25-x-tiled-legacy
-igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy
-igt@kms_addfb_basic@addfb25-yf-tiled-legacy
-igt@kms_addfb_basic@addfb25-y-tiled-legacy
-igt@kms_addfb_basic@addfb25-y-tiled-small-legacy
-igt@kms_addfb_basic@bad-pitch-0
-igt@kms_addfb_basic@bad-pitch-1024
-igt@kms_addfb_basic@bad-pitch-128
-igt@kms_addfb_basic@bad-pitch-256
-igt@kms_addfb_basic@bad-pitch-32
-igt@kms_addfb_basic@bad-pitch-63
-igt@kms_addfb_basic@bad-pitch-65536
-igt@kms_addfb_basic@bad-pitch-999
-igt@kms_addfb_basic@basic
-igt@kms_addfb_basic@basic-x-tiled-legacy
-igt@kms_addfb_basic@basic-y-tiled-legacy
-igt@kms_addfb_basic@bo-too-small
-igt@kms_addfb_basic@bo-too-small-due-to-tiling
-igt@kms_addfb_basic@clobberred-modifier
-igt@kms_addfb_basic@framebuffer-vs-set-tiling
-igt@kms_addfb_basic@invalid-get-prop
-igt@kms_addfb_basic@invalid-get-prop-any
-igt@kms_addfb_basic@invalid-set-prop
-igt@kms_addfb_basic@invalid-set-prop-any
-igt@kms_addfb_basic@no-handle
-igt@kms_addfb_basic@size-max
-igt@kms_addfb_basic@small-bo
-igt@kms_addfb_basic@tile-pitch-mismatch
-igt@kms_addfb_basic@too-high
-igt@kms_addfb_basic@too-wide
-igt@kms_addfb_basic@unused-handle
-igt@kms_addfb_basic@unused-modifier
-igt@kms_addfb_basic@unused-offsets
-igt@kms_addfb_basic@unused-pitches
-igt@kms_busy@basic
-igt@kms_chamelium@dp-hpd-fast
-igt@kms_chamelium@dp-edid-read
-igt@kms_chamelium@dp-crc-fast
-igt@kms_chamelium@hdmi-hpd-fast
-igt@kms_chamelium@hdmi-edid-read
-igt@kms_chamelium@hdmi-crc-fast
-igt@kms_chamelium@vga-hpd-fast
-igt@kms_chamelium@vga-edid-read
-igt@kms_prop_blob@basic
-igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic
-igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-after-cursor-atomic
-igt@kms_cursor_legacy@basic-flip-after-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size
-igt@kms_cursor_legacy@basic-flip-before-cursor-atomic
-igt@kms_cursor_legacy@basic-flip-before-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size
-igt@kms_flip@basic-flip-vs-dpms
-igt@kms_flip@basic-flip-vs-modeset
-igt@kms_flip@basic-flip-vs-wf_vblank
-igt@kms_flip@basic-plain-flip
-igt@kms_force_connector_basic@force-connector-state
-igt@kms_force_connector_basic@force-edid
-igt@kms_force_connector_basic@force-load-detect
-igt@kms_force_connector_basic@prune-stale-modes
-igt@kms_frontbuffer_tracking@basic
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d
-igt@kms_pipe_crc_basic@hang-read-crc-pipe-a
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence
-igt@kms_pipe_crc_basic@read-crc-pipe-a
-igt@kms_pipe_crc_basic@read-crc-pipe-b
-igt@kms_pipe_crc_basic@read-crc-pipe-c
-igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence
-igt@kms_psr@primary_page_flip
-igt@kms_psr@cursor_plane_move
-igt@kms_psr@sprite_plane_onoff
-igt@kms_psr@primary_mmap_gtt
-igt@kms_setmode@basic-clone-single-crtc
-igt@i915_pm_backlight@basic-brightness
-igt@i915_pm_rpm@basic-pci-d3-state
-igt@i915_pm_rpm@basic-rte
-igt@i915_pm_rps@basic-api
-igt@prime_self_import@basic-llseek-bad
-igt@prime_self_import@basic-llseek-size
-igt@prime_self_import@basic-with_fd_dup
-igt@prime_self_import@basic-with_one_bo
-igt@prime_self_import@basic-with_one_bo_two_files
-igt@prime_self_import@basic-with_two_bos
-igt@prime_vgem@basic-fence-flip
-igt@prime_vgem@basic-fence-mmap
-igt@prime_vgem@basic-fence-read
-igt@prime_vgem@basic-gtt
-igt@prime_vgem@basic-read
-igt@prime_vgem@basic-write
-igt@prime_vgem@basic-userptr
-igt@vgem_basic@setversion
-igt@vgem_basic@create
-igt@vgem_basic@debugfs
-igt@vgem_basic@dmabuf-export
-igt@vgem_basic@dmabuf-fence
-igt@vgem_basic@dmabuf-fence-before
-igt@vgem_basic@dmabuf-mmap
-igt@vgem_basic@mmap
-igt@vgem_basic@second-client
-igt@vgem_basic@sysfs
-
-# All tests that do module unloading and reloading are executed last.
-# They will sometimes reveal issues of earlier tests leaving the
-# driver in a broken state that is not otherwise noticed in that test.
-
-igt@core_hotunplug@unbind-rebind
-igt@vgem_basic@unload
-igt@i915_module_load@reload
-igt@gem_lmem_swapping@basic
-igt@gem_lmem_swapping@parallel-random-engines
-igt@gem_lmem_swapping@random-engines
-igt@gem_lmem_swapping@verify-random
-igt@i915_pm_rpm@module-reload
-
-# Kernel selftests
-igt@i915_selftest@live
-igt@dmabuf@all
-
-# System wide suspend tests
-igt@i915_suspend@basic-s2idle-without-i915
-igt@i915_suspend@basic-s3-without-i915
-igt@gem_exec_suspend@basic-s0
-igt@gem_exec_suspend@basic-s3
-igt@kms_chamelium@common-hpd-after-suspend
-igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
+igt@meta_test@fail-result
-- 
2.25.1

[igt-dev] ✗ Fi.CI.BAT: failure for HAX add test description for gem_render_tiled_blits

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 8828 bytes --]

== Series Details ==

Series: HAX add test description for gem_render_tiled_blits
URL   : https://patchwork.freedesktop.org/series/104491/
State : failure

== Summary ==

CI Bug Log - changes from IGT_6496 -> IGTPW_7183
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_7183 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_7183, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/index.html

Participating hosts (47 -> 46)
------------------------------

  Additional (1): bat-dg2-9 
  Missing    (2): bat-atsm-1 bat-dg1-5 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_7183:

### IGT changes ###

#### Possible regressions ####

  * igt@meta_test@fail-result (NEW):
    - {bat-jsl-2}:        NOTRUN -> [FAIL][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/bat-jsl-2/igt@meta_test@fail-result.html
    - fi-ilk-650:         NOTRUN -> [FAIL][2]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-ilk-650/igt@meta_test@fail-result.html
    - fi-tgl-u2:          NOTRUN -> [FAIL][3]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-tgl-u2/igt@meta_test@fail-result.html
    - {bat-jsl-1}:        NOTRUN -> [FAIL][4]
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/bat-jsl-1/igt@meta_test@fail-result.html
    - fi-tgl-1115g4:      NOTRUN -> [FAIL][5]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-tgl-1115g4/igt@meta_test@fail-result.html
    - fi-bxt-dsi:         NOTRUN -> [FAIL][6]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-bxt-dsi/igt@meta_test@fail-result.html
    - {fi-jsl-1}:         NOTRUN -> [FAIL][7]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-jsl-1/igt@meta_test@fail-result.html
    - fi-blb-e6850:       NOTRUN -> [FAIL][8]
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-blb-e6850/igt@meta_test@fail-result.html
    - fi-bsw-n3050:       NOTRUN -> [FAIL][9]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-bsw-n3050/igt@meta_test@fail-result.html
    - {bat-adlp-6}:       NOTRUN -> [FAIL][10]
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/bat-adlp-6/igt@meta_test@fail-result.html
    - fi-skl-6600u:       NOTRUN -> [FAIL][11]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-skl-6600u/igt@meta_test@fail-result.html
    - fi-glk-dsi:         NOTRUN -> [FAIL][12]
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-glk-dsi/igt@meta_test@fail-result.html
    - {fi-ehl-2}:         NOTRUN -> [FAIL][13]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-ehl-2/igt@meta_test@fail-result.html
    - fi-apl-guc:         NOTRUN -> [FAIL][14]
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-apl-guc/igt@meta_test@fail-result.html
    - fi-pnv-d510:        NOTRUN -> [FAIL][15]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-pnv-d510/igt@meta_test@fail-result.html
    - fi-bdw-5557u:       NOTRUN -> [FAIL][16]
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-bdw-5557u/igt@meta_test@fail-result.html
    - fi-snb-2520m:       NOTRUN -> [FAIL][17]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-snb-2520m/igt@meta_test@fail-result.html
    - fi-glk-j4005:       NOTRUN -> [FAIL][18]
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-glk-j4005/igt@meta_test@fail-result.html
    - fi-rkl-guc:         NOTRUN -> [FAIL][19]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-rkl-guc/igt@meta_test@fail-result.html
    - fi-skl-guc:         NOTRUN -> [FAIL][20]
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-skl-guc/igt@meta_test@fail-result.html
    - fi-kbl-soraka:      NOTRUN -> [FAIL][21]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-kbl-soraka/igt@meta_test@fail-result.html
    - bat-dg1-6:          NOTRUN -> [FAIL][22]
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/bat-dg1-6/igt@meta_test@fail-result.html
    - fi-kbl-7567u:       NOTRUN -> [FAIL][23]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-kbl-7567u/igt@meta_test@fail-result.html
    - fi-cfl-8700k:       NOTRUN -> [FAIL][24]
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-cfl-8700k/igt@meta_test@fail-result.html
    - {fi-tgl-dsi}:       NOTRUN -> [FAIL][25]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-tgl-dsi/igt@meta_test@fail-result.html
    - fi-bsw-nick:        NOTRUN -> [FAIL][26]
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-bsw-nick/igt@meta_test@fail-result.html
    - fi-rkl-11600:       NOTRUN -> [FAIL][27]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-rkl-11600/igt@meta_test@fail-result.html
    - fi-hsw-g3258:       NOTRUN -> [FAIL][28]
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-hsw-g3258/igt@meta_test@fail-result.html
    - fi-bdw-gvtdvm:      NOTRUN -> [FAIL][29]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-bdw-gvtdvm/igt@meta_test@fail-result.html
    - fi-bsw-kefka:       NOTRUN -> [FAIL][30]
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-bsw-kefka/igt@meta_test@fail-result.html
    - fi-adl-ddr5:        NOTRUN -> [FAIL][31]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-adl-ddr5/igt@meta_test@fail-result.html
    - fi-cfl-guc:         NOTRUN -> [FAIL][32]
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-cfl-guc/igt@meta_test@fail-result.html
    - fi-bwr-2160:        NOTRUN -> [FAIL][33]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-bwr-2160/igt@meta_test@fail-result.html
    - {bat-dg2-9}:        NOTRUN -> [FAIL][34]
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/bat-dg2-9/igt@meta_test@fail-result.html
    - fi-hsw-4770:        NOTRUN -> [FAIL][35]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-hsw-4770/igt@meta_test@fail-result.html
    - fi-skl-6700k2:      NOTRUN -> [FAIL][36]
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-skl-6700k2/igt@meta_test@fail-result.html
    - fi-cfl-8109u:       NOTRUN -> [FAIL][37]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-cfl-8109u/igt@meta_test@fail-result.html
    - bat-adlp-4:         NOTRUN -> [FAIL][38]
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/bat-adlp-4/igt@meta_test@fail-result.html
    - {bat-adln-1}:       NOTRUN -> [FAIL][39]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/bat-adln-1/igt@meta_test@fail-result.html
    - fi-kbl-8809g:       NOTRUN -> [FAIL][40]
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-kbl-8809g/igt@meta_test@fail-result.html
    - fi-ivb-3770:        NOTRUN -> [FAIL][41]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-ivb-3770/igt@meta_test@fail-result.html
    - fi-elk-e7500:       NOTRUN -> [FAIL][42]
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-elk-e7500/igt@meta_test@fail-result.html
    - {bat-dg2-8}:        NOTRUN -> [FAIL][43]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/bat-dg2-8/igt@meta_test@fail-result.html
    - fi-kbl-guc:         NOTRUN -> [FAIL][44]
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-kbl-guc/igt@meta_test@fail-result.html
    - fi-snb-2600:        NOTRUN -> [FAIL][45]
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/fi-snb-2600/igt@meta_test@fail-result.html
    - {bat-adlm-1}:       NOTRUN -> [FAIL][46]
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/bat-adlm-1/igt@meta_test@fail-result.html

  
New tests
---------

  New tests have been introduced between IGT_6496 and IGTPW_7183:

### New IGT tests (1) ###

  * igt@meta_test@fail-result:
    - Statuses : 46 fail(s)
    - Exec time: [0.00, 0.37] s

  

  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).



Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6496 -> IGTPW_7183

  CI-20190529: 20190529
  CI_DRM_11705: 18a2e6dbca526f996da04741cf5ef169e810a50e @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_7183: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/index.html
  IGT_6496: 58a5a2d5be19b916311541401aaa48b787f9a185 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7183/index.html

[-- Attachment #2: Type: text/html, Size: 10139 bytes --]

Re: [igt-dev] [PATCH 1/2] tests/i915/gem_render_tiled_blits : Added subtests description

[Kamil Konieczny]

Hi Janga,

On 2022-05-30 at 12:10:11 +0530, janga.rahul.kumar@intel.com wrote:
> From: "Kumar, Janga Rahul" <janga.rahul.kumar@intel.com>
> 
> Added test description to all the available subtests and
> Updated file name in the file description comments.
- ^
s/Updated/fix/

Put description here what did you changed from previous version,
see other patch series with v2 (or larger version).

> 
> Signed-off-by: Kumar, Janga Rahul <janga.rahul.kumar@intel.com>
---------------- ^

Please re-arrange you name in s-o-b to:

Janga Rahul Kumar <janga.rahul.kumar@intel.com>

Please add all addresses used for cc or to here (except this
mailinglist), for example see patch 1/2 in this series:

HAX add description to gem_exec_basic
https://patchwork.freedesktop.org/series/103196/

> ---
>  tests/i915/gem_render_tiled_blits.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_render_tiled_blits.c b/tests/i915/gem_render_tiled_blits.c
> index 187714d6..61ae9a80 100644
> --- a/tests/i915/gem_render_tiled_blits.c
> +++ b/tests/i915/gem_render_tiled_blits.c
> @@ -25,7 +25,7 @@
>   *
>   */
>  
> -/** @file gem_linear_render_blits.c
> +/** @file gem_render_tiled_blits.c

Nice catch.

>   *
>   * This is a test of doing many blits, with a working set
>   * larger than the aperture size.
> @@ -49,6 +49,10 @@
>  #include "i915/gem.h"
>  #include "igt.h"
>  
> +IGT_TEST_DESCRIPTION("Tests performs Cyclic forward, backward and random blits on tiled buffer "

s/Cyclic/cyclic/

> +		      "objects using render engine with various working set sizes and compares "
> +		      "the blits outputs with expected outputs. ");
-------------------------------------------------------------- ^

Remove spaces at strings end.

You can also shorten this a little, like:
s/the blits outputs with expected outputs. /outputs with expected ones./

or even
s/compares the blits outputs with expected outputs. /verify outputs./

Your choice (you can also rewrite it to some other form).

> +
>  #define WIDTH 512
>  #define STRIDE (WIDTH*4)
>  #define HEIGHT 512
> @@ -205,16 +209,20 @@ igt_main
>  		igt_require(gem_available_fences(fd) > 0);
>  	}
>  
> +	igt_describe("Check with working set size 2.");
------------------------------------------------- ^
This number here do not describe anything, maybe just write
"Run basic check." or "Verify basic functionality." or
something like that.

>  	igt_subtest("basic") {
>  		run_test(fd, 2);
>  	}
>  
> +	igt_describe("Check with working set size larger than aperture size.");
>  	igt_subtest("aperture-thrash") {
>  		count = 3 * gem_aperture_size(fd) / SIZE / 2;
>  		intel_require_memory(count, SIZE, CHECK_RAM);
>  		run_test(fd, count);
>  	}
>  
> +	igt_describe("Check with working set size larger than aperture size and "
> +		     "helper process to shrink the aperture.");

I am not sure that this shrinks aperture, what I see there is
drop caches. For more info see commit e8eb9afd4c5 with
git log -p e8eb9afd4c5

>  	igt_subtest("aperture-shrink") {
>  		igt_fork_shrink_helper(fd);
>  
> @@ -225,6 +233,7 @@ igt_main
>  		igt_stop_shrink_helper();
>  	}
>  
> +	igt_describe("Check with working set size larger than swap memory size.");

Do we want cause oom here ? imho test wants to use up all memory
and so system will try to use swap. This is in following line:

		count = ((intel_get_avail_ram_mb() + (swap_mb / 2)) * 1024*1024) / SIZE;

--
Kamil

>  	igt_subtest("swap-thrash") {
>  		uint64_t swap_mb = intel_get_total_swap_mb();
>  		igt_require(swap_mb > 0);
> -- 
> 2.25.1
> 

Re: [igt-dev] [PATCH 1/2] tests/i915/gem_render_tiled_blits : Added subtests description

[Kumar, Janga Rahul]

> -----Original Message-----
> From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Sent: 31 May 2022 00:09
> To: igt-dev@lists.freedesktop.org
> Cc: Gandi, Ramadevi <ramadevi.gandi@intel.com>; Ch, Sai Gowtham
> <sai.gowtham.ch@intel.com>; Dandamudi, Priyanka
> <priyanka.dandamudi@intel.com>; Kumar, Janga Rahul
> <janga.rahul.kumar@intel.com>
> Subject: Re: [PATCH 1/2] tests/i915/gem_render_tiled_blits : Added subtests
> description
> 
> Hi Janga,
> 
> On 2022-05-30 at 12:10:11 +0530, janga.rahul.kumar@intel.com wrote:
> > From: "Kumar, Janga Rahul" <janga.rahul.kumar@intel.com>
> >
> > Added test description to all the available subtests and Updated file
> > name in the file description comments.
> - ^
> s/Updated/fix/
> 
> Put description here what did you changed from previous version, see other
> patch series with v2 (or larger version).
> 
> >
> > Signed-off-by: Kumar, Janga Rahul <janga.rahul.kumar@intel.com>
> ---------------- ^
> 
> Please re-arrange you name in s-o-b to:
> 
> Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> 
> Please add all addresses used for cc or to here (except this mailinglist), for
> example see patch 1/2 in this series:
> 
> HAX add description to gem_exec_basic
> https://patchwork.freedesktop.org/series/103196/
> 
> > ---
> >  tests/i915/gem_render_tiled_blits.c | 11 ++++++++++-
> >  1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/i915/gem_render_tiled_blits.c
> > b/tests/i915/gem_render_tiled_blits.c
> > index 187714d6..61ae9a80 100644
> > --- a/tests/i915/gem_render_tiled_blits.c
> > +++ b/tests/i915/gem_render_tiled_blits.c
> > @@ -25,7 +25,7 @@
> >   *
> >   */
> >
> > -/** @file gem_linear_render_blits.c
> > +/** @file gem_render_tiled_blits.c
> 
> Nice catch.
> 
> >   *
> >   * This is a test of doing many blits, with a working set
> >   * larger than the aperture size.
> > @@ -49,6 +49,10 @@
> >  #include "i915/gem.h"
> >  #include "igt.h"
> >
> > +IGT_TEST_DESCRIPTION("Tests performs Cyclic forward, backward and
> random blits on tiled buffer "
> 
> s/Cyclic/cyclic/
> 
> > +		      "objects using render engine with various working set sizes
> and compares "
> > +		      "the blits outputs with expected outputs. ");
> -------------------------------------------------------------- ^
> 
> Remove spaces at strings end.
> 
> You can also shorten this a little, like:
> s/the blits outputs with expected outputs. /outputs with expected ones./
> 
> or even
> s/compares the blits outputs with expected outputs. /verify outputs./
> 
> Your choice (you can also rewrite it to some other form).
> 
> > +
> >  #define WIDTH 512
> >  #define STRIDE (WIDTH*4)
> >  #define HEIGHT 512
> > @@ -205,16 +209,20 @@ igt_main
> >  		igt_require(gem_available_fences(fd) > 0);
> >  	}
> >
> > +	igt_describe("Check with working set size 2.");
> ------------------------------------------------- ^ This number here do not describe
> anything, maybe just write "Run basic check." or "Verify basic functionality." or
> something like that.
> 
> >  	igt_subtest("basic") {
> >  		run_test(fd, 2);
> >  	}
> >
> > +	igt_describe("Check with working set size larger than aperture
> > +size.");
> >  	igt_subtest("aperture-thrash") {
> >  		count = 3 * gem_aperture_size(fd) / SIZE / 2;
> >  		intel_require_memory(count, SIZE, CHECK_RAM);
> >  		run_test(fd, count);
> >  	}
> >
> > +	igt_describe("Check with working set size larger than aperture size and "
> > +		     "helper process to shrink the aperture.");
> 
> I am not sure that this shrinks aperture, what I see there is drop caches. For
> more info see commit e8eb9afd4c5 with git log -p e8eb9afd4c5
[Janga Rahul Kumar] yes, it doesn’t shrink the aperture. It shrinks the buffer object caches and checks whether the required amount of memory can be met after dropping caches.
 
> 
> >  	igt_subtest("aperture-shrink") {
> >  		igt_fork_shrink_helper(fd);
> >
> > @@ -225,6 +233,7 @@ igt_main
> >  		igt_stop_shrink_helper();
> >  	}
> >
> > +	igt_describe("Check with working set size larger than swap memory
> > +size.");
> 
> Do we want cause oom here ? imho test wants to use up all memory and so
> system will try to use swap. This is in following line:
[Janga Rahul Kumar] Agree
> 
> 		count = ((intel_get_avail_ram_mb() + (swap_mb / 2)) *
> 1024*1024) / SIZE;
> 
> --
> Kamil
> 
> >  	igt_subtest("swap-thrash") {
> >  		uint64_t swap_mb = intel_get_total_swap_mb();
> >  		igt_require(swap_mb > 0);
> > --
> > 2.25.1
> >

[igt-dev] [PATCH 1/2] tests/i915/gem_render_tiled_blits : Added subtests description

[janga.rahul.kumar]

From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>

Added test description to all the available subtests and
fix file name in the file description comments.

v2: Fix syntax issues.
v3: Modified subtest description.

Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 tests/i915/gem_render_tiled_blits.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/tests/i915/gem_render_tiled_blits.c b/tests/i915/gem_render_tiled_blits.c
index 13c1f37a..52d67b76 100644
--- a/tests/i915/gem_render_tiled_blits.c
+++ b/tests/i915/gem_render_tiled_blits.c
@@ -25,7 +25,7 @@
  *
  */
 
-/** @file gem_linear_render_blits.c
+/** @file gem_render_tiled_blits.c
  *
  * This is a test of doing many blits, with a working set
  * larger than the aperture size.
@@ -49,6 +49,10 @@
 #include "i915/gem.h"
 #include "igt.h"
 
+IGT_TEST_DESCRIPTION("Tests performs cyclic forward, backward and random blits on tiled buffer "
+		      "objects using render engine with various working set sizes and compares "
+		      "outputs with expected ones.");
+
 #define WIDTH 512
 #define STRIDE (WIDTH*4)
 #define HEIGHT 512
@@ -205,16 +209,20 @@ igt_main
 		igt_require(gem_available_fences(fd) > 0);
 	}
 
+	igt_describe("Check basic functionality.");
 	igt_subtest("basic") {
 		run_test(fd, 2);
 	}
 
+	igt_describe("Check with working set size larger than aperture size.");
 	igt_subtest("aperture-thrash") {
 		count = 3 * gem_aperture_size(fd) / SIZE / 2;
 		igt_require_memory(count, SIZE, CHECK_RAM);
 		run_test(fd, count);
 	}
 
+	igt_describe("Check with working set size larger than aperture size and "
+		     "a helper process to shrink buffer object caches.");
 	igt_subtest("aperture-shrink") {
 		igt_fork_shrink_helper(fd);
 
@@ -225,6 +233,8 @@ igt_main
 		igt_stop_shrink_helper();
 	}
 
+	igt_describe("Check with working set size larger than system memory size "
+		     "resulting in usage and thrashing of swap space.");
 	igt_subtest("swap-thrash") {
 		uint64_t swap_mb = igt_get_total_swap_mb();
 		igt_require(swap_mb > 0);
-- 
2.25.1

Re: [igt-dev] [PATCH 1/2] tests/i915/gem_render_tiled_blits : Added subtests description

[Kamil Konieczny]

On 2022-06-01 at 02:41:35 +0530, janga.rahul.kumar@intel.com wrote:
> From: "Kumar, Janga Rahul" <janga.rahul.kumar@intel.com>
> 
> Added test description to all the available subtests and
> fix file name in the file description comments.
> 
> v2: Fix syntax issues.
> v3: Modified subtest description.
> 
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Cc: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> ---
>  tests/i915/gem_render_tiled_blits.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_render_tiled_blits.c b/tests/i915/gem_render_tiled_blits.c
> index 187714d6..5ccb195e 100644
> --- a/tests/i915/gem_render_tiled_blits.c
> +++ b/tests/i915/gem_render_tiled_blits.c
> @@ -25,7 +25,7 @@
>   *
>   */
>  
> -/** @file gem_linear_render_blits.c
> +/** @file gem_render_tiled_blits.c
>   *
>   * This is a test of doing many blits, with a working set
>   * larger than the aperture size.
> @@ -49,6 +49,10 @@
>  #include "i915/gem.h"
>  #include "igt.h"
>  
> +IGT_TEST_DESCRIPTION("Tests performs cyclic forward, backward and random blits on tiled buffer "
> +		      "objects using render engine with various working set sizes and compares "
> +		      "outputs with expected ones.");
> +
>  #define WIDTH 512
>  #define STRIDE (WIDTH*4)
>  #define HEIGHT 512
> @@ -205,16 +209,20 @@ igt_main
>  		igt_require(gem_available_fences(fd) > 0);
>  	}
>  
> +	igt_describe("Check basic functionality.");
>  	igt_subtest("basic") {
>  		run_test(fd, 2);
>  	}
>  
> +	igt_describe("Check with working set size larger than aperture size.");
>  	igt_subtest("aperture-thrash") {
>  		count = 3 * gem_aperture_size(fd) / SIZE / 2;
>  		intel_require_memory(count, SIZE, CHECK_RAM);
>  		run_test(fd, count);
>  	}
>  
> +	igt_describe("Check with working set size larger than aperture size and "
> +		     "a helper process to shrink buffer object caches.");
>  	igt_subtest("aperture-shrink") {
>  		igt_fork_shrink_helper(fd);
>  
> @@ -225,6 +233,8 @@ igt_main
>  		igt_stop_shrink_helper();
>  	}
>  
> +	igt_describe("Check with working set size larger than system memory size "
> +		     "resulting in usage and thrashing of swap space.");
>  	igt_subtest("swap-thrash") {
>  		uint64_t swap_mb = intel_get_total_swap_mb();
>  		igt_require(swap_mb > 0);
> -- 
> 2.25.1
> 

Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

--
Kamil

[igt-dev] [PATCH 1/2] tests/i915/gem_render_tiled_blits : Added subtests description

[janga.rahul.kumar]

From: "Kumar, Janga Rahul" <janga.rahul.kumar@intel.com>

Added test description to all the available subtests and
fix file name in the file description comments.

v2: Fix syntax issues.
v3: Modified subtest description.

Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
---
 tests/i915/gem_render_tiled_blits.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/tests/i915/gem_render_tiled_blits.c b/tests/i915/gem_render_tiled_blits.c
index 187714d6..5ccb195e 100644
--- a/tests/i915/gem_render_tiled_blits.c
+++ b/tests/i915/gem_render_tiled_blits.c
@@ -25,7 +25,7 @@
  *
  */
 
-/** @file gem_linear_render_blits.c
+/** @file gem_render_tiled_blits.c
  *
  * This is a test of doing many blits, with a working set
  * larger than the aperture size.
@@ -49,6 +49,10 @@
 #include "i915/gem.h"
 #include "igt.h"
 
+IGT_TEST_DESCRIPTION("Tests performs cyclic forward, backward and random blits on tiled buffer "
+		      "objects using render engine with various working set sizes and compares "
+		      "outputs with expected ones.");
+
 #define WIDTH 512
 #define STRIDE (WIDTH*4)
 #define HEIGHT 512
@@ -205,16 +209,20 @@ igt_main
 		igt_require(gem_available_fences(fd) > 0);
 	}
 
+	igt_describe("Check basic functionality.");
 	igt_subtest("basic") {
 		run_test(fd, 2);
 	}
 
+	igt_describe("Check with working set size larger than aperture size.");
 	igt_subtest("aperture-thrash") {
 		count = 3 * gem_aperture_size(fd) / SIZE / 2;
 		intel_require_memory(count, SIZE, CHECK_RAM);
 		run_test(fd, count);
 	}
 
+	igt_describe("Check with working set size larger than aperture size and "
+		     "a helper process to shrink buffer object caches.");
 	igt_subtest("aperture-shrink") {
 		igt_fork_shrink_helper(fd);
 
@@ -225,6 +233,8 @@ igt_main
 		igt_stop_shrink_helper();
 	}
 
+	igt_describe("Check with working set size larger than system memory size "
+		     "resulting in usage and thrashing of swap space.");
 	igt_subtest("swap-thrash") {
 		uint64_t swap_mb = intel_get_total_swap_mb();
 		igt_require(swap_mb > 0);
-- 
2.25.1

[igt-dev] [PATCH 1/2] tests/i915/gem_render_tiled_blits : Added subtests description

[janga.rahul.kumar]

From: "Kumar, Janga Rahul" <janga.rahul.kumar@intel.com>

Added test description to all the available subtests and
Updated file name in the file description comments.

Signed-off-by: Kumar, Janga Rahul <janga.rahul.kumar@intel.com>
---
 tests/i915/gem_render_tiled_blits.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/tests/i915/gem_render_tiled_blits.c b/tests/i915/gem_render_tiled_blits.c
index 187714d6..2cd4e235 100644
--- a/tests/i915/gem_render_tiled_blits.c
+++ b/tests/i915/gem_render_tiled_blits.c
@@ -25,7 +25,7 @@
  *
  */
 
-/** @file gem_linear_render_blits.c
+/** @file gem_render_tiled_blits.c
  *
  * This is a test of doing many blits, with a working set
  * larger than the aperture size.
@@ -49,6 +49,10 @@
 #include "i915/gem.h"
 #include "igt.h"
 
+IGT_TEST_DESCRIPTION("Tests performs Cyclic forward, backward and random blits on tiled buffer "
+		      "objects using render engine with various working set sizes and compares "
+		      "the blits outputs with expected outputs. ")
+
 #define WIDTH 512
 #define STRIDE (WIDTH*4)
 #define HEIGHT 512
@@ -205,16 +209,20 @@ igt_main
 		igt_require(gem_available_fences(fd) > 0);
 	}
 
+	igt_describe("Check with working set size 2.");
 	igt_subtest("basic") {
 		run_test(fd, 2);
 	}
 
+	igt_describe("Check with working set size larger than aperture size.");
 	igt_subtest("aperture-thrash") {
 		count = 3 * gem_aperture_size(fd) / SIZE / 2;
 		intel_require_memory(count, SIZE, CHECK_RAM);
 		run_test(fd, count);
 	}
 
+	igt_describe("Check with working set size larger than aperture size and "
+		     "helper process to shrink the aperture.");
 	igt_subtest("aperture-shrink") {
 		igt_fork_shrink_helper(fd);
 
@@ -225,6 +233,7 @@ igt_main
 		igt_stop_shrink_helper();
 	}
 
+	igt_describe("Check with working set size larger than swap memory size.");
 	igt_subtest("swap-thrash") {
 		uint64_t swap_mb = intel_get_total_swap_mb();
 		igt_require(swap_mb > 0);
-- 
2.25.1