* [Intel-wired-lan] [PATCH net-next] ice: return proper error code in ice_add_adv_rule
@ 2022-04-01 9:59 Wojciech Drewek
2022-04-20 10:02 ` Penigalapati, Sandeep
2022-04-20 10:16 ` Paul Menzel
0 siblings, 2 replies; 4+ messages in thread
From: Wojciech Drewek @ 2022-04-01 9:59 UTC (permalink / raw)
To: intel-wired-lan
When number of words exceeds ICE_MAX_CHAIN_WORDS, -ENOSPC
should be returned not -EINVAL. Do not overwrite this
error code in ice_add_tc_flower_adv_fltr.
Signed-off-by: Wojciech Drewek <wojciech.drewek@intel.com>
Suggested-by: Marcin Szycik <marcin.szycik@linux.intel.com>
Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
---
drivers/net/ethernet/intel/ice/ice_switch.c | 5 ++++-
drivers/net/ethernet/intel/ice/ice_tc_lib.c | 1 -
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
index ed7130b7abfe..01f7029ec22f 100644
--- a/drivers/net/ethernet/intel/ice/ice_switch.c
+++ b/drivers/net/ethernet/intel/ice/ice_switch.c
@@ -5992,9 +5992,12 @@ ice_add_adv_rule(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
word_cnt++;
}
- if (!word_cnt || word_cnt > ICE_MAX_CHAIN_WORDS)
+ if (!word_cnt)
return -EINVAL;
+ if (word_cnt > ICE_MAX_CHAIN_WORDS)
+ return -ENOSPC;
+
/* locate a dummy packet */
profile = ice_find_dummy_packet(lkups, lkups_cnt, rinfo->tun_type);
diff --git a/drivers/net/ethernet/intel/ice/ice_tc_lib.c b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
index f3a51597f7f6..4cee0fcf91d1 100644
--- a/drivers/net/ethernet/intel/ice/ice_tc_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
@@ -748,7 +748,6 @@ ice_add_tc_flower_adv_fltr(struct ice_vsi *vsi,
} else if (ret) {
NL_SET_ERR_MSG_MOD(tc_fltr->extack,
"Unable to add filter due to error");
- ret = -EIO;
goto exit;
}
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Intel-wired-lan] [PATCH net-next] ice: return proper error code in ice_add_adv_rule
2022-04-01 9:59 [Intel-wired-lan] [PATCH net-next] ice: return proper error code in ice_add_adv_rule Wojciech Drewek
@ 2022-04-20 10:02 ` Penigalapati, Sandeep
2022-04-20 10:16 ` Paul Menzel
1 sibling, 0 replies; 4+ messages in thread
From: Penigalapati, Sandeep @ 2022-04-20 10:02 UTC (permalink / raw)
To: intel-wired-lan
>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
>Wojciech Drewek
>Sent: Friday, April 1, 2022 3:30 PM
To: intel-wired-lan@lists.osuosl.org
>Subject: [Intel-wired-lan] [PATCH net-next] ice: return proper error code in
>ice_add_adv_rule
>
>When number of words exceeds ICE_MAX_CHAIN_WORDS, -ENOSPC should
>be returned not -EINVAL. Do not overwrite this error code in
>ice_add_tc_flower_adv_fltr.
>
>Signed-off-by: Wojciech Drewek <wojciech.drewek@intel.com>
>Suggested-by: Marcin Szycik <marcin.szycik@linux.intel.com>
>Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
>---
> drivers/net/ethernet/intel/ice/ice_switch.c | 5 ++++-
>drivers/net/ethernet/intel/ice/ice_tc_lib.c | 1 -
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
Tested-by: Sandeep Penigalapati <sandeep.penigalapati@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-wired-lan] [PATCH net-next] ice: return proper error code in ice_add_adv_rule
2022-04-01 9:59 [Intel-wired-lan] [PATCH net-next] ice: return proper error code in ice_add_adv_rule Wojciech Drewek
2022-04-20 10:02 ` Penigalapati, Sandeep
@ 2022-04-20 10:16 ` Paul Menzel
2022-04-20 10:36 ` Drewek, Wojciech
1 sibling, 1 reply; 4+ messages in thread
From: Paul Menzel @ 2022-04-20 10:16 UTC (permalink / raw)
To: intel-wired-lan
Dear Wojciech,
Thank you for your patch.
Am 01.04.22 um 11:59 schrieb Wojciech Drewek:
> When number of words exceeds ICE_MAX_CHAIN_WORDS, -ENOSPC
> should be returned not -EINVAL. Do not overwrite this
> error code in ice_add_tc_flower_adv_fltr.
Maybe make that two commits?
Also for the subject, instead of ?proper error code?, just name it. Maybe:
> ice: ice_add_adv_rule: return ENOSPC when exceeding ICE_MAX_CHAIN_WORDS
Kind regards,
Paul
> Signed-off-by: Wojciech Drewek <wojciech.drewek@intel.com>
> Suggested-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_switch.c | 5 ++++-
> drivers/net/ethernet/intel/ice/ice_tc_lib.c | 1 -
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
> index ed7130b7abfe..01f7029ec22f 100644
> --- a/drivers/net/ethernet/intel/ice/ice_switch.c
> +++ b/drivers/net/ethernet/intel/ice/ice_switch.c
> @@ -5992,9 +5992,12 @@ ice_add_adv_rule(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
> word_cnt++;
> }
>
> - if (!word_cnt || word_cnt > ICE_MAX_CHAIN_WORDS)
> + if (!word_cnt)
> return -EINVAL;
>
> + if (word_cnt > ICE_MAX_CHAIN_WORDS)
> + return -ENOSPC;
> +
> /* locate a dummy packet */
> profile = ice_find_dummy_packet(lkups, lkups_cnt, rinfo->tun_type);
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_tc_lib.c b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
> index f3a51597f7f6..4cee0fcf91d1 100644
> --- a/drivers/net/ethernet/intel/ice/ice_tc_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
> @@ -748,7 +748,6 @@ ice_add_tc_flower_adv_fltr(struct ice_vsi *vsi,
> } else if (ret) {
> NL_SET_ERR_MSG_MOD(tc_fltr->extack,
> "Unable to add filter due to error");
> - ret = -EIO;
> goto exit;
> }
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [Intel-wired-lan] [PATCH net-next] ice: return proper error code in ice_add_adv_rule
2022-04-20 10:16 ` Paul Menzel
@ 2022-04-20 10:36 ` Drewek, Wojciech
0 siblings, 0 replies; 4+ messages in thread
From: Drewek, Wojciech @ 2022-04-20 10:36 UTC (permalink / raw)
To: intel-wired-lan
Hi Paul,
Thanks for the review!
> -----Original Message-----
> From: Paul Menzel <pmenzel@molgen.mpg.de>
> Sent: ?roda, 20 kwietnia 2022 12:16
> To: Drewek, Wojciech <wojciech.drewek@intel.com>
> Cc: intel-wired-lan at lists.osuosl.org
> Subject: Re: [Intel-wired-lan] [PATCH net-next] ice: return proper error code in ice_add_adv_rule
>
> Dear Wojciech,
>
>
> Thank you for your patch.
>
> Am 01.04.22 um 11:59 schrieb Wojciech Drewek:
> > When number of words exceeds ICE_MAX_CHAIN_WORDS, -ENOSPC
> > should be returned not -EINVAL. Do not overwrite this
> > error code in ice_add_tc_flower_adv_fltr.
>
> Maybe make that two commits?
IMO there is no need for that. Those changes are logically connected,
why bother changing error code when it?s overwritten later.
>
> Also for the subject, instead of ?proper error code?, just name it. Maybe:
>
> > ice: ice_add_adv_rule: return ENOSPC when exceeding ICE_MAX_CHAIN_WORDS
Yea, I think it sounds better, will send v2.
Regards,
Wojtek
>
>
> Kind regards,
>
> Paul
>
>
> > Signed-off-by: Wojciech Drewek <wojciech.drewek@intel.com>
> > Suggested-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> > Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> > ---
> > drivers/net/ethernet/intel/ice/ice_switch.c | 5 ++++-
> > drivers/net/ethernet/intel/ice/ice_tc_lib.c | 1 -
> > 2 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c b/drivers/net/ethernet/intel/ice/ice_switch.c
> > index ed7130b7abfe..01f7029ec22f 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_switch.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_switch.c
> > @@ -5992,9 +5992,12 @@ ice_add_adv_rule(struct ice_hw *hw, struct ice_adv_lkup_elem *lkups,
> > word_cnt++;
> > }
> >
> > - if (!word_cnt || word_cnt > ICE_MAX_CHAIN_WORDS)
> > + if (!word_cnt)
> > return -EINVAL;
> >
> > + if (word_cnt > ICE_MAX_CHAIN_WORDS)
> > + return -ENOSPC;
> > +
> > /* locate a dummy packet */
> > profile = ice_find_dummy_packet(lkups, lkups_cnt, rinfo->tun_type);
> >
> > diff --git a/drivers/net/ethernet/intel/ice/ice_tc_lib.c b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
> > index f3a51597f7f6..4cee0fcf91d1 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_tc_lib.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_tc_lib.c
> > @@ -748,7 +748,6 @@ ice_add_tc_flower_adv_fltr(struct ice_vsi *vsi,
> > } else if (ret) {
> > NL_SET_ERR_MSG_MOD(tc_fltr->extack,
> > "Unable to add filter due to error");
> > - ret = -EIO;
> > goto exit;
> > }
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-20 10:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-01 9:59 [Intel-wired-lan] [PATCH net-next] ice: return proper error code in ice_add_adv_rule Wojciech Drewek
2022-04-20 10:02 ` Penigalapati, Sandeep
2022-04-20 10:16 ` Paul Menzel
2022-04-20 10:36 ` Drewek, Wojciech
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.