All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lu, Brent" <brent.lu@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>
Subject: RE: [PATCH] ASoC: soc-acpi: add alternative id field for machine driver matching
Date: Wed, 6 Oct 2021 16:31:08 +0000	[thread overview]
Message-ID: <MWHPR11MB19193D5CA0A58CF4E73DB46C97B09@MWHPR11MB1919.namprd11.prod.outlook.com> (raw)
In-Reply-To: <da650858-6523-4813-6433-438e974d060a@linux.intel.com>

> 
> I am not following your suggestion. The machine drivers for I2S/TDM platforms
> are typically based on specific headphone codecs, and they we add possible
> swaps for amplifiers. The key to find a machine is typically the headphone HID.
> Exhibit A for this in your own contribution in the recent weeks with the
> sof_cs42l42.c machine driver.
> 
> Are you suggesting we unify e.g. sof_rt5682.c and sof_cs42l42.c?
> 
> The other problem is that today we have one main HID along with 'quirk_data'
> for amplifiers. If we have alternate HIDs, what would be the rule for quirk_data?
> Can the quirks apply to all possible alternate HIDs? Only one of them?
> 
> Without an example where this new alternate ID is used it's hard to see what the
> ask and directions might be.
> 

I've sent the patch again with two follow-up patches for the changes to machine driver
and the enumeration. Currently the sof-rt5682.c supports two headphone codec drivers,
rt5682 and rt5682s, enumerated by different HID. So we need to duplicate all the entries
in enumeration tables and board configs in machine driver to support rt5682s. By adding
an extra field id_alt to the enumeration table, we just need to modify existing entries
instead of creating new ones.

For amplifier, I think we can implement an new machine_quirk function to support multiple
amplifier HID.


WARNING: multiple messages have this Message-ID (diff)
From: "Lu, Brent" <brent.lu@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] ASoC: soc-acpi: add alternative id field for machine driver matching
Date: Wed, 6 Oct 2021 16:31:08 +0000	[thread overview]
Message-ID: <MWHPR11MB19193D5CA0A58CF4E73DB46C97B09@MWHPR11MB1919.namprd11.prod.outlook.com> (raw)
In-Reply-To: <da650858-6523-4813-6433-438e974d060a@linux.intel.com>

> 
> I am not following your suggestion. The machine drivers for I2S/TDM platforms
> are typically based on specific headphone codecs, and they we add possible
> swaps for amplifiers. The key to find a machine is typically the headphone HID.
> Exhibit A for this in your own contribution in the recent weeks with the
> sof_cs42l42.c machine driver.
> 
> Are you suggesting we unify e.g. sof_rt5682.c and sof_cs42l42.c?
> 
> The other problem is that today we have one main HID along with 'quirk_data'
> for amplifiers. If we have alternate HIDs, what would be the rule for quirk_data?
> Can the quirks apply to all possible alternate HIDs? Only one of them?
> 
> Without an example where this new alternate ID is used it's hard to see what the
> ask and directions might be.
> 

I've sent the patch again with two follow-up patches for the changes to machine driver
and the enumeration. Currently the sof-rt5682.c supports two headphone codec drivers,
rt5682 and rt5682s, enumerated by different HID. So we need to duplicate all the entries
in enumeration tables and board configs in machine driver to support rt5682s. By adding
an extra field id_alt to the enumeration table, we just need to modify existing entries
instead of creating new ones.

For amplifier, I think we can implement an new machine_quirk function to support multiple
amplifier HID.


  reply	other threads:[~2021-10-06 16:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06  8:43 [PATCH] ASoC: soc-acpi: add alternative id field for machine driver matching Brent Lu
2021-10-06  8:43 ` Brent Lu
2021-10-06 12:17 ` Pierre-Louis Bossart
2021-10-06 12:17   ` Pierre-Louis Bossart
2021-10-06 16:31   ` Lu, Brent [this message]
2021-10-06 16:31     ` Lu, Brent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB19193D5CA0A58CF4E73DB46C97B09@MWHPR11MB1919.namprd11.prod.outlook.com \
    --to=brent.lu@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.