From: Park, Aiden <aiden.park@intel.com>
To: u-boot@lists.denx.de
Subject: [PATCH 6/8] x86: Fix 64-bit compile warning
Date: Wed, 29 Apr 2020 06:08:33 +0000 [thread overview]
Message-ID: <MWHPR11MB2048C73981D7559D126148078EAD0@MWHPR11MB2048.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAPnjgZ15ZEUF00u3NrCDTPtLwzY0jztDNaZmctycTXb_xwV9ZA@mail.gmail.com>
Hi Simon,
> -----Original Message-----
> From: Simon Glass <sjg@chromium.org>
> Sent: Sunday, April 26, 2020 12:46 PM
> To: Park, Aiden <aiden.park@intel.com>
> Cc: Bin Meng <bmeng.cn@gmail.com>; U-Boot Mailing List <u-
> boot at lists.denx.de>
> Subject: Re: [PATCH 6/8] x86: Fix 64-bit compile warning
>
> Hi Aiden,
>
> On Tue, 21 Apr 2020 at 18:45, <aiden.park@intel.com> wrote:
> >
> > From: Aiden Park <aiden.park@intel.com>
> >
> > This is to fix pointer type cast warning in hob command.
> >
> > Signed-off-by: Aiden Park <aiden.park@intel.com>
> > ---
> > cmd/x86/hob.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/cmd/x86/hob.c b/cmd/x86/hob.c index
> > 3967a7ca5a..8c2c1ffc63 100644
> > --- a/cmd/x86/hob.c
> > +++ b/cmd/x86/hob.c
> > @@ -36,14 +36,14 @@ static int do_hob(cmd_tbl_t *cmdtp, int flag, int
> > argc, char * const argv[])
> >
> > hdr = gd->arch.hob_list;
> >
> > - printf("HOB list address: 0x%08x\n\n", (unsigned int)hdr);
> > + printf("HOB list address: 0x%p\n\n", hdr);
>
> That 0x should not be there as hex is assumed in U-Boot.
Thanks. Let me remove the 0x prefix.
>
> Do we actually need a 64-bit pointer here, or will the HOB be below 4GB? I'm
> really not a fan of 16-character addresses in a user command.
Currently, HOB is always below 4GB. This was just in case for 64-bit address space.
Let me assume HOB < 4GB for now.
>
> >
> > - printf("# | Address | Type | Len | ");
> > + printf("# | Address | Type | Len | ");
> > printf("%36s\n", "GUID");
> > - printf("---|----------|-----------|------|-");
> > + printf("---|------------------|-----------|------|-");
> > printf("------------------------------------\n");
> > while (!end_of_hob(hdr)) {
> > - printf("%02x | %08x | ", i, (unsigned int)hdr);
> > + printf("%02x | %p | ", i, hdr);
> > type = hdr->type;
> > if (type == HOB_TYPE_UNUSED)
> > desc = "*Unused*";
> > --
> > 2.20.1
> >
>
> Regards,
> Simon
Best Regards,
Aiden
next prev parent reply other threads:[~2020-04-29 6:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 0:44 [PATCH 0/8] Support 64-bit U-Boot for Slim Bootloader aiden.park at intel.com
2020-04-22 0:45 ` [PATCH 1/8] x86: Add a new X86_RUN_64BIT_ONLY to Kconfig aiden.park at intel.com
2020-04-26 20:15 ` Simon Glass
2020-04-29 5:44 ` Park, Aiden
2020-04-30 9:13 ` Bin Meng
2020-05-01 18:36 ` Park, Aiden
2020-05-03 2:26 ` Simon Glass
2020-04-22 0:45 ` [PATCH 2/8] x86: start64: Add a hook at 64-bit entry aiden.park at intel.com
2020-04-26 20:15 ` Simon Glass
2020-04-29 5:48 ` Park, Aiden
2020-04-22 0:45 ` [PATCH 3/8] x86: start64: Support HOB in 64-bit U-Boot aiden.park at intel.com
2020-04-26 20:15 ` Simon Glass
2020-04-29 5:57 ` Park, Aiden
2020-04-22 0:45 ` [PATCH 4/8] x86: slimbootloader: Support 64-bit operation aiden.park at intel.com
2020-04-26 20:15 ` Simon Glass
2020-04-29 6:01 ` Park, Aiden
2020-04-29 18:03 ` Simon Glass
2020-05-01 18:34 ` Park, Aiden
2020-04-22 0:45 ` [PATCH 5/8] configs: slimbootloader: Add x86_64 slimbootloader config aiden.park at intel.com
2020-04-26 20:32 ` Simon Glass
2020-04-29 6:02 ` Park, Aiden
2020-04-30 9:13 ` Bin Meng
2020-04-22 0:45 ` [PATCH 6/8] x86: Fix 64-bit compile warning aiden.park at intel.com
2020-04-26 19:45 ` Simon Glass
2020-04-29 6:08 ` Park, Aiden [this message]
2020-04-22 0:45 ` [PATCH 7/8] x86: enable 64-bit kernel boot from 64-bit U-Boot aiden.park at intel.com
2020-04-26 20:15 ` Simon Glass
2020-04-29 6:17 ` Park, Aiden
2020-04-22 0:45 ` [PATCH 8/8] doc: slimbootloader: Update 64-bit build instruction aiden.park at intel.com
2020-04-30 9:13 ` Bin Meng
2020-04-26 20:15 ` [PATCH 0/8] Support 64-bit U-Boot for Slim Bootloader Simon Glass
2020-04-29 5:41 ` Park, Aiden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB2048C73981D7559D126148078EAD0@MWHPR11MB2048.namprd11.prod.outlook.com \
--to=aiden.park@intel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.