Re: [PATCH 6/6 v3] ASoC: AMD: Add machine driver for cz rt5650

From: "Agrawal, Akshu" <Akshu.Agrawal@amd.com>
To: Mark Brown <broonie@kernel.org>, Alex Deucher <alexdeucher@gmail.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"rajeevkumar.linux@gmail.com" <rajeevkumar.linux@gmail.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	"Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"perex@perex.cz" <perex@perex.cz>
Subject: Re: [PATCH 6/6 v3] ASoC: AMD: Add machine driver for cz rt5650
Date: Fri, 1 Sep 2017 11:08:14 +0000	[thread overview]
Message-ID: <MWHPR1201MB019226E9EDE45E14FFE2746CF8920@MWHPR1201MB0192.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20170831113802.x75watdrylvjivkl@sirena.org.uk>

On 8/31/2017 5:08 PM, Mark Brown wrote:
> On Fri, Aug 18, 2017 at 02:10:30PM -0400, Alex Deucher wrote:
> 
>> +++ b/sound/soc/amd/Kconfig
>> @@ -2,3 +2,10 @@ config SND_SOC_AMD_ACP
>>   	tristate "AMD Audio Coprocessor support"
>>   	help
>>   	 This option enables ACP DMA support on AMD platform.
>> +config SND_SOC_AMD_CZ_RT5645_MACH
>> +	tristate "AMD CZ support for RT5645"
> 
> Missing blank line between the stanzas.

Done. Will push the change in next revision.

> 
>> +	select SND_SOC_RT5645
>> +	select SND_SOC_AMD_ACP
>> +	depends on I2C_DESIGNWARE_PLATFORM
> 
> No system dependencies of any kind?  Looking at this I'd expect at least
> CONFIG_ACPI || COMPILE_TEST.  It's also unclear to me how the DesignWare
> device is going to be instantiated here or if that should be a direct
> depenency at all here.
>

Added I2C for system dependency and removed 
I2C_DESIGNWARE_PLATFORM as dependency

>> +	ret = snd_soc_register_card(card);
> 
> devm_snd_soc_register_card() and then you don't need the remove
> function.
>

Done.

>> +static const struct acpi_device_id cz_audio_acpi_match[] = {
>> +	{ "AMDI1002", 0 },
>> +	{},
>> +};
>> +
> 
> Missing MODULE_DEVICE_TABLE().
>

Done.

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel