* [PATCH] drm/amdgpu: Fix memory trashing if UVD ring test fails
@ 2016-08-03 18:39 Jay Cornwall
[not found] ` <20160803183942.5223-1-jay-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Jay Cornwall @ 2016-08-03 18:39 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: Jay Cornwall, felix.kuehling-5C7GfCeVMHo
fence_put was called on an uninitialized variable.
Signed-off-by: Jay Cornwall <jay@jcornwall.me>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
index b11f4e8..4aa993d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
@@ -1187,7 +1187,8 @@ int amdgpu_uvd_ring_test_ib(struct amdgpu_ring *ring, long timeout)
r = 0;
}
-error:
fence_put(fence);
+
+error:
return r;
}
--
2.9.2
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdgpu: Fix memory trashing if UVD ring test fails
[not found] ` <20160803183942.5223-1-jay-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org>
@ 2016-08-03 19:05 ` Christian König
2016-08-10 16:10 ` Alex Deucher
1 sibling, 0 replies; 5+ messages in thread
From: Christian König @ 2016-08-03 19:05 UTC (permalink / raw)
To: Jay Cornwall, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: felix.kuehling-5C7GfCeVMHo
Am 03.08.2016 um 20:39 schrieb Jay Cornwall:
> fence_put was called on an uninitialized variable.
>
> Signed-off-by: Jay Cornwall <jay@jcornwall.me>
Good catch, patch is Reviewed-by: Christian König <christian.koenig@amd.com>
Regards,
Christian.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> index b11f4e8..4aa993d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> @@ -1187,7 +1187,8 @@ int amdgpu_uvd_ring_test_ib(struct amdgpu_ring *ring, long timeout)
> r = 0;
> }
>
> -error:
> fence_put(fence);
> +
> +error:
> return r;
> }
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdgpu: Fix memory trashing if UVD ring test fails
[not found] ` <20160803183942.5223-1-jay-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org>
2016-08-03 19:05 ` Christian König
@ 2016-08-10 16:10 ` Alex Deucher
[not found] ` <CADnq5_M6GO_=TNkOvnoP-2sUe+SK8Y8Za+FrY3+z=7Xc7fOQRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
1 sibling, 1 reply; 5+ messages in thread
From: Alex Deucher @ 2016-08-10 16:10 UTC (permalink / raw)
To: Jay Cornwall; +Cc: Felix Kuehling, amd-gfx list
On Wed, Aug 3, 2016 at 2:39 PM, Jay Cornwall <jay@jcornwall.me> wrote:
> fence_put was called on an uninitialized variable.
>
> Signed-off-by: Jay Cornwall <jay@jcornwall.me>
Can you commit this internally or do you need one of us to?
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> index b11f4e8..4aa993d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> @@ -1187,7 +1187,8 @@ int amdgpu_uvd_ring_test_ib(struct amdgpu_ring *ring, long timeout)
> r = 0;
> }
>
> -error:
> fence_put(fence);
> +
> +error:
> return r;
> }
> --
> 2.9.2
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdgpu: Fix memory trashing if UVD ring test fails
[not found] ` <CADnq5_M6GO_=TNkOvnoP-2sUe+SK8Y8Za+FrY3+z=7Xc7fOQRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2016-08-10 16:49 ` Jay Cornwall
[not found] ` <b89701da636205926be55f2bf0896190-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Jay Cornwall @ 2016-08-10 16:49 UTC (permalink / raw)
To: Alex Deucher; +Cc: Felix Kuehling, amd-gfx list
On 2016-08-10 11:10, Alex Deucher wrote:
> On Wed, Aug 3, 2016 at 2:39 PM, Jay Cornwall <jay@jcornwall.me> wrote:
>> fence_put was called on an uninitialized variable.
>>
>> Signed-off-by: Jay Cornwall <jay@jcornwall.me>
>
> Can you commit this internally or do you need one of us to?
>
> Alex
I'm less familiar with the amdgpu branches. You could point me to the
right one or commit this from your side.
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> index b11f4e8..4aa993d 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
>> @@ -1187,7 +1187,8 @@ int amdgpu_uvd_ring_test_ib(struct amdgpu_ring
>> *ring, long timeout)
>> r = 0;
>> }
>>
>> -error:
>> fence_put(fence);
>> +
>> +error:
>> return r;
>> }
>> --
>> 2.9.2
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
--
Jay Cornwall
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] drm/amdgpu: Fix memory trashing if UVD ring test fails
[not found] ` <b89701da636205926be55f2bf0896190-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org>
@ 2016-08-10 17:27 ` Deucher, Alexander
0 siblings, 0 replies; 5+ messages in thread
From: Deucher, Alexander @ 2016-08-10 17:27 UTC (permalink / raw)
To: 'Jay Cornwall', Alex Deucher; +Cc: Kuehling, Felix, amd-gfx list
> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Jay Cornwall
> Sent: Wednesday, August 10, 2016 12:49 PM
> To: Alex Deucher
> Cc: Kuehling, Felix; amd-gfx list
> Subject: Re: [PATCH] drm/amdgpu: Fix memory trashing if UVD ring test fails
>
> On 2016-08-10 11:10, Alex Deucher wrote:
> > On Wed, Aug 3, 2016 at 2:39 PM, Jay Cornwall <jay@jcornwall.me> wrote:
> >> fence_put was called on an uninitialized variable.
> >>
> >> Signed-off-by: Jay Cornwall <jay@jcornwall.me>
> >
> > Can you commit this internally or do you need one of us to?
> >
> > Alex
>
> I'm less familiar with the amdgpu branches. You could point me to the
> right one or commit this from your side.
amd-staging-4.6
I'll commit this unless you beat me to it.
Alex
>
> >> ---
> >> drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> >> index b11f4e8..4aa993d 100644
> >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c
> >> @@ -1187,7 +1187,8 @@ int amdgpu_uvd_ring_test_ib(struct
> amdgpu_ring
> >> *ring, long timeout)
> >> r = 0;
> >> }
> >>
> >> -error:
> >> fence_put(fence);
> >> +
> >> +error:
> >> return r;
> >> }
> >> --
> >> 2.9.2
> >>
> >> _______________________________________________
> >> amd-gfx mailing list
> >> amd-gfx@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
> --
> Jay Cornwall
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-08-10 17:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-03 18:39 [PATCH] drm/amdgpu: Fix memory trashing if UVD ring test fails Jay Cornwall
[not found] ` <20160803183942.5223-1-jay-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org>
2016-08-03 19:05 ` Christian König
2016-08-10 16:10 ` Alex Deucher
[not found] ` <CADnq5_M6GO_=TNkOvnoP-2sUe+SK8Y8Za+FrY3+z=7Xc7fOQRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-10 16:49 ` Jay Cornwall
[not found] ` <b89701da636205926be55f2bf0896190-gJmSnxjMpeIFV7jr3Ov9Ew@public.gmane.org>
2016-08-10 17:27 ` Deucher, Alexander
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.