* [PATCH v3] drivers: hv: Fix whitespace errors
@ 2021-02-19 17:13 Vasanth
2021-02-19 17:30 ` Michael Kelley
0 siblings, 1 reply; 3+ messages in thread
From: Vasanth @ 2021-02-19 17:13 UTC (permalink / raw)
To: kys; +Cc: haiyangz, sthemmin, wei.liu, linux-hyperv, linux-kernel, Vasanth
Fixed checkpatch warning and errors on hv driver.
Signed-off-by: Vasanth <vasanth3g@gmail.com>
---
changes in v2:
* Added commit message
* Revised Subject
drivers/hv/channel.c | 2 +-
drivers/hv/connection.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index 6fb0c76bfbf8..587234065e37 100644
--- a/drivers/hv/channel.c
+++ b/drivers/hv/channel.c
@@ -385,7 +385,7 @@ static int create_gpadl_header(enum hv_gpadl_type type, void *kbuffer,
* @kbuffer: from kmalloc or vmalloc
* @size: page-size multiple
* @send_offset: the offset (in bytes) where the send ring buffer starts,
- * should be 0 for BUFFER type gpadl
+ * should be 0 for BUFFER type gpadl
* @gpadl_handle: some funky thing
*/
static int __vmbus_establish_gpadl(struct vmbus_channel *channel,
diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c
index 11170d9a2e1a..3760cbb6ffaf 100644
--- a/drivers/hv/connection.c
+++ b/drivers/hv/connection.c
@@ -28,7 +28,7 @@ struct vmbus_connection vmbus_connection = {
.conn_state = DISCONNECTED,
.next_gpadl_handle = ATOMIC_INIT(0xE1E10),
- .ready_for_suspend_event= COMPLETION_INITIALIZER(
+ .ready_for_suspend_event = COMPLETION_INITIALIZER(
vmbus_connection.ready_for_suspend_event),
.ready_for_resume_event = COMPLETION_INITIALIZER(
vmbus_connection.ready_for_resume_event),
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH v3] drivers: hv: Fix whitespace errors
2021-02-19 17:13 [PATCH v3] drivers: hv: Fix whitespace errors Vasanth
@ 2021-02-19 17:30 ` Michael Kelley
2021-03-02 19:06 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Michael Kelley @ 2021-02-19 17:30 UTC (permalink / raw)
To: Vasanth, KY Srinivasan
Cc: Haiyang Zhang, Stephen Hemminger, wei.liu, linux-hyperv, linux-kernel
From: Vasanth <vasanth3g@gmail.com> Sent: Friday, February 19, 2021 9:13 AM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>; Stephen Hemminger
> <sthemmin@microsoft.com>; wei.liu@kernel.org; linux-hyperv@vger.kernel.org; linux-
> kernel@vger.kernel.org; Vasanth <vasanth3g@gmail.com>
> Subject: [PATCH v3] drivers: hv: Fix whitespace errors
>
> Fixed checkpatch warning and errors on hv driver.
>
> Signed-off-by: Vasanth <vasanth3g@gmail.com>
> ---
>
> changes in v2:
> * Added commit message
> * Revised Subject
>
> drivers/hv/channel.c | 2 +-
> drivers/hv/connection.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
> index 6fb0c76bfbf8..587234065e37 100644
> --- a/drivers/hv/channel.c
> +++ b/drivers/hv/channel.c
> @@ -385,7 +385,7 @@ static int create_gpadl_header(enum hv_gpadl_type type, void
> *kbuffer,
> * @kbuffer: from kmalloc or vmalloc
> * @size: page-size multiple
> * @send_offset: the offset (in bytes) where the send ring buffer starts,
> - * should be 0 for BUFFER type gpadl
> + * should be 0 for BUFFER type gpadl
> * @gpadl_handle: some funky thing
> */
> static int __vmbus_establish_gpadl(struct vmbus_channel *channel,
> diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c
> index 11170d9a2e1a..3760cbb6ffaf 100644
> --- a/drivers/hv/connection.c
> +++ b/drivers/hv/connection.c
> @@ -28,7 +28,7 @@ struct vmbus_connection vmbus_connection = {
> .conn_state = DISCONNECTED,
> .next_gpadl_handle = ATOMIC_INIT(0xE1E10),
>
> - .ready_for_suspend_event= COMPLETION_INITIALIZER(
> + .ready_for_suspend_event = COMPLETION_INITIALIZER(
> vmbus_connection.ready_for_suspend_event),
> .ready_for_resume_event = COMPLETION_INITIALIZER(
> vmbus_connection.ready_for_resume_event),
> --
> 2.25.1
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] drivers: hv: Fix whitespace errors
2021-02-19 17:30 ` Michael Kelley
@ 2021-03-02 19:06 ` Wei Liu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2021-03-02 19:06 UTC (permalink / raw)
To: Michael Kelley
Cc: Vasanth, KY Srinivasan, Haiyang Zhang, Stephen Hemminger,
wei.liu, linux-hyperv, linux-kernel
On Fri, Feb 19, 2021 at 05:30:36PM +0000, Michael Kelley wrote:
> From: Vasanth <vasanth3g@gmail.com> Sent: Friday, February 19, 2021 9:13 AM
> > To: KY Srinivasan <kys@microsoft.com>
> > Cc: Haiyang Zhang <haiyangz@microsoft.com>; Stephen Hemminger
> > <sthemmin@microsoft.com>; wei.liu@kernel.org; linux-hyperv@vger.kernel.org; linux-
> > kernel@vger.kernel.org; Vasanth <vasanth3g@gmail.com>
> > Subject: [PATCH v3] drivers: hv: Fix whitespace errors
> >
> > Fixed checkpatch warning and errors on hv driver.
> >
> > Signed-off-by: Vasanth <vasanth3g@gmail.com>
Vasanth, normally people put their full name in the SoB. Do you want to
do that too?
There is no need to resend. Just let me know what you think.
> > ---
>
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Thanks Michael.
I will pick up this patch within this week.
Wei.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-02 22:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-19 17:13 [PATCH v3] drivers: hv: Fix whitespace errors Vasanth
2021-02-19 17:30 ` Michael Kelley
2021-03-02 19:06 ` Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.