All of lore.kernel.org
 help / color / mirror / Atom feed
From: j.nixdorf@avm.de <j.nixdorf@avm.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] netstress: explicitly set a thread stack size
Date: Fri, 27 Nov 2020 11:58:57 +0100	[thread overview]
Message-ID: <OF67F47D3A.085506A0-ONC125862D.003BE9A0-C125862D.003C5457@avm.de> (raw)
In-Reply-To: <9c761b66-89c6-9121-88bb-44e98b9a64cb@oracle.com>

-----"Alexey Kodanev" <alexey.kodanev@oracle.com> wrote: -----
>On 26.11.2020 17:52, Johannes Nixdorf via ltp wrote:
>It doesn't mean you should intentionally pass unaligned size.
>
>And on it's man-page [1], in errors section, there is a note that it
>might
>return EINVAL for some systems if the stack size not multiple of page
>size.

Ok. I was going by the POSIX man page [1], which doesn't mention
that practice.

[1]: https://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_attr_setstacksize.html

>max_msg_len is const.

It seems like I was misreading [2] to mean it sets max_msg_len
instead of using it as a limit.

[2]: https://github.com/linux-test-project/ltp/blob/master/testcases/network/netstress/netstress.c#L854

Thanks for the review, I'll change it to go with your proposed
static limit.

Regards,
Johannes

  parent reply	other threads:[~2020-11-27 10:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 13:06 [LTP] [PATCH] netstress: explicitly set a thread stack size j.nixdorf
2020-11-26 14:05 ` Alexey Kodanev
2020-11-26 14:52 ` j.nixdorf
2020-11-26 15:03   ` Cyril Hrubis
2020-11-27  9:15     ` Alexey Kodanev
2020-11-27 11:28       ` Cyril Hrubis
2020-11-27  8:54   ` Alexey Kodanev
2020-11-27 10:58   ` j.nixdorf [this message]
2020-11-27 11:38 ` [LTP] [PATCH v2] " j.nixdorf
2020-12-01 12:01   ` Alexey Kodanev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OF67F47D3A.085506A0-ONC125862D.003BE9A0-C125862D.003C5457@avm.de \
    --to=j.nixdorf@avm.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.