All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
To: u-boot@lists.denx.de
Subject: Antwort: Re: [PATCH v7 1/9] acpi: Add a binding for ACPI settings in the device tree
Date: Tue, 21 Apr 2020 15:07:01 +0200	[thread overview]
Message-ID: <OF9CA7B296.E91F965B-ONC1258551.0046018D-C1258551.00480DF3@br-automation.com> (raw)
In-Reply-To: <CAEUhbmXFQTEYK-binFPtmuwUBj-zqp7ixEfHCt5DBeJzxVSgHw@mail.gmail.com>

Hi Bin,

-----"Bin Meng" <bmeng.cn@gmail.com> schrieb: -----

>Betreff: Re: [PATCH v7 1/9] acpi: Add a binding for ACPI settings in
>the device tree
>
>Hi Wolfgang, Andy,
>
>On Mon, Apr 20, 2020 at 4:37 AM Simon Glass <sjg@chromium.org> wrote:
>>
>> Devices need to report various identifiers in the ACPI tables.
>Rather than
>> hard-coding these in drivers it is typically better to put them in
>the
>> device tree.
>>
>> Add a binding file to describe this.
>>
>> Signed-off-by: Simon Glass <sjg@chromium.org>
>> ---
>>
>
>Do you have any comments against this patch?

I'm fine with the patch as it is.

However, two remarks:

 1) I proposed some rewording in [1].
    I'm fine with dropping it, I just point it out to make sure
    that it is deliberately dropped and no just overseen.

 2) In [2] Andy stated that "acpi,compatible" can't work.
    @Andy: did I get this wrong? Is it still fine to add it in
    the binding?

regards, Wolfgang

[1] https://lists.denx.de/pipermail/u-boot/2020-April/406818.html
[2] https://lists.denx.de/pipermail/u-boot/2020-April/406943.html

  parent reply	other threads:[~2020-04-21 13:07 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-19 20:36 [PATCH v7 0/9] dm: Add programmatic generation of ACPI tables (part A) Simon Glass
2020-04-19 20:36 ` [PATCH v7 1/9] acpi: Add a binding for ACPI settings in the device tree Simon Glass
2020-04-21 12:25   ` Bin Meng
2020-04-21 12:29     ` Andy Shevchenko
2020-04-21 13:07   ` Wolfgang Wallner [this message]
2020-04-21 14:40     ` Andy Shevchenko
2020-04-21 14:56     ` Antwort: Re: " Wolfgang Wallner
2020-04-19 20:36 ` [PATCH v7 2/9] acpi: Add a method to write tables for a device Simon Glass
2020-04-19 20:36 ` [PATCH v7 3/9] acpi: Convert part of acpi_table to use acpi_ctx Simon Glass
2020-04-19 20:36 ` [PATCH v7 4/9] x86: Allow devices to write ACPI tables Simon Glass
2020-04-19 20:36 ` [PATCH v7 5/9] acpi: Drop code for missing XSDT from acpi_write_rsdp() Simon Glass
2020-04-19 20:36 ` [PATCH v7 6/9] acpi: Move acpi_add_table() to generic code Simon Glass
2020-04-19 20:36 ` [PATCH v7 7/9] acpi: Put table-setup code in its own function Simon Glass
2020-04-23  9:38   ` Bin Meng
2020-04-26 19:45     ` Simon Glass
2020-04-27  6:36     ` Antwort: " Wolfgang Wallner
2020-04-27  7:10       ` Bin Meng
2020-04-19 20:36 ` [PATCH v7 8/9] acpi: Move the xsdt pointer to acpi_ctx Simon Glass
2020-04-19 20:36 ` [PATCH v7 9/9] acpi: Add an acpi command Simon Glass
2020-04-21 17:42 ` [PATCH v7 0/9] dm: Add programmatic generation of ACPI tables (part A) Andy Shevchenko
2020-04-21 21:37   ` Simon Glass
2020-04-23  9:46     ` Bin Meng
2020-04-23  9:58       ` Bin Meng
2020-04-27  5:58         ` Bin Meng
2020-04-27 17:02           ` Simon Glass
2020-04-29 18:09 ` Heinrich Schuchardt
2020-05-01 13:14   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OF9CA7B296.E91F965B-ONC1258551.0046018D-C1258551.00480DF3@br-automation.com \
    --to=wolfgang.wallner@br-automation.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.