[PATCH for-rc] RDMA/siw: Fix setting active_mtu attribute

[PATCH for-rc] RDMA/siw: Fix setting active_mtu attribute

[Kamal Heib]

Make sure to set the active_mtu attribute to avoid report the following
invalid value:

$ ibv_devinfo -d siw0 | grep active_mtu
			active_mtu:		invalid MTU (0)

Fixes: 303ae1cdfdf7 ("rdma/siw: application interface")
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
---
 drivers/infiniband/sw/siw/siw_verbs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/sw/siw/siw_verbs.c b/drivers/infiniband/sw/siw/siw_verbs.c
index 07e30138aaa1..73485d0da907 100644
--- a/drivers/infiniband/sw/siw/siw_verbs.c
+++ b/drivers/infiniband/sw/siw/siw_verbs.c
@@ -168,12 +168,12 @@ int siw_query_port(struct ib_device *base_dev, u8 port,
 
 	memset(attr, 0, sizeof(*attr));
 
-	attr->active_mtu = attr->max_mtu;
 	attr->active_speed = 2;
 	attr->active_width = 2;
 	attr->gid_tbl_len = 1;
 	attr->max_msg_sz = -1;
 	attr->max_mtu = ib_mtu_int_to_enum(sdev->netdev->mtu);
+	attr->active_mtu = ib_mtu_int_to_enum(sdev->netdev->mtu);
 	attr->phys_state = sdev->state == IB_PORT_ACTIVE ?
 		IB_PORT_PHYS_STATE_LINK_UP : IB_PORT_PHYS_STATE_DISABLED;
 	attr->pkey_tbl_len = 1;
-- 
2.21.1

Re: [PATCH for-rc] RDMA/siw: Fix setting active_mtu attribute

[Gal Pressman]

On 05/02/2020 10:13, Kamal Heib wrote:
> Make sure to set the active_mtu attribute to avoid report the following
> invalid value:
> 
> $ ibv_devinfo -d siw0 | grep active_mtu
> 			active_mtu:		invalid MTU (0)
> 
> Fixes: 303ae1cdfdf7 ("rdma/siw: application interface")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
>  drivers/infiniband/sw/siw/siw_verbs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/sw/siw/siw_verbs.c b/drivers/infiniband/sw/siw/siw_verbs.c
> index 07e30138aaa1..73485d0da907 100644
> --- a/drivers/infiniband/sw/siw/siw_verbs.c
> +++ b/drivers/infiniband/sw/siw/siw_verbs.c
> @@ -168,12 +168,12 @@ int siw_query_port(struct ib_device *base_dev, u8 port,
>  
>  	memset(attr, 0, sizeof(*attr));
>  
> -	attr->active_mtu = attr->max_mtu;
>  	attr->active_speed = 2;
>  	attr->active_width = 2;

Off topic: these should use ib_port_speed and ib_port_width enum.

>  	attr->gid_tbl_len = 1;
>  	attr->max_msg_sz = -1;
>  	attr->max_mtu = ib_mtu_int_to_enum(sdev->netdev->mtu);
> +	attr->active_mtu = ib_mtu_int_to_enum(sdev->netdev->mtu);
>  	attr->phys_state = sdev->state == IB_PORT_ACTIVE ?
>  		IB_PORT_PHYS_STATE_LINK_UP : IB_PORT_PHYS_STATE_DISABLED;
>  	attr->pkey_tbl_len = 1;
> 

Reviewed-by: Gal Pressman <galpress@amazon.com>

Re: [PATCH for-rc] RDMA/siw: Fix setting active_mtu attribute

[Bernard Metzler]

-----"Kamal Heib" <kamalheib1@gmail.com> wrote: -----

>To: linux-rdma@vger.kernel.org
>From: "Kamal Heib" <kamalheib1@gmail.com>
>Date: 02/05/2020 09:14AM
>Cc: "Doug Ledford" <dledford@redhat.com>, "Jason Gunthorpe"
><jgg@ziepe.ca>, "Bernard Metzler" <bmt@zurich.ibm.com>, "Kamal Heib"
><kamalheib1@gmail.com>
>Subject: [EXTERNAL] [PATCH for-rc] RDMA/siw: Fix setting active_mtu
>attribute
>
>Make sure to set the active_mtu attribute to avoid report the
>following
>invalid value:
>
>$ ibv_devinfo -d siw0 | grep active_mtu
>			active_mtu:		invalid MTU (0)
>
>Fixes: 303ae1cdfdf7 ("rdma/siw: application interface")
>Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
>---
> drivers/infiniband/sw/siw/siw_verbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/infiniband/sw/siw/siw_verbs.c
>b/drivers/infiniband/sw/siw/siw_verbs.c
>index 07e30138aaa1..73485d0da907 100644
>--- a/drivers/infiniband/sw/siw/siw_verbs.c
>+++ b/drivers/infiniband/sw/siw/siw_verbs.c
>@@ -168,12 +168,12 @@ int siw_query_port(struct ib_device *base_dev,
>u8 port,
> 
> 	memset(attr, 0, sizeof(*attr));
> 
>-	attr->active_mtu = attr->max_mtu;
> 	attr->active_speed = 2;
> 	attr->active_width = 2;
> 	attr->gid_tbl_len = 1;
> 	attr->max_msg_sz = -1;
> 	attr->max_mtu = ib_mtu_int_to_enum(sdev->netdev->mtu);
>+	attr->active_mtu = ib_mtu_int_to_enum(sdev->netdev->mtu);
> 	attr->phys_state = sdev->state == IB_PORT_ACTIVE ?
> 		IB_PORT_PHYS_STATE_LINK_UP : IB_PORT_PHYS_STATE_DISABLED;
> 	attr->pkey_tbl_len = 1;
>-- 
>2.21.1
>
>

thanks, makes complete sense.

Reviewed-by: Bernard Metzler <bmt@zurich.ibm.com>

Re: [PATCH for-rc] RDMA/siw: Fix setting active_mtu attribute

[Jason Gunthorpe]

On Wed, Feb 05, 2020 at 10:13:54AM +0200, Kamal Heib wrote:
> Make sure to set the active_mtu attribute to avoid report the following
> invalid value:
> 
> $ ibv_devinfo -d siw0 | grep active_mtu
> 			active_mtu:		invalid MTU (0)
> 
> Fixes: 303ae1cdfdf7 ("rdma/siw: application interface")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> Reviewed-by: Gal Pressman <galpress@amazon.com>
> Reviewed-by: Bernard Metzler <bmt@zurich.ibm.com>
> ---
>  drivers/infiniband/sw/siw/siw_verbs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This isn't really rc worthy as it has always been broken

Applied to for-next, thanks

Jason