* [PATCH v2] net/ixgbe/base: clear redundant macro define
@ 2016-12-21 2:03 Chenghu Yao
2017-02-03 2:37 ` Lu, Wenzhuo
0 siblings, 1 reply; 3+ messages in thread
From: Chenghu Yao @ 2016-12-21 2:03 UTC (permalink / raw)
To: wenzhuo.lu, helin.zhang; +Cc: dev, Chenghu Yao
In head file "ixgbe_mbx.h", macro define IXGBE_VF_API_NEGOTIATE and
IXGBE_VF_GET_QUEUES appear two times with the same name, value,
and notes.
Version 2.0 VF requests can inherit the two macro defines
in previous version 1.0 and 1.1. Otherwise, maybe cause confusion.
Signed-off-by: Chenghu Yao <yao.chenghu@zte.com.cn>
---
v2:
* eliminate commit warning
---
drivers/net/ixgbe/base/ixgbe_mbx.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ixgbe/base/ixgbe_mbx.h b/drivers/net/ixgbe/base/ixgbe_mbx.h
index 7556a81..483e9b3 100644
--- a/drivers/net/ixgbe/base/ixgbe_mbx.h
+++ b/drivers/net/ixgbe/base/ixgbe_mbx.h
@@ -128,8 +128,6 @@ enum ixgbe_pfvf_api_rev {
#define IXGBE_PF_CONTROL_MSG 0x0100 /* PF control message */
/* mailbox API, version 2.0 VF requests */
-#define IXGBE_VF_API_NEGOTIATE 0x08 /* negotiate API version */
-#define IXGBE_VF_GET_QUEUES 0x09 /* get queue configuration */
#define IXGBE_VF_ENABLE_MACADDR 0x0A /* enable MAC address */
#define IXGBE_VF_DISABLE_MACADDR 0x0B /* disable MAC address */
#define IXGBE_VF_GET_MACADDRS 0x0C /* get all configured MAC addrs */
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] net/ixgbe/base: clear redundant macro define
2016-12-21 2:03 [PATCH v2] net/ixgbe/base: clear redundant macro define Chenghu Yao
@ 2017-02-03 2:37 ` Lu, Wenzhuo
2017-02-06 10:38 ` 答复: " yao.chenghu
0 siblings, 1 reply; 3+ messages in thread
From: Lu, Wenzhuo @ 2017-02-03 2:37 UTC (permalink / raw)
To: Chenghu Yao, Zhang, Helin; +Cc: dev
Hi Chenghu,
> -----Original Message-----
> From: Chenghu Yao [mailto:yao.chenghu@zte.com.cn]
> Sent: Wednesday, December 21, 2016 10:04 AM
> To: Lu, Wenzhuo; Zhang, Helin
> Cc: dev@dpdk.org; Chenghu Yao
> Subject: [PATCH v2] net/ixgbe/base: clear redundant macro define
>
> In head file "ixgbe_mbx.h", macro define IXGBE_VF_API_NEGOTIATE and
> IXGBE_VF_GET_QUEUES appear two times with the same name, value, and
> notes.
>
> Version 2.0 VF requests can inherit the two macro defines in previous version
> 1.0 and 1.1. Otherwise, maybe cause confusion.
As 1.x is for linux/freebsd, but 2.0 is for solaris, 2.0 doesn't leverage the messages from 1.x. For example, 0x0a has different meaning in 1.x and 2.0. So better letting it be.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-06 10:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-21 2:03 [PATCH v2] net/ixgbe/base: clear redundant macro define Chenghu Yao
2017-02-03 2:37 ` Lu, Wenzhuo
2017-02-06 10:38 ` 答复: " yao.chenghu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.