From: Biju Das <biju.das.jz@bp.renesas.com> To: Geert Uytterhoeven <geert+renesas@glider.be>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, Jonathan Corbet <corbet@lwn.net>, Jyri Sarha <jyri.sarha@iki.fi>, Tomi Valkeinen <tomba@kernel.org>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>, "linux-renesas-soc@vger.kernel.org" <linux-renesas-soc@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH 3/3] drm: Fix references to drm_plane_helper_check_state() Date: Fri, 2 Jun 2023 10:16:50 +0000 [thread overview] Message-ID: <OS0PR01MB59225B787D7F3B179840CA6A864EA@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <2408d7841c91e98e9a2b24b1b4df9b2b865519a6.1685696114.git.geert+renesas@glider.be> Hi Geert, Thanks for the feedback. > Subject: [PATCH 3/3] drm: Fix references to > drm_plane_helper_check_state() > > As of commit a01cb8ba3f628293 ("drm: Move drm_plane_helper_check_state() > into drm_atomic_helper.c"), drm_plane_helper_check_state() no longer > exists, but is part of drm_atomic_helper_check_plane_state(). > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Interestingly, all these comments appeared only after the commit that > removed the function... > > This is against next-20230602, which does not have the drivers/gpu/drm/{ > => renesas}/rcar-du move yet. > > Biju: you're adding a new copy in > drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c OK, will update the comment in __rzg2l_du_vsp_plane_atomic_check() as it is moved to drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.c based on Laurent's review comment. Cheers, Biju > --- > drivers/gpu/drm/rcar-du/rcar_du_plane.c | 3 ++- > drivers/gpu/drm/tidss/tidss_plane.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c > b/drivers/gpu/drm/rcar-du/rcar_du_plane.c > index d759e019218181ce..e445fac8e0b46c21 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c > @@ -600,7 +600,8 @@ int __rcar_du_plane_atomic_check(struct drm_plane > *plane, > if (!state->crtc) { > /* > * The visible field is not reset by the DRM core but only > - * updated by drm_plane_helper_check_state(), set it > manually. > + * updated by drm_atomic_helper_check_plane_state(), set it > + * manually. > */ > state->visible = false; > *format = NULL; > diff --git a/drivers/gpu/drm/tidss/tidss_plane.c > b/drivers/gpu/drm/tidss/tidss_plane.c > index 6bdd6e4a955ab3cc..e1c0ef0c3894c855 100644 > --- a/drivers/gpu/drm/tidss/tidss_plane.c > +++ b/drivers/gpu/drm/tidss/tidss_plane.c > @@ -38,7 +38,8 @@ static int tidss_plane_atomic_check(struct drm_plane > *plane, > if (!new_plane_state->crtc) { > /* > * The visible field is not reset by the DRM core but only > - * updated by drm_plane_helper_check_state(), set it > manually. > + * updated by drm_atomic_helper_check_plane_state(), set it > + * manually. > */ > new_plane_state->visible = false; > return 0; > -- > 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Biju Das <biju.das.jz@bp.renesas.com> To: Geert Uytterhoeven <geert+renesas@glider.be>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, Jonathan Corbet <corbet@lwn.net>, Jyri Sarha <jyri.sarha@iki.fi>, Tomi Valkeinen <tomba@kernel.org>, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Cc: "linux-renesas-soc@vger.kernel.org" <linux-renesas-soc@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org> Subject: RE: [PATCH 3/3] drm: Fix references to drm_plane_helper_check_state() Date: Fri, 2 Jun 2023 10:16:50 +0000 [thread overview] Message-ID: <OS0PR01MB59225B787D7F3B179840CA6A864EA@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <2408d7841c91e98e9a2b24b1b4df9b2b865519a6.1685696114.git.geert+renesas@glider.be> Hi Geert, Thanks for the feedback. > Subject: [PATCH 3/3] drm: Fix references to > drm_plane_helper_check_state() > > As of commit a01cb8ba3f628293 ("drm: Move drm_plane_helper_check_state() > into drm_atomic_helper.c"), drm_plane_helper_check_state() no longer > exists, but is part of drm_atomic_helper_check_plane_state(). > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > Interestingly, all these comments appeared only after the commit that > removed the function... > > This is against next-20230602, which does not have the drivers/gpu/drm/{ > => renesas}/rcar-du move yet. > > Biju: you're adding a new copy in > drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c OK, will update the comment in __rzg2l_du_vsp_plane_atomic_check() as it is moved to drivers/gpu/drm/renesas/rz-du/rzg2l_du_vsp.c based on Laurent's review comment. Cheers, Biju > --- > drivers/gpu/drm/rcar-du/rcar_du_plane.c | 3 ++- > drivers/gpu/drm/tidss/tidss_plane.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c > b/drivers/gpu/drm/rcar-du/rcar_du_plane.c > index d759e019218181ce..e445fac8e0b46c21 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c > @@ -600,7 +600,8 @@ int __rcar_du_plane_atomic_check(struct drm_plane > *plane, > if (!state->crtc) { > /* > * The visible field is not reset by the DRM core but only > - * updated by drm_plane_helper_check_state(), set it > manually. > + * updated by drm_atomic_helper_check_plane_state(), set it > + * manually. > */ > state->visible = false; > *format = NULL; > diff --git a/drivers/gpu/drm/tidss/tidss_plane.c > b/drivers/gpu/drm/tidss/tidss_plane.c > index 6bdd6e4a955ab3cc..e1c0ef0c3894c855 100644 > --- a/drivers/gpu/drm/tidss/tidss_plane.c > +++ b/drivers/gpu/drm/tidss/tidss_plane.c > @@ -38,7 +38,8 @@ static int tidss_plane_atomic_check(struct drm_plane > *plane, > if (!new_plane_state->crtc) { > /* > * The visible field is not reset by the DRM core but only > - * updated by drm_plane_helper_check_state(), set it > manually. > + * updated by drm_atomic_helper_check_plane_state(), set it > + * manually. > */ > new_plane_state->visible = false; > return 0; > -- > 2.34.1
next prev parent reply other threads:[~2023-06-02 10:17 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-06-02 9:11 [PATCH 0/3] drm: Atomic modesetting doc and comment improvements Geert Uytterhoeven 2023-06-02 9:11 ` Geert Uytterhoeven 2023-06-02 9:11 ` [PATCH 1/3] drm/todo: Add atomic modesetting references Geert Uytterhoeven 2023-06-02 9:11 ` Geert Uytterhoeven 2023-06-02 10:39 ` Javier Martinez Canillas 2023-06-02 10:39 ` Javier Martinez Canillas 2023-06-02 11:23 ` Geert Uytterhoeven 2023-06-02 11:23 ` Geert Uytterhoeven 2023-06-02 10:53 ` Laurent Pinchart 2023-06-02 10:53 ` Laurent Pinchart 2023-06-02 13:32 ` Bagas Sanjaya 2023-06-02 13:32 ` Bagas Sanjaya 2023-06-02 9:11 ` [PATCH 2/3] drm: Remove references to removed transitional helpers Geert Uytterhoeven 2023-06-02 9:11 ` Geert Uytterhoeven 2023-06-02 11:04 ` Laurent Pinchart 2023-06-02 11:04 ` Laurent Pinchart 2023-06-02 11:17 ` Geert Uytterhoeven 2023-06-02 11:17 ` Geert Uytterhoeven 2023-06-02 11:36 ` Laurent Pinchart 2023-06-02 11:36 ` Laurent Pinchart 2023-06-02 11:49 ` Geert Uytterhoeven 2023-06-02 11:49 ` Geert Uytterhoeven 2023-06-09 12:47 ` Geert Uytterhoeven 2023-06-09 12:47 ` Geert Uytterhoeven 2023-06-02 9:11 ` [PATCH 3/3] drm: Fix references to drm_plane_helper_check_state() Geert Uytterhoeven 2023-06-02 9:11 ` Geert Uytterhoeven 2023-06-02 10:16 ` Biju Das [this message] 2023-06-02 10:16 ` Biju Das 2023-06-02 11:06 ` Laurent Pinchart 2023-06-02 11:06 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=OS0PR01MB59225B787D7F3B179840CA6A864EA@OS0PR01MB5922.jpnprd01.prod.outlook.com \ --to=biju.das.jz@bp.renesas.com \ --cc=airlied@gmail.com \ --cc=corbet@lwn.net \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=geert+renesas@glider.be \ --cc=jyri.sarha@iki.fi \ --cc=laurent.pinchart+renesas@ideasonboard.com \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=tomba@kernel.org \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.