From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> To: Biju Das <biju.das@bp.renesas.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>, Felipe Balbi <balbi@kernel.org>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Simon Horman <horms@verge.net.au>, Geert Uytterhoeven <geert+renesas@glider.be>, Chris Paterson <Chris.Paterson2@renesas.com>, Fabrizio Castro <fabrizio.castro@bp.renesas.com>, "linux-renesas-soc@vger.kernel.org" <linux-renesas-soc@vger.kernel.org> Subject: RE: [PATCH v6 2/7] dt-bindings: usb: renesas_usb3: Document usb role switch support Date: Tue, 21 May 2019 08:27:23 +0000 [thread overview] Message-ID: <OSAPR01MB308934C379A9759841E58043D8070@OSAPR01MB3089.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <1557922152-16449-3-git-send-email-biju.das@bp.renesas.com> Hi Biju-san, Thank you for the patch! > From: Biju Das, Sent: Wednesday, May 15, 2019 9:09 PM > > Update the DT bindings documentation to support usb role switch > for USB Type-C connector using USB role switch class framework. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > --- > V5-->V6 > * Updated description > * Added usb-role-switch-property > V4-->V5 > * No Change > V3-->V4 > * No Change > V2-->V3 > * Added optional renesas,usb-role-switch property. > V1-->V2 > * Added usb-role-switch-property > * Updated the example with usb-role-switch property. > --- > .../devicetree/bindings/usb/renesas_usb3.txt | 26 ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > index 35039e7..ea6c63c 100644 > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > @@ -22,6 +22,11 @@ Required properties: > Optional properties: > - phys: phandle + phy specifier pair > - phy-names: must be "usb" > + - usb-role-switch: support role switch. see usb/generic.txt > + > +Sub-nodes: > +The port would be added as a subnode if the "usb-role-switch" property is used. > + see graph.txt I think we should describe which type of a subnode is needed. I made an example below. This is based on the usb-connector.txt. --- Sub-nodes: - any connector to the data bus of this controller should be modeled using the OF graph bindings specified in bindings/graph.txt. --- > Example of R-Car H3 ES1.x: > usb3_peri0: usb@ee020000 { > @@ -39,3 +44,24 @@ Example of R-Car H3 ES1.x: > interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&cpg CPG_MOD 327>; > }; > + > +Example of RZ/G2E: > + usb3_peri0: usb@ee020000 { > + compatible = "renesas,r8a774c0-usb3-peri", > + "renesas,rcar-gen3-usb3-peri"; > + reg = <0 0xee020000 0 0x400>; > + interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 328>; > + companion = <&xhci0>; > + usb-role-switch; > + > + port { > + #address-cells = <1>; > + #size-cells = <0>; > + > + usb3peri_role_switch: endpoint@0 { > + reg = <0>; I'm not sure, but I don't think this endpoint@0 and reg = <0> are needed. In other words, can we use have following node? usb3peri_role_switch: endpoint { remote-endpoint = <&hd3ss3220_ep>; }; Best regards, Yoshihiro Shimoda
WARNING: multiple messages have this Message-ID (diff)
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> To: Biju Das <biju.das@bp.renesas.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Biju Das <biju.das@bp.renesas.com>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, Felipe Balbi <balbi@kernel.org>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Simon Horman <horms@verge.net.au>, Geert Uytterhoeven <geert+renesas@glider.be>, Chris Paterson <Chris.Paterson2@renesas.com>, Fabrizio Castro <fabrizio.castro@bp.renesas.com>, "linux-renesas-soc@vger.kernel.org" <linux-renesas-soc@vger.kernel.org> Subject: RE: [PATCH v6 2/7] dt-bindings: usb: renesas_usb3: Document usb role switch support Date: Tue, 21 May 2019 08:27:23 +0000 [thread overview] Message-ID: <OSAPR01MB308934C379A9759841E58043D8070@OSAPR01MB3089.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <1557922152-16449-3-git-send-email-biju.das@bp.renesas.com> Hi Biju-san, Thank you for the patch! > From: Biju Das, Sent: Wednesday, May 15, 2019 9:09 PM > > Update the DT bindings documentation to support usb role switch > for USB Type-C connector using USB role switch class framework. > > Signed-off-by: Biju Das <biju.das@bp.renesas.com> > --- > V5-->V6 > * Updated description > * Added usb-role-switch-property > V4-->V5 > * No Change > V3-->V4 > * No Change > V2-->V3 > * Added optional renesas,usb-role-switch property. > V1-->V2 > * Added usb-role-switch-property > * Updated the example with usb-role-switch property. > --- > .../devicetree/bindings/usb/renesas_usb3.txt | 26 ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > index 35039e7..ea6c63c 100644 > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > @@ -22,6 +22,11 @@ Required properties: > Optional properties: > - phys: phandle + phy specifier pair > - phy-names: must be "usb" > + - usb-role-switch: support role switch. see usb/generic.txt > + > +Sub-nodes: > +The port would be added as a subnode if the "usb-role-switch" property is used. > + see graph.txt I think we should describe which type of a subnode is needed. I made an example below. This is based on the usb-connector.txt. --- Sub-nodes: - any connector to the data bus of this controller should be modeled using the OF graph bindings specified in bindings/graph.txt. --- > Example of R-Car H3 ES1.x: > usb3_peri0: usb@ee020000 { > @@ -39,3 +44,24 @@ Example of R-Car H3 ES1.x: > interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&cpg CPG_MOD 327>; > }; > + > +Example of RZ/G2E: > + usb3_peri0: usb@ee020000 { > + compatible = "renesas,r8a774c0-usb3-peri", > + "renesas,rcar-gen3-usb3-peri"; > + reg = <0 0xee020000 0 0x400>; > + interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 328>; > + companion = <&xhci0>; > + usb-role-switch; > + > + port { > + #address-cells = <1>; > + #size-cells = <0>; > + > + usb3peri_role_switch: endpoint@0 { > + reg = <0>; I'm not sure, but I don't think this endpoint@0 and reg = <0> are needed. In other words, can we use have following node? usb3peri_role_switch: endpoint { remote-endpoint = <&hd3ss3220_ep>; }; Best regards, Yoshihiro Shimoda
next prev parent reply other threads:[~2019-05-21 8:27 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-15 12:09 [PATCH v6 0/7] Add USB3.0 and TI HD3SS3220 driver support Biju Das 2019-05-15 12:09 ` [PATCH v6 1/7] dt-bindings: usb: hd3ss3220 device tree binding document Biju Das 2019-05-15 16:09 ` Sergei Shtylyov 2019-05-21 9:42 ` Biju Das 2019-05-21 9:42 ` Biju Das 2019-05-21 8:03 ` Yoshihiro Shimoda 2019-05-21 8:03 ` Yoshihiro Shimoda 2019-05-21 8:08 ` Kuninori Morimoto 2019-05-21 8:08 ` Kuninori Morimoto 2019-05-22 10:59 ` Biju Das 2019-05-22 10:59 ` Biju Das 2019-05-23 5:18 ` Yoshihiro Shimoda 2019-05-23 5:18 ` Yoshihiro Shimoda 2019-05-23 8:56 ` Biju Das 2019-05-23 8:56 ` Biju Das 2019-05-15 12:09 ` [PATCH v6 2/7] dt-bindings: usb: renesas_usb3: Document usb role switch support Biju Das 2019-05-21 8:27 ` Yoshihiro Shimoda [this message] 2019-05-21 8:27 ` Yoshihiro Shimoda 2019-05-28 7:25 ` Biju Das 2019-05-28 7:25 ` Biju Das 2019-05-15 12:09 ` [PATCH v6 3/7] usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller Biju Das 2019-05-15 12:09 ` [PATCH v6 4/7] usb: gadget: udc: renesas_usb3: Add dual role switch support Biju Das 2019-05-16 3:16 ` Chunfeng Yun 2019-05-16 8:00 ` Biju Das 2019-05-21 5:49 ` Yoshihiro Shimoda 2019-05-21 7:10 ` Biju Das 2019-05-21 7:34 ` Yoshihiro Shimoda 2019-05-15 12:09 ` [PATCH v6 5/7] arm64: defconfig: enable TYPEC_HD3SS3220 config option Biju Das 2019-05-15 12:09 ` Biju Das 2019-05-15 12:09 ` [PATCH v6 6/7] arm64: dts: renesas: r8a774c0-cat874: Enable USB3.0 host/peripheral device node Biju Das 2019-05-15 12:09 ` [PATCH v6 7/7] arm64: dts: renesas: r8a774c0-cat874: Enable usb role switch support Biju Das 2019-05-24 21:50 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=OSAPR01MB308934C379A9759841E58043D8070@OSAPR01MB3089.jpnprd01.prod.outlook.com \ --to=yoshihiro.shimoda.uh@renesas.com \ --cc=Chris.Paterson2@renesas.com \ --cc=balbi@kernel.org \ --cc=biju.das@bp.renesas.com \ --cc=devicetree@vger.kernel.org \ --cc=fabrizio.castro@bp.renesas.com \ --cc=geert+renesas@glider.be \ --cc=gregkh@linuxfoundation.org \ --cc=heikki.krogerus@linux.intel.com \ --cc=horms@verge.net.au \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.