All of lore.kernel.org
 help / color / mirror / Atom feed
From: "HAGIO KAZUHITO(萩尾　一仁)" <k-hagio-ab@nec.com>
To: Jiang Wang <jiang.wang@bytedance.com>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: RE: [PATCH] makedumpfile: Fix a compile error on Debian with pthread
Date: Mon, 1 Feb 2021 01:42:54 +0000	[thread overview]
Message-ID: <OSBPR01MB19911206BBDE1223B48CF5B6DDB69@OSBPR01MB1991.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20210130184920.1385887-1-jiang.wang@bytedance.com>

-----Original Message-----
> From: "jiang.wang" <jiang.wang@bytedance.com>
> 
> On Debian 10, make reports errors about undefined reference to
> `pthread_rwlock_tryrdlock'. To fix it, put ldw before lpthread
> in the Makefile.
> 
> Signed-off-by: Jiang Wang <jiang.wang@bytedance.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index cb6bd42..010d447 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -68,7 +68,7 @@ endif
>  CFLAGS += -DUSESNAPPY
>  endif
> 
> -LIBS := -lpthread $(LIBS)
> +LIBS := $(LIBS) -lpthread
> 
>  try-run = $(shell set -e;		\
>  	TMP=".$$$$.tmp";		\
> --
> 2.11.0

Thanks for the patch, applied.
https://github.com/makedumpfile/makedumpfile/commit/01b4bd354c4a845c160d14487a93270cd1e22031

Kazu


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2021-02-01  1:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-30 18:49 [PATCH] makedumpfile: Fix a compile error on Debian with pthread Jiang Wang
2021-02-01  1:42 ` HAGIO KAZUHITO(萩尾　一仁) [this message]
2021-02-01 17:00   ` [External] " Jiang Wang .

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSBPR01MB19911206BBDE1223B48CF5B6DDB69@OSBPR01MB1991.jpnprd01.prod.outlook.com \
    --to=k-hagio-ab@nec.com \
    --cc=jiang.wang@bytedance.com \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.