All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: renesas: r8a77990: ebisu: Fix EthernetAVB phy mode to rgmii
@ 2018-12-12 10:45 ` Simon Horman
  0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2018-12-12 10:45 UTC (permalink / raw)
  To: linux-renesas-soc; +Cc: linux-arm-kernel, Magnus Damm

From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>

According to the R-Car Gen3 Hardware Manual Errata for Rev 1.00 of
August 24, 2018, the TX clock internal delay mode doesn't support
on R-Car E3. This patch fixes EthernetAVB phy mode to rgmii.

Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

 Based on renesas-devel-20181210-v4.20-rc6

diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
index 62bdddcbbae7..0c4df048a8cb 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
@@ -248,7 +248,7 @@
 	pinctrl-names = "default";
 	renesas,no-ether-link;
 	phy-handle = <&phy0>;
-	phy-mode = "rgmii-txid";
+	phy-mode = "rgmii";
 	status = "okay";
 
 	phy0: ethernet-phy@0 {
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] arm64: dts: renesas: r8a77990: ebisu: Fix EthernetAVB phy mode to rgmii
@ 2018-12-12 10:45 ` Simon Horman
  0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2018-12-12 10:45 UTC (permalink / raw)
  To: linux-renesas-soc; +Cc: Magnus Damm, linux-arm-kernel

From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>

According to the R-Car Gen3 Hardware Manual Errata for Rev 1.00 of
August 24, 2018, the TX clock internal delay mode doesn't support
on R-Car E3. This patch fixes EthernetAVB phy mode to rgmii.

Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

 Based on renesas-devel-20181210-v4.20-rc6

diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
index 62bdddcbbae7..0c4df048a8cb 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
@@ -248,7 +248,7 @@
 	pinctrl-names = "default";
 	renesas,no-ether-link;
 	phy-handle = <&phy0>;
-	phy-mode = "rgmii-txid";
+	phy-mode = "rgmii";
 	status = "okay";
 
 	phy0: ethernet-phy@0 {
-- 
2.11.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [PATCH] arm64: dts: renesas: r8a77990: ebisu: Fix EthernetAVB phy mode to rgmii
  2018-12-12 10:45 ` Simon Horman
@ 2018-12-13 10:08   ` Biju Das
  -1 siblings, 0 replies; 4+ messages in thread
From: Biju Das @ 2018-12-13 10:08 UTC (permalink / raw)
  To: Simon Horman, linux-renesas-soc; +Cc: linux-arm-kernel, Magnus Damm

Hi Simon,

Thanks for the  patch.

> Subject: [PATCH] arm64: dts: renesas: r8a77990: ebisu: Fix EthernetAVB phy
> mode to rgmii
>
> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>
> According to the R-Car Gen3 Hardware Manual Errata for Rev 1.00 of August
> 24, 2018, the TX clock internal delay mode doesn't support on R-Car E3. This
> patch fixes EthernetAVB phy mode to rgmii.
>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>  Based on renesas-devel-20181210-v4.20-rc6
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> index 62bdddcbbae7..0c4df048a8cb 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> @@ -248,7 +248,7 @@
>  pinctrl-names = "default";
>  renesas,no-ether-link;
>  phy-handle = <&phy0>;
> -phy-mode = "rgmii-txid";
> +phy-mode = "rgmii";

The default value of phy-mode in 777990 SoC dtsi is "rgmii". So we don't need to redefine this in board dtsi, I think.

Regards,
Biju


[https://www2.renesas.eu/media/email/unicef.jpg]

This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] arm64: dts: renesas: r8a77990: ebisu: Fix EthernetAVB phy mode to rgmii
@ 2018-12-13 10:08   ` Biju Das
  0 siblings, 0 replies; 4+ messages in thread
From: Biju Das @ 2018-12-13 10:08 UTC (permalink / raw)
  To: Simon Horman, linux-renesas-soc; +Cc: Magnus Damm, linux-arm-kernel

Hi Simon,

Thanks for the  patch.

> Subject: [PATCH] arm64: dts: renesas: r8a77990: ebisu: Fix EthernetAVB phy
> mode to rgmii
>
> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>
> According to the R-Car Gen3 Hardware Manual Errata for Rev 1.00 of August
> 24, 2018, the TX clock internal delay mode doesn't support on R-Car E3. This
> patch fixes EthernetAVB phy mode to rgmii.
>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>  Based on renesas-devel-20181210-v4.20-rc6
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> index 62bdddcbbae7..0c4df048a8cb 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
> @@ -248,7 +248,7 @@
>  pinctrl-names = "default";
>  renesas,no-ether-link;
>  phy-handle = <&phy0>;
> -phy-mode = "rgmii-txid";
> +phy-mode = "rgmii";

The default value of phy-mode in 777990 SoC dtsi is "rgmii". So we don't need to redefine this in board dtsi, I think.

Regards,
Biju


[https://www2.renesas.eu/media/email/unicef.jpg]

This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-12-13 10:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-12 10:45 [PATCH] arm64: dts: renesas: r8a77990: ebisu: Fix EthernetAVB phy mode to rgmii Simon Horman
2018-12-12 10:45 ` Simon Horman
2018-12-13 10:08 ` Biju Das
2018-12-13 10:08   ` Biju Das

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.