* [PATCH] arm64: dts: renesas: revise hsusb's reg size
@ 2018-10-16 6:04 Yoshihiro Shimoda
2018-10-17 8:57 ` Simon Horman
2018-10-17 9:15 ` Biju Das
0 siblings, 2 replies; 6+ messages in thread
From: Yoshihiro Shimoda @ 2018-10-16 6:04 UTC (permalink / raw)
To: horms, magnus.damm; +Cc: linux-renesas-soc, Yoshihiro Shimoda
This patch revises the reg size of each hsusb device node for
r8a7795, r8a7796 and r8a77965.
Reported-by: Biju Das <biju.das@bp.renesas.com>
Fixes: d2422e108812 ("arm64: dts: r8a7795: Add HSUSB device node")
Fixes: 4725f2b88057 ("arm64: dts: renesas: r8a7795: add hsusb ch3 device node")
Fixes: b9535853777f ("arm64: dts: r8a7796: Add HSUSB device node")
Fixes: 9e1b00a2ef43 ("arm64: dts: renesas: r8a77965: Add "reg" properties")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
arch/arm64/boot/dts/renesas/r8a7795.dtsi | 4 ++--
arch/arm64/boot/dts/renesas/r8a7796.dtsi | 2 +-
arch/arm64/boot/dts/renesas/r8a77965.dtsi | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index 5f6020e..0b54c53 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -695,7 +695,7 @@
hsusb: usb@e6590000 {
compatible = "renesas,usbhs-r8a7795",
"renesas,rcar-gen3-usbhs";
- reg = <0 0xe6590000 0 0x100>;
+ reg = <0 0xe6590000 0 0x200>;
interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 704>, <&cpg CPG_MOD 703>;
dmas = <&usb_dmac0 0>, <&usb_dmac0 1>,
@@ -712,7 +712,7 @@
hsusb3: usb@e659c000 {
compatible = "renesas,usbhs-r8a7795",
"renesas,rcar-gen3-usbhs";
- reg = <0 0xe659c000 0 0x100>;
+ reg = <0 0xe659c000 0 0x200>;
interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 705>, <&cpg CPG_MOD 700>;
dmas = <&usb_dmac2 0>, <&usb_dmac2 1>,
diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 1ec6aaa..3baee26 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -674,7 +674,7 @@
hsusb: usb@e6590000 {
compatible = "renesas,usbhs-r8a7796",
"renesas,rcar-gen3-usbhs";
- reg = <0 0xe6590000 0 0x100>;
+ reg = <0 0xe6590000 0 0x200>;
interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 704>, <&cpg CPG_MOD 703>;
dmas = <&usb_dmac0 0>, <&usb_dmac0 1>,
diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 83946ca..f12be5b 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -590,7 +590,7 @@
hsusb: usb@e6590000 {
compatible = "renesas,usbhs-r8a77965",
"renesas,rcar-gen3-usbhs";
- reg = <0 0xe6590000 0 0x100>;
+ reg = <0 0xe6590000 0 0x200>;
interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 704>, <&cpg CPG_MOD 703>;
dmas = <&usb_dmac0 0>, <&usb_dmac0 1>,
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: renesas: revise hsusb's reg size
2018-10-16 6:04 [PATCH] arm64: dts: renesas: revise hsusb's reg size Yoshihiro Shimoda
@ 2018-10-17 8:57 ` Simon Horman
2018-10-17 9:34 ` Geert Uytterhoeven
2018-10-17 9:15 ` Biju Das
1 sibling, 1 reply; 6+ messages in thread
From: Simon Horman @ 2018-10-17 8:57 UTC (permalink / raw)
To: Yoshihiro Shimoda; +Cc: magnus.damm, linux-renesas-soc
On Tue, Oct 16, 2018 at 03:04:50PM +0900, Yoshihiro Shimoda wrote:
> This patch revises the reg size of each hsusb device node for
> r8a7795, r8a7796 and r8a77965.
>
> Reported-by: Biju Das <biju.das@bp.renesas.com>
> Fixes: d2422e108812 ("arm64: dts: r8a7795: Add HSUSB device node")
> Fixes: 4725f2b88057 ("arm64: dts: renesas: r8a7795: add hsusb ch3 device node")
> Fixes: b9535853777f ("arm64: dts: r8a7796: Add HSUSB device node")
> Fixes: 9e1b00a2ef43 ("arm64: dts: renesas: r8a77965: Add "reg" properties")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Thanks Shimoda-san,
This looks fine to me but I will wait to see if there are other reviews
before applying.
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Also, could you let me know if this has any run-time effect?
If so perhaps it should be treated as a fix for v4.20 rather than
a patch for v4.21.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] arm64: dts: renesas: revise hsusb's reg size
2018-10-16 6:04 [PATCH] arm64: dts: renesas: revise hsusb's reg size Yoshihiro Shimoda
2018-10-17 8:57 ` Simon Horman
@ 2018-10-17 9:15 ` Biju Das
1 sibling, 0 replies; 6+ messages in thread
From: Biju Das @ 2018-10-17 9:15 UTC (permalink / raw)
To: Yoshihiro Shimoda, horms, magnus.damm
Cc: linux-renesas-soc, Yoshihiro Shimoda
Hi Shimoda-San,
Thanks for the patch.
> -----Original Message-----
> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-
> owner@vger.kernel.org> On Behalf Of Yoshihiro Shimoda
> Sent: 16 October 2018 07:05
> To: horms@verge.net.au; magnus.damm@gmail.com
> Cc: linux-renesas-soc@vger.kernel.org; Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com>
> Subject: [PATCH] arm64: dts: renesas: revise hsusb's reg size
>
> This patch revises the reg size of each hsusb device node for r8a7795, r8a7796
> and r8a77965.
>
> Reported-by: Biju Das <biju.das@bp.renesas.com>
> Fixes: d2422e108812 ("arm64: dts: r8a7795: Add HSUSB device node")
> Fixes: 4725f2b88057 ("arm64: dts: renesas: r8a7795: add hsusb ch3 device
> node")
> Fixes: b9535853777f ("arm64: dts: r8a7796: Add HSUSB device node")
> Fixes: 9e1b00a2ef43 ("arm64: dts: renesas: r8a77965: Add "reg" properties")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
Regards,
Biju
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: renesas: revise hsusb's reg size
2018-10-17 8:57 ` Simon Horman
@ 2018-10-17 9:34 ` Geert Uytterhoeven
2018-10-18 12:40 ` Simon Horman
2018-10-19 5:13 ` Yoshihiro Shimoda
0 siblings, 2 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2018-10-17 9:34 UTC (permalink / raw)
To: Simon Horman; +Cc: Yoshihiro Shimoda, Magnus Damm, Linux-Renesas
Hi Simon,
On Wed, Oct 17, 2018 at 10:57 AM Simon Horman <horms@verge.net.au> wrote:
> On Tue, Oct 16, 2018 at 03:04:50PM +0900, Yoshihiro Shimoda wrote:
> > This patch revises the reg size of each hsusb device node for
> > r8a7795, r8a7796 and r8a77965.
> >
> > Reported-by: Biju Das <biju.das@bp.renesas.com>
> > Fixes: d2422e108812 ("arm64: dts: r8a7795: Add HSUSB device node")
> > Fixes: 4725f2b88057 ("arm64: dts: renesas: r8a7795: add hsusb ch3 device node")
> > Fixes: b9535853777f ("arm64: dts: r8a7796: Add HSUSB device node")
> > Fixes: 9e1b00a2ef43 ("arm64: dts: renesas: r8a77965: Add "reg" properties")
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> Thanks Shimoda-san,
>
> This looks fine to me but I will wait to see if there are other reviews
> before applying.
>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
>
> Also, could you let me know if this has any run-time effect?
> If so perhaps it should be treated as a fix for v4.20 rather than
> a patch for v4.21.
Probably not, as mapping granularity is PAGE_SIZE (> 0x200) anyway.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: renesas: revise hsusb's reg size
2018-10-17 9:34 ` Geert Uytterhoeven
@ 2018-10-18 12:40 ` Simon Horman
2018-10-19 5:13 ` Yoshihiro Shimoda
1 sibling, 0 replies; 6+ messages in thread
From: Simon Horman @ 2018-10-18 12:40 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Yoshihiro Shimoda, Magnus Damm, Linux-Renesas
On Wed, Oct 17, 2018 at 11:34:43AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Wed, Oct 17, 2018 at 10:57 AM Simon Horman <horms@verge.net.au> wrote:
> > On Tue, Oct 16, 2018 at 03:04:50PM +0900, Yoshihiro Shimoda wrote:
> > > This patch revises the reg size of each hsusb device node for
> > > r8a7795, r8a7796 and r8a77965.
> > >
> > > Reported-by: Biju Das <biju.das@bp.renesas.com>
> > > Fixes: d2422e108812 ("arm64: dts: r8a7795: Add HSUSB device node")
> > > Fixes: 4725f2b88057 ("arm64: dts: renesas: r8a7795: add hsusb ch3 device node")
> > > Fixes: b9535853777f ("arm64: dts: r8a7796: Add HSUSB device node")
> > > Fixes: 9e1b00a2ef43 ("arm64: dts: renesas: r8a77965: Add "reg" properties")
> > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >
> > Thanks Shimoda-san,
> >
> > This looks fine to me but I will wait to see if there are other reviews
> > before applying.
> >
> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> >
> >
> > Also, could you let me know if this has any run-time effect?
> > If so perhaps it should be treated as a fix for v4.20 rather than
> > a patch for v4.21.
>
> Probably not, as mapping granularity is PAGE_SIZE (> 0x200) anyway.
Thanks, I have applied this for v4.21.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] arm64: dts: renesas: revise hsusb's reg size
2018-10-17 9:34 ` Geert Uytterhoeven
2018-10-18 12:40 ` Simon Horman
@ 2018-10-19 5:13 ` Yoshihiro Shimoda
1 sibling, 0 replies; 6+ messages in thread
From: Yoshihiro Shimoda @ 2018-10-19 5:13 UTC (permalink / raw)
To: Geert Uytterhoeven, Simon Horman; +Cc: Magnus Damm, Linux-Renesas
Hi Simon-san, Geert-san,
> From: Geert Uytterhoeven, Sent: Wednesday, October 17, 2018 6:35 PM
>
> Hi Simon,
>
> On Wed, Oct 17, 2018 at 10:57 AM Simon Horman <horms@verge.net.au> wrote:
> > On Tue, Oct 16, 2018 at 03:04:50PM +0900, Yoshihiro Shimoda wrote:
> > > This patch revises the reg size of each hsusb device node for
> > > r8a7795, r8a7796 and r8a77965.
> > >
> > > Reported-by: Biju Das <biju.das@bp.renesas.com>
> > > Fixes: d2422e108812 ("arm64: dts: r8a7795: Add HSUSB device node")
> > > Fixes: 4725f2b88057 ("arm64: dts: renesas: r8a7795: add hsusb ch3 device node")
> > > Fixes: b9535853777f ("arm64: dts: r8a7796: Add HSUSB device node")
> > > Fixes: 9e1b00a2ef43 ("arm64: dts: renesas: r8a77965: Add "reg" properties")
> > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >
> > Thanks Shimoda-san,
> >
> > This looks fine to me but I will wait to see if there are other reviews
> > before applying.
> >
> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> >
> >
> > Also, could you let me know if this has any run-time effect?
> > If so perhaps it should be treated as a fix for v4.20 rather than
> > a patch for v4.21.
>
> Probably not, as mapping granularity is PAGE_SIZE (> 0x200) anyway.
As Geert-san mentioned, I don't think this patch needs as a fix for v4.20.
Best regards,
Yoshihiro Shimoda
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-19 13:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-16 6:04 [PATCH] arm64: dts: renesas: revise hsusb's reg size Yoshihiro Shimoda
2018-10-17 8:57 ` Simon Horman
2018-10-17 9:34 ` Geert Uytterhoeven
2018-10-18 12:40 ` Simon Horman
2018-10-19 5:13 ` Yoshihiro Shimoda
2018-10-17 9:15 ` Biju Das
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.