All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Rob Herring <robh@kernel.org>
Cc: "balbi@kernel.org" <balbi@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH v4 2/3] dt-bindings: usb: renesas_usbhs: add clock-names property
Date: Tue, 11 Sep 2018 02:38:00 +0000	[thread overview]
Message-ID: <OSBPR01MB229363BDD44B8D8B01954AF3D8040@OSBPR01MB2293.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20180910182634.GA21062@bogus>

Hi Rob,

> From: Rob Herring, Sent: Tuesday, September 11, 2018 3:27 AM
> 
> On Mon, Sep 10, 2018 at 06:52:19PM +0900, Yoshihiro Shimoda wrote:
> > R-Car Gen3 needs to enable clocks of both host and peripheral.
> > Otherwise, other side device cannot work correctly. So, this patch
> > adds a property of clock-names for R-Car Gen3 as an optional.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > ---
> >  Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> > index 087140a..dbdb92c 100644
> > --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> > +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> > @@ -26,7 +26,9 @@ Required properties:
> >
> >    - reg: Base address and length of the register for the USBHS
> >    - interrupts: Interrupt specifier for the USBHS
> > -  - clocks: A list of phandle + clock specifier pairs
> > +  - clocks: A list of phandle + clock specifier pairs. In case of
> > +	    "renesas,rcar-gen3-usbhs" compatible device, first clock should be
> > +	    peripheral and second one should be host.
> 
> This should have said how many clocks. That's still not clear except for
> "renesas,rcar-gen3-usbhs".

Thank you for your comments! I'll revise it.

Best regards,
Yoshihiro Shimoda

> Rob

WARNING: multiple messages have this Message-ID (diff)
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Rob Herring <robh@kernel.org>
Cc: "balbi@kernel.org" <balbi@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: [v4,2/3] dt-bindings: usb: renesas_usbhs: add clock-names property
Date: Tue, 11 Sep 2018 02:38:00 +0000	[thread overview]
Message-ID: <OSBPR01MB229363BDD44B8D8B01954AF3D8040@OSBPR01MB2293.jpnprd01.prod.outlook.com> (raw)

Hi Rob,

> From: Rob Herring, Sent: Tuesday, September 11, 2018 3:27 AM
> 
> On Mon, Sep 10, 2018 at 06:52:19PM +0900, Yoshihiro Shimoda wrote:
> > R-Car Gen3 needs to enable clocks of both host and peripheral.
> > Otherwise, other side device cannot work correctly. So, this patch
> > adds a property of clock-names for R-Car Gen3 as an optional.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > ---
> >  Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> > index 087140a..dbdb92c 100644
> > --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> > +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> > @@ -26,7 +26,9 @@ Required properties:
> >
> >    - reg: Base address and length of the register for the USBHS
> >    - interrupts: Interrupt specifier for the USBHS
> > -  - clocks: A list of phandle + clock specifier pairs
> > +  - clocks: A list of phandle + clock specifier pairs. In case of
> > +	    "renesas,rcar-gen3-usbhs" compatible device, first clock should be
> > +	    peripheral and second one should be host.
> 
> This should have said how many clocks. That's still not clear except for
> "renesas,rcar-gen3-usbhs".

Thank you for your comments! I'll revise it.

Best regards,
Yoshihiro Shimoda

> Rob

  reply	other threads:[~2018-09-11  2:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-10  9:52 [PATCH v4 0/3] usb: renesas_usbhs: add reset_control and multiple clocks management Yoshihiro Shimoda
2018-09-10  9:52 ` [PATCH v4 1/3] usb: renesas_usbhs: Add reset_control Yoshihiro Shimoda
2018-09-10  9:52   ` [v4,1/3] " Yoshihiro Shimoda
2018-09-10  9:52 ` [PATCH v4 2/3] dt-bindings: usb: renesas_usbhs: add clock-names property Yoshihiro Shimoda
2018-09-10  9:52   ` [v4,2/3] " Yoshihiro Shimoda
2018-09-10 18:26   ` [PATCH v4 2/3] " Rob Herring
2018-09-10 18:26     ` [v4,2/3] " Rob Herring
2018-09-11  2:38     ` Yoshihiro Shimoda [this message]
2018-09-11  2:38       ` Yoshihiro Shimoda
2018-09-10  9:52 ` [PATCH v4 3/3] usb: renesas_usbhs: Add multiple clocks management Yoshihiro Shimoda
2018-09-10  9:52   ` [v4,3/3] " Yoshihiro Shimoda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSBPR01MB229363BDD44B8D8B01954AF3D8040@OSBPR01MB2293.jpnprd01.prod.outlook.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=balbi@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.