All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Biju Das <biju.das@bp.renesas.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Biju Das <biju.das@bp.renesas.com>,
	Fengguang Wu <fengguang.wu@intel.com>,
	Chris Brandt <Chris.Brandt@renesas.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	Simon Horman <horms@verge.net.au>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH] usb: renesas_usbhs: Add a compatible string for r8a774a1
Date: Mon, 27 Aug 2018 04:59:33 +0000	[thread overview]
Message-ID: <OSBPR01MB2293F924765AEA743B5A1D69D80B0@OSBPR01MB2293.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <1535105369-63810-1-git-send-email-biju.das@bp.renesas.com>

Hi Biju-san,

Thank you for the patch!

> From: Biju Das, Sent: Friday, August 24, 2018 7:09 PM
> 
> This patch adds support for r8a774a1 (RZ/G2M).
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  drivers/usb/renesas_usbhs/common.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
> index 4310df4..f1a1694 100644
> --- a/drivers/usb/renesas_usbhs/common.c
> +++ b/drivers/usb/renesas_usbhs/common.c
> @@ -458,6 +458,10 @@ static int usbhsc_drvcllbck_notify_hotplug(struct platform_device *pdev)
>   */
>  static const struct of_device_id usbhs_of_match[] = {
>  	{
> +		.compatible = "renesas,usbhs-r8a774a1",
> +		.data = (void *)USBHS_TYPE_RCAR_GEN3,
> +	},
> +	{

I don't think you need this adding entry for r8a774a1 actually because
you also submitted a bindings patch [1] and it had "renesas,rcar-gen3-usbhs" for RZ/G2.

[1]
 https://patchwork.kernel.org/patch/10574875/

Best regards,
Yoshihiro Shimoda

>  		.compatible = "renesas,usbhs-r8a7790",
>  		.data = (void *)USBHS_TYPE_RCAR_GEN2,
>  	},
> --
> 2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Biju Das <biju.das@bp.renesas.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>,
	Chris Brandt <Chris.Brandt@renesas.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	Simon Horman <horms@verge.net.au>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>
Subject: usb: renesas_usbhs: Add a compatible string for r8a774a1
Date: Mon, 27 Aug 2018 04:59:33 +0000	[thread overview]
Message-ID: <OSBPR01MB2293F924765AEA743B5A1D69D80B0@OSBPR01MB2293.jpnprd01.prod.outlook.com> (raw)

Hi Biju-san,

Thank you for the patch!

> From: Biju Das, Sent: Friday, August 24, 2018 7:09 PM
> 
> This patch adds support for r8a774a1 (RZ/G2M).
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
>  drivers/usb/renesas_usbhs/common.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
> index 4310df4..f1a1694 100644
> --- a/drivers/usb/renesas_usbhs/common.c
> +++ b/drivers/usb/renesas_usbhs/common.c
> @@ -458,6 +458,10 @@ static int usbhsc_drvcllbck_notify_hotplug(struct platform_device *pdev)
>   */
>  static const struct of_device_id usbhs_of_match[] = {
>  	{
> +		.compatible = "renesas,usbhs-r8a774a1",
> +		.data = (void *)USBHS_TYPE_RCAR_GEN3,
> +	},
> +	{

I don't think you need this adding entry for r8a774a1 actually because
you also submitted a bindings patch [1] and it had "renesas,rcar-gen3-usbhs" for RZ/G2.

[1]
 https://patchwork.kernel.org/patch/10574875/

Best regards,
Yoshihiro Shimoda

>  		.compatible = "renesas,usbhs-r8a7790",
>  		.data = (void *)USBHS_TYPE_RCAR_GEN2,
>  	},
> --
> 2.7.4

  reply	other threads:[~2018-08-27  8:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-24 10:09 [PATCH] usb: renesas_usbhs: Add a compatible string for r8a774a1 Biju Das
2018-08-24 10:09 ` Biju Das
2018-08-27  4:59 ` Yoshihiro Shimoda [this message]
2018-08-27  4:59   ` Yoshihiro Shimoda
2018-08-28  7:38   ` [PATCH] " Biju Das
2018-08-28  7:38     ` Biju Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSBPR01MB2293F924765AEA743B5A1D69D80B0@OSBPR01MB2293.jpnprd01.prod.outlook.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=Chris.Brandt@renesas.com \
    --cc=Chris.Paterson2@renesas.com \
    --cc=biju.das@bp.renesas.com \
    --cc=fabrizio.castro@bp.renesas.com \
    --cc=felipe.balbi@linux.intel.com \
    --cc=fengguang.wu@intel.com \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=horms@verge.net.au \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.