* [cip-dev] [PATCH 4.19.y-cip] drm: of: Fix double-free bug
@ 2020-08-03 11:14 Biju Das
2020-08-03 20:57 ` Pavel Machek
0 siblings, 1 reply; 4+ messages in thread
From: Biju Das @ 2020-08-03 11:14 UTC (permalink / raw)
To: cip-dev, Nobuhiro Iwamatsu, Pavel Machek
Cc: Chris Paterson, Biju Das, Prabhakar Mahadev Lad
[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]
commit 4ee48cc5586bf519df19894273002aa8ef7b70ad upstream.
Fix double-free bug in the error path.
Fixes: 6529007522de ("drm: of: Add drm_of_lvds_get_dual_link_pixel_order")
Reported-by: Pavel Machek <pavel@denx.de>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: stable@vger.kernel.org
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/1595502654-40595-1-git-send-email-biju.das.jz@bp.renesas.com
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
drivers/gpu/drm/drm_of.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
index 4f0bc1363fbe..f2e7f953cc93 100644
--- a/drivers/gpu/drm/drm_of.c
+++ b/drivers/gpu/drm/drm_of.c
@@ -323,10 +323,8 @@ static int drm_of_lvds_get_remote_pixels_type(
* configurations by passing the endpoints explicitly to
* drm_of_lvds_get_dual_link_pixel_order().
*/
- if (!current_pt || pixels_type != current_pt) {
- of_node_put(remote_port);
+ if (!current_pt || pixels_type != current_pt)
return -EINVAL;
- }
}
return pixels_type;
--
2.17.1
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5081): https://lists.cip-project.org/g/cip-dev/message/5081
Mute This Topic: https://lists.cip-project.org/mt/75963411/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [cip-dev] [PATCH 4.19.y-cip] drm: of: Fix double-free bug
2020-08-03 11:14 [cip-dev] [PATCH 4.19.y-cip] drm: of: Fix double-free bug Biju Das
@ 2020-08-03 20:57 ` Pavel Machek
2020-08-03 23:12 ` Nobuhiro Iwamatsu
0 siblings, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2020-08-03 20:57 UTC (permalink / raw)
To: Biju Das
Cc: cip-dev, Nobuhiro Iwamatsu, Pavel Machek, Chris Paterson,
Prabhakar Mahadev Lad
[-- Attachment #1.1: Type: text/plain, Size: 361 bytes --]
Hi!
> commit 4ee48cc5586bf519df19894273002aa8ef7b70ad upstream.
>
> Fix double-free bug in the error path.
Looks good to me. I can apply it if there are no other comments.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5083): https://lists.cip-project.org/g/cip-dev/message/5083
Mute This Topic: https://lists.cip-project.org/mt/75963411/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [cip-dev] [PATCH 4.19.y-cip] drm: of: Fix double-free bug
2020-08-03 20:57 ` Pavel Machek
@ 2020-08-03 23:12 ` Nobuhiro Iwamatsu
2020-08-04 7:51 ` Pavel Machek
0 siblings, 1 reply; 4+ messages in thread
From: Nobuhiro Iwamatsu @ 2020-08-03 23:12 UTC (permalink / raw)
To: pavel, biju.das.jz; +Cc: cip-dev, chris.paterson2, prabhakar.mahadev-lad.rj
[-- Attachment #1: Type: text/plain, Size: 984 bytes --]
Hi,
> -----Original Message-----
> From: Pavel Machek [mailto:pavel@denx.de]
> Sent: Tuesday, August 4, 2020 5:57 AM
> To: Biju Das <biju.das.jz@bp.renesas.com>
> Cc: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT)
> <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>; Chris Paterson <chris.paterson2@renesas.com>;
> Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Subject: Re: [PATCH 4.19.y-cip] drm: of: Fix double-free bug
>
> Hi!
>
> > commit 4ee48cc5586bf519df19894273002aa8ef7b70ad upstream.
> >
> > Fix double-free bug in the error path.
>
> Looks good to me. I can apply it if there are no other comments.
>
I also think that it's not particularly a issue.
> Best regards,
> Pavel
Best regards,
Nobuhiro
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5084): https://lists.cip-project.org/g/cip-dev/message/5084
Mute This Topic: https://lists.cip-project.org/mt/75963411/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [cip-dev] [PATCH 4.19.y-cip] drm: of: Fix double-free bug
2020-08-03 23:12 ` Nobuhiro Iwamatsu
@ 2020-08-04 7:51 ` Pavel Machek
0 siblings, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2020-08-04 7:51 UTC (permalink / raw)
To: nobuhiro1.iwamatsu
Cc: pavel, biju.das.jz, cip-dev, chris.paterson2, prabhakar.mahadev-lad.rj
[-- Attachment #1.1: Type: text/plain, Size: 477 bytes --]
Hi!
> > > commit 4ee48cc5586bf519df19894273002aa8ef7b70ad upstream.
> > >
> > > Fix double-free bug in the error path.
> >
> > Looks good to me. I can apply it if there are no other comments.
> >
>
> I also think that it's not particularly a issue.
Thanks, applied and pushed out.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 419 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5089): https://lists.cip-project.org/g/cip-dev/message/5089
Mute This Topic: https://lists.cip-project.org/mt/75963411/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-04 7:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-03 11:14 [cip-dev] [PATCH 4.19.y-cip] drm: of: Fix double-free bug Biju Das
2020-08-03 20:57 ` Pavel Machek
2020-08-03 23:12 ` Nobuhiro Iwamatsu
2020-08-04 7:51 ` Pavel Machek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.