All of lore.kernel.org
 help / color / mirror / Atom feed
* How to overwrite IMAGE_FSTYPES variable in loacal.conf using placement of kas file wic-targz-img.yml
@ 2023-01-31 16:55 Venkata.Pyla
  2023-02-01  7:36 ` Jan Kiszka
  0 siblings, 1 reply; 5+ messages in thread
From: Venkata.Pyla @ 2023-01-31 16:55 UTC (permalink / raw)
  To: cip-dev, jan.kiszka; +Cc: dinesh.kumar, kazuhiro3.hayashi

Hi,

I am trying to overwrite the IMAGE_FSTYPES variable with the values in wic-targz-img.yml by keeping at the end in kas file definition as shown in below command, but it is not overwriting.

$ kas-container build kas-cip.yml:kas/opt/ebg-swu.yml:kas/opt/wic-targz-img.yml

kas/opt/ebg-swu.yml include local_conf_header as below
-----------------------------------------
local_conf_header:
   ...
    wic-swu: |
         ...
          IMAGE_FSTYPES = "wic"
         ...
-----------------------------------------


kas/opt/wic-targz-img.yml include local_conf_header as below
-----------------------------------------
local_conf_header:
   ...
    image-type: |
         ...
          IMAGE_FSTYPES = "wic tar.gz"
         ...
-----------------------------------------

Final conf/local.conf generate as below
-----------------------------------------
# image-type
IMAGE_FSTYPES = "wic tar.gz"

...

# wic-swu
IMAGE_FSTYPES = "wic"
-----------------------------------------


Expecting conf/local.conf
-----------------------------------------
# wic-swu
IMAGE_FSTYPES = "wic"

...

# image-type
IMAGE_FSTYPES = "wic tar.gz"
-----------------------------------------

The above is possible when I use name with higher in alphabetical order like 'zimage-type:' in the wic-targz-img.yml
kas/opt/wic-targz-img.yml with 
-----------------------------------------
local_conf_header:
   ...
    zimage-type: |
         ...
          IMAGE_FSTYPES = "wic tar.gz"
         ...
-----------------------------------------

Is this the only solution to set the order of the variable assignment in local_conf_header?


Thanks,
Venkata.





^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: How to overwrite IMAGE_FSTYPES variable in loacal.conf using placement of kas file wic-targz-img.yml
  2023-01-31 16:55 How to overwrite IMAGE_FSTYPES variable in loacal.conf using placement of kas file wic-targz-img.yml Venkata.Pyla
@ 2023-02-01  7:36 ` Jan Kiszka
  2023-02-01 11:39   ` [cip-dev] " Venkata.Pyla
  0 siblings, 1 reply; 5+ messages in thread
From: Jan Kiszka @ 2023-02-01  7:36 UTC (permalink / raw)
  To: Venkata.Pyla, cip-dev; +Cc: dinesh.kumar, kazuhiro3.hayashi

On 31.01.23 17:55, Venkata.Pyla@toshiba-tsip.com wrote:
> Hi,
> 
> I am trying to overwrite the IMAGE_FSTYPES variable with the values in wic-targz-img.yml by keeping at the end in kas file definition as shown in below command, but it is not overwriting.
> 
> $ kas-container build kas-cip.yml:kas/opt/ebg-swu.yml:kas/opt/wic-targz-img.yml
> 
> kas/opt/ebg-swu.yml include local_conf_header as below
> -----------------------------------------
> local_conf_header:
>    ...
>     wic-swu: |
>          ...
>           IMAGE_FSTYPES = "wic"
>          ...
> -----------------------------------------
> 
> 
> kas/opt/wic-targz-img.yml include local_conf_header as below
> -----------------------------------------
> local_conf_header:
>    ...
>     image-type: |
>          ...
>           IMAGE_FSTYPES = "wic tar.gz"
>          ...
> -----------------------------------------
> 
> Final conf/local.conf generate as below
> -----------------------------------------
> # image-type
> IMAGE_FSTYPES = "wic tar.gz"
> 
> ...
> 
> # wic-swu
> IMAGE_FSTYPES = "wic"
> -----------------------------------------
> 
> 
> Expecting conf/local.conf
> -----------------------------------------
> # wic-swu
> IMAGE_FSTYPES = "wic"
> 
> ...
> 
> # image-type
> IMAGE_FSTYPES = "wic tar.gz"
> -----------------------------------------
> 
> The above is possible when I use name with higher in alphabetical order like 'zimage-type:' in the wic-targz-img.yml
> kas/opt/wic-targz-img.yml with 
> -----------------------------------------
> local_conf_header:
>    ...
>     zimage-type: |
>          ...
>           IMAGE_FSTYPES = "wic tar.gz"
>          ...
> -----------------------------------------
> 
> Is this the only solution to set the order of the variable assignment in local_conf_header?
> 

local.conf nodes are alphabetically sorted as you already found out - we
should probably document that in kas. Generally spoken, you can make use
of that to achieve append behaviour, or you overwrite the original node
you are competing with.

In case of isar-cip-core, we can rearrange or kas option files so that
your use case becomes possible (though I'm unsure if it makes any sense:
the content of the tar.gz will be only a subset of the wic swupdate image).

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux



^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [cip-dev] How to overwrite IMAGE_FSTYPES variable in loacal.conf using placement of kas file wic-targz-img.yml
  2023-02-01  7:36 ` Jan Kiszka
@ 2023-02-01 11:39   ` Venkata.Pyla
  2023-02-02  8:56     ` Jan Kiszka
  0 siblings, 1 reply; 5+ messages in thread
From: Venkata.Pyla @ 2023-02-01 11:39 UTC (permalink / raw)
  To: cip-dev; +Cc: dinesh.kumar, kazuhiro3.hayashi



>-----Original Message-----
>From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On Behalf
>Of Jan Kiszka
>Sent: 01 February 2023 13:06
>To: pyla venkata(TSIP TMIEC ODG Porting) <Venkata.Pyla@toshiba-
>tsip.com>; cip-dev@lists.cip-project.org
>Cc: dinesh kumar(TSIP TMIEC ODG Porting) <dinesh.kumar@toshiba-
>tsip.com>; hayashi kazuhiro(林 和宏 □SWC◯ACT)
><kazuhiro3.hayashi@toshiba.co.jp>
>Subject: Re: [cip-dev] How to overwrite IMAGE_FSTYPES variable in loacal.conf
>using placement of kas file wic-targz-img.yml
>
>On 31.01.23 17:55, Venkata.Pyla@toshiba-tsip.com wrote:
>> Hi,
>>
>> I am trying to overwrite the IMAGE_FSTYPES variable with the values in wic-
>targz-img.yml by keeping at the end in kas file definition as shown in below
>command, but it is not overwriting.
>>
>> $ kas-container build
>> kas-cip.yml:kas/opt/ebg-swu.yml:kas/opt/wic-targz-img.yml
>>
>> kas/opt/ebg-swu.yml include local_conf_header as below
>> -----------------------------------------
>> local_conf_header:
>>    ...
>>     wic-swu: |
>>          ...
>>           IMAGE_FSTYPES = "wic"
>>          ...
>> -----------------------------------------
>>
>>
>> kas/opt/wic-targz-img.yml include local_conf_header as below
>> -----------------------------------------
>> local_conf_header:
>>    ...
>>     image-type: |
>>          ...
>>           IMAGE_FSTYPES = "wic tar.gz"
>>          ...
>> -----------------------------------------
>>
>> Final conf/local.conf generate as below
>> -----------------------------------------
>> # image-type
>> IMAGE_FSTYPES = "wic tar.gz"
>>
>> ...
>>
>> # wic-swu
>> IMAGE_FSTYPES = "wic"
>> -----------------------------------------
>>
>>
>> Expecting conf/local.conf
>> -----------------------------------------
>> # wic-swu
>> IMAGE_FSTYPES = "wic"
>>
>> ...
>>
>> # image-type
>> IMAGE_FSTYPES = "wic tar.gz"
>> -----------------------------------------
>>
>> The above is possible when I use name with higher in alphabetical
>> order like 'zimage-type:' in the wic-targz-img.yml
>> kas/opt/wic-targz-img.yml with
>> -----------------------------------------
>> local_conf_header:
>>    ...
>>     zimage-type: |
>>          ...
>>           IMAGE_FSTYPES = "wic tar.gz"
>>          ...
>> -----------------------------------------
>>
>> Is this the only solution to set the order of the variable assignment in
>local_conf_header?
>>
>
>local.conf nodes are alphabetically sorted as you already found out - we should
>probably document that in kas. Generally spoken, you can make use of that to
>achieve append behaviour, or you overwrite the original node you are
>competing with.
>
>In case of isar-cip-core, we can rearrange or kas option files so that your use
>case becomes possible (though I'm unsure if it makes any sense:
>the content of the tar.gz will be only a subset of the wic swupdate image).

Thanks for confirming,
I want to create swupdate image that should generate both tar.gz and wic image and use tar.gz for reproducibility checks.

I probably have to modify this file kas/opt/swupdate.yml to include both in IMAGE_FSTYPES = "wic tar.gz".

>
>Jan
>
>--
>Siemens AG, Technology
>Competence Center Embedded Linux


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: RE: [cip-dev] How to overwrite IMAGE_FSTYPES variable in loacal.conf using placement of kas file wic-targz-img.yml
  2023-02-01 11:39   ` [cip-dev] " Venkata.Pyla
@ 2023-02-02  8:56     ` Jan Kiszka
  2023-02-06 10:59       ` Venkata.Pyla
  0 siblings, 1 reply; 5+ messages in thread
From: Jan Kiszka @ 2023-02-02  8:56 UTC (permalink / raw)
  To: Venkata.Pyla, cip-dev; +Cc: dinesh.kumar, kazuhiro3.hayashi

On 01.02.23 12:39, Venkata.Pyla@toshiba-tsip.com wrote:
> 
> 
>> -----Original Message-----
>> From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org> On Behalf
>> Of Jan Kiszka
>> Sent: 01 February 2023 13:06
>> To: pyla venkata(TSIP TMIEC ODG Porting) <Venkata.Pyla@toshiba-
>> tsip.com>; cip-dev@lists.cip-project.org
>> Cc: dinesh kumar(TSIP TMIEC ODG Porting) <dinesh.kumar@toshiba-
>> tsip.com>; hayashi kazuhiro(林 和宏 □SWC◯ACT)
>> <kazuhiro3.hayashi@toshiba.co.jp>
>> Subject: Re: [cip-dev] How to overwrite IMAGE_FSTYPES variable in loacal.conf
>> using placement of kas file wic-targz-img.yml
>>
>> On 31.01.23 17:55, Venkata.Pyla@toshiba-tsip.com wrote:
>>> Hi,
>>>
>>> I am trying to overwrite the IMAGE_FSTYPES variable with the values in wic-
>> targz-img.yml by keeping at the end in kas file definition as shown in below
>> command, but it is not overwriting.
>>>
>>> $ kas-container build
>>> kas-cip.yml:kas/opt/ebg-swu.yml:kas/opt/wic-targz-img.yml
>>>
>>> kas/opt/ebg-swu.yml include local_conf_header as below
>>> -----------------------------------------
>>> local_conf_header:
>>>    ...
>>>     wic-swu: |
>>>          ...
>>>           IMAGE_FSTYPES = "wic"
>>>          ...
>>> -----------------------------------------
>>>
>>>
>>> kas/opt/wic-targz-img.yml include local_conf_header as below
>>> -----------------------------------------
>>> local_conf_header:
>>>    ...
>>>     image-type: |
>>>          ...
>>>           IMAGE_FSTYPES = "wic tar.gz"
>>>          ...
>>> -----------------------------------------
>>>
>>> Final conf/local.conf generate as below
>>> -----------------------------------------
>>> # image-type
>>> IMAGE_FSTYPES = "wic tar.gz"
>>>
>>> ...
>>>
>>> # wic-swu
>>> IMAGE_FSTYPES = "wic"
>>> -----------------------------------------
>>>
>>>
>>> Expecting conf/local.conf
>>> -----------------------------------------
>>> # wic-swu
>>> IMAGE_FSTYPES = "wic"
>>>
>>> ...
>>>
>>> # image-type
>>> IMAGE_FSTYPES = "wic tar.gz"
>>> -----------------------------------------
>>>
>>> The above is possible when I use name with higher in alphabetical
>>> order like 'zimage-type:' in the wic-targz-img.yml
>>> kas/opt/wic-targz-img.yml with
>>> -----------------------------------------
>>> local_conf_header:
>>>    ...
>>>     zimage-type: |
>>>          ...
>>>           IMAGE_FSTYPES = "wic tar.gz"
>>>          ...
>>> -----------------------------------------
>>>
>>> Is this the only solution to set the order of the variable assignment in
>> local_conf_header?
>>>
>>
>> local.conf nodes are alphabetically sorted as you already found out - we should
>> probably document that in kas. Generally spoken, you can make use of that to
>> achieve append behaviour, or you overwrite the original node you are
>> competing with.
>>
>> In case of isar-cip-core, we can rearrange or kas option files so that your use
>> case becomes possible (though I'm unsure if it makes any sense:
>> the content of the tar.gz will be only a subset of the wic swupdate image).
> 
> Thanks for confirming,
> I want to create swupdate image that should generate both tar.gz and wic image and use tar.gz for reproducibility checks.
> 
> I probably have to modify this file kas/opt/swupdate.yml to include both in IMAGE_FSTYPES = "wic tar.gz".
> 

To clarify again: What I meant is either aligning the node names in the
kas files or converting wic-targz-img.yml to targz-img.yml with
IMAGE_FSTYPES_append.

But I don't get yet why reproducibility checking is limited to tar.gz
outputs. Can't it be run against the common input, given that it works
only for the rootfs so far?

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux



^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: RE: [cip-dev] How to overwrite IMAGE_FSTYPES variable in loacal.conf using placement of kas file wic-targz-img.yml
  2023-02-02  8:56     ` Jan Kiszka
@ 2023-02-06 10:59       ` Venkata.Pyla
  0 siblings, 0 replies; 5+ messages in thread
From: Venkata.Pyla @ 2023-02-06 10:59 UTC (permalink / raw)
  To: jan.kiszka, cip-dev; +Cc: dinesh.kumar, kazuhiro3.hayashi



>-----Original Message-----
>From: Jan Kiszka <jan.kiszka@siemens.com>
>Sent: 02 February 2023 14:27
>To: pyla venkata(TSIP TMIEC ODG Porting) <Venkata.Pyla@toshiba-
>tsip.com>; cip-dev@lists.cip-project.org
>Cc: dinesh kumar(TSIP TMIEC ODG Porting) <dinesh.kumar@toshiba-
>tsip.com>; hayashi kazuhiro(林 和宏 □SWC◯ACT)
><kazuhiro3.hayashi@toshiba.co.jp>
>Subject: Re: RE: [cip-dev] How to overwrite IMAGE_FSTYPES variable in
>loacal.conf using placement of kas file wic-targz-img.yml
>
>On 01.02.23 12:39, Venkata.Pyla@toshiba-tsip.com wrote:
>>
>>
>>> -----Original Message-----
>>> From: cip-dev@lists.cip-project.org <cip-dev@lists.cip-project.org>
>>> On Behalf Of Jan Kiszka
>>> Sent: 01 February 2023 13:06
>>> To: pyla venkata(TSIP TMIEC ODG Porting) <Venkata.Pyla@toshiba-
>>> tsip.com>; cip-dev@lists.cip-project.org
>>> Cc: dinesh kumar(TSIP TMIEC ODG Porting) <dinesh.kumar@toshiba-
>>> tsip.com>; hayashi kazuhiro(林 和宏 □SWC◯ACT)
>>> <kazuhiro3.hayashi@toshiba.co.jp>
>>> Subject: Re: [cip-dev] How to overwrite IMAGE_FSTYPES variable in
>>> loacal.conf using placement of kas file wic-targz-img.yml
>>>
>>> On 31.01.23 17:55, Venkata.Pyla@toshiba-tsip.com wrote:
>>>> Hi,
>>>>
>>>> I am trying to overwrite the IMAGE_FSTYPES variable with the values
>>>> in wic-
>>> targz-img.yml by keeping at the end in kas file definition as shown
>>> in below command, but it is not overwriting.
>>>>
>>>> $ kas-container build
>>>> kas-cip.yml:kas/opt/ebg-swu.yml:kas/opt/wic-targz-img.yml
>>>>
>>>> kas/opt/ebg-swu.yml include local_conf_header as below
>>>> -----------------------------------------
>>>> local_conf_header:
>>>>    ...
>>>>     wic-swu: |
>>>>          ...
>>>>           IMAGE_FSTYPES = "wic"
>>>>          ...
>>>> -----------------------------------------
>>>>
>>>>
>>>> kas/opt/wic-targz-img.yml include local_conf_header as below
>>>> -----------------------------------------
>>>> local_conf_header:
>>>>    ...
>>>>     image-type: |
>>>>          ...
>>>>           IMAGE_FSTYPES = "wic tar.gz"
>>>>          ...
>>>> -----------------------------------------
>>>>
>>>> Final conf/local.conf generate as below
>>>> -----------------------------------------
>>>> # image-type
>>>> IMAGE_FSTYPES = "wic tar.gz"
>>>>
>>>> ...
>>>>
>>>> # wic-swu
>>>> IMAGE_FSTYPES = "wic"
>>>> -----------------------------------------
>>>>
>>>>
>>>> Expecting conf/local.conf
>>>> -----------------------------------------
>>>> # wic-swu
>>>> IMAGE_FSTYPES = "wic"
>>>>
>>>> ...
>>>>
>>>> # image-type
>>>> IMAGE_FSTYPES = "wic tar.gz"
>>>> -----------------------------------------
>>>>
>>>> The above is possible when I use name with higher in alphabetical
>>>> order like 'zimage-type:' in the wic-targz-img.yml
>>>> kas/opt/wic-targz-img.yml with
>>>> -----------------------------------------
>>>> local_conf_header:
>>>>    ...
>>>>     zimage-type: |
>>>>          ...
>>>>           IMAGE_FSTYPES = "wic tar.gz"
>>>>          ...
>>>> -----------------------------------------
>>>>
>>>> Is this the only solution to set the order of the variable
>>>> assignment in
>>> local_conf_header?
>>>>
>>>
>>> local.conf nodes are alphabetically sorted as you already found out -
>>> we should probably document that in kas. Generally spoken, you can
>>> make use of that to achieve append behaviour, or you overwrite the
>>> original node you are competing with.
>>>
>>> In case of isar-cip-core, we can rearrange or kas option files so
>>> that your use case becomes possible (though I'm unsure if it makes any
>sense:
>>> the content of the tar.gz will be only a subset of the wic swupdate image).
>>
>> Thanks for confirming,
>> I want to create swupdate image that should generate both tar.gz and wic
>image and use tar.gz for reproducibility checks.
>>
>> I probably have to modify this file kas/opt/swupdate.yml to include both in
>IMAGE_FSTYPES = "wic tar.gz".
>>
>
>To clarify again: What I meant is either aligning the node names in the kas files
>or converting wic-targz-img.yml to targz-img.yml with
>IMAGE_FSTYPES_append.

Changing the node names should work, but I need to give irrelevant name just to increase the sorting order.
The other approach is use " IMAGE_FSTYPES_append" in all yaml files like "swupdate.yaml" and "targz-img.yml" because if one of the yaml file has "IMAGE_FSTYPES = " will replace the other if it comes later in the sorting order.

>
>But I don't get yet why reproducibility checking is limited to tar.gz outputs.
>Can't it be run against the common input, given that it works only for the
>rootfs so far?

Currently wic is not comparable with diffoscope, so I am checking only tar balls in reproducible build.

>
>Jan
>
>--
>Siemens AG, Technology
>Competence Center Embedded Linux

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-02-06 10:59 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-31 16:55 How to overwrite IMAGE_FSTYPES variable in loacal.conf using placement of kas file wic-targz-img.yml Venkata.Pyla
2023-02-01  7:36 ` Jan Kiszka
2023-02-01 11:39   ` [cip-dev] " Venkata.Pyla
2023-02-02  8:56     ` Jan Kiszka
2023-02-06 10:59       ` Venkata.Pyla

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.