From: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Florian Fainelli <f.fainelli@gmail.com>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>, Nicolas Saenz Julienne <nsaenz@kernel.org>, Chris Brandt <Chris.Brandt@renesas.com>, Wolfram Sang <wsa+renesas@sang-engineering.com>, linux-i2c <linux-i2c@vger.kernel.org>, linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "Lad, Prabhakar" <prabhakar.csengg@gmail.com> Subject: RE: [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt Date: Sat, 25 Dec 2021 23:45:28 +0000 [thread overview] Message-ID: <OSZPR01MB70197F402C7BA0147AD50DF6AA409@OSZPR01MB7019.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <CAHp75VcxCGjPiuQi9w5M3Gv97nj+TQVMdF86TQXi6bxgSTL1mQ@mail.gmail.com> Hi Andy, Thank you for the review. > -----Original Message----- > From: Andy Shevchenko <andy.shevchenko@gmail.com> > Sent: 25 December 2021 17:49 > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> > Cc: Florian Fainelli <f.fainelli@gmail.com>; Ray Jui <rjui@broadcom.com>; Scott Branden > <sbranden@broadcom.com>; bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>; Nicolas > Saenz Julienne <nsaenz@kernel.org>; Chris Brandt <Chris.Brandt@renesas.com>; Wolfram Sang > <wsa+renesas@sang-engineering.com>; linux-i2c <linux-i2c@vger.kernel.org>; linux-rpi-kernel <linux- > rpi-kernel@lists.infradead.org>; linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>; Linux- > Renesas <linux-renesas-soc@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; > Prabhakarprabhakar.csengg@gmail.com > Subject: Re: [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt > > On Wed, Dec 22, 2021 at 2:41 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > > > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static > > allocation of IRQ resources in DT core code, this causes an issue when > > using hierarchical interrupt domains using "interrupts" property in > > the node as this bypasses the hierarchical setup and messes up the irq > > chaining. > > > > In preparation for removal of static setup of IRQ resource from DT > > core code use platform_get_irq_optional() for DT users only. > > ... > > > + if (np) { > > Same comments as per your other patches, i.e. > Why is this check here? > Because the interrupt resource has range of interrupts in one IRQ resource [0]. Let me know if there is any other alternative way to avoid such case. > > + int irq; > > + > > + while ((irq = platform_get_irq_optional(dev, k)) != > > + -ENXIO) { > > Consider 0 as no IRQ. > OK. [0] https://elixir.bootlin.com/linux/v5.16-rc6/source/arch/sh/kernel/cpu/sh4a/setup-sh7724.c#L454 Cheers, Prabhakar > > + if (irq < 0) > > + return irq; > > + ret = devm_request_irq(&dev->dev, irq, sh_mobile_i2c_isr, > > + 0, dev_name(&dev->dev), > > + pd); > > if (ret) { > > - dev_err(&dev->dev, "cannot request IRQ %pa\n", &n); > > + dev_err(&dev->dev, "cannot request IRQ > > + %d\n", irq); > > return ret; > > } > > + k++; > > + }; > > + } else { > > + struct resource *res; > > + resource_size_t n; > > + > > + while ((res = platform_get_resource(dev, IORESOURCE_IRQ, k))) { > > + for (n = res->start; n <= res->end; n++) { > > + ret = devm_request_irq(&dev->dev, n, sh_mobile_i2c_isr, > > + 0, dev_name(&dev->dev), pd); > > + if (ret) { > > + dev_err(&dev->dev, "cannot request IRQ %pa\n", &n); > > + return ret; > > + } > > + } > > + k++; > > } > > - k++; > > } > > -- > With Best Regards, > Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Florian Fainelli <f.fainelli@gmail.com>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>, Nicolas Saenz Julienne <nsaenz@kernel.org>, Chris Brandt <Chris.Brandt@renesas.com>, Wolfram Sang <wsa+renesas@sang-engineering.com>, linux-i2c <linux-i2c@vger.kernel.org>, linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "Lad, Prabhakar" <prabhakar.csengg@gmail.com> Subject: RE: [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt Date: Sat, 25 Dec 2021 23:45:28 +0000 [thread overview] Message-ID: <OSZPR01MB70197F402C7BA0147AD50DF6AA409@OSZPR01MB7019.jpnprd01.prod.outlook.com> (raw) In-Reply-To: <CAHp75VcxCGjPiuQi9w5M3Gv97nj+TQVMdF86TQXi6bxgSTL1mQ@mail.gmail.com> Hi Andy, Thank you for the review. > -----Original Message----- > From: Andy Shevchenko <andy.shevchenko@gmail.com> > Sent: 25 December 2021 17:49 > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com> > Cc: Florian Fainelli <f.fainelli@gmail.com>; Ray Jui <rjui@broadcom.com>; Scott Branden > <sbranden@broadcom.com>; bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>; Nicolas > Saenz Julienne <nsaenz@kernel.org>; Chris Brandt <Chris.Brandt@renesas.com>; Wolfram Sang > <wsa+renesas@sang-engineering.com>; linux-i2c <linux-i2c@vger.kernel.org>; linux-rpi-kernel <linux- > rpi-kernel@lists.infradead.org>; linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>; Linux- > Renesas <linux-renesas-soc@vger.kernel.org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; > Prabhakarprabhakar.csengg@gmail.com > Subject: Re: [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq_optional() to get the interrupt > > On Wed, Dec 22, 2021 at 2:41 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > > > platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static > > allocation of IRQ resources in DT core code, this causes an issue when > > using hierarchical interrupt domains using "interrupts" property in > > the node as this bypasses the hierarchical setup and messes up the irq > > chaining. > > > > In preparation for removal of static setup of IRQ resource from DT > > core code use platform_get_irq_optional() for DT users only. > > ... > > > + if (np) { > > Same comments as per your other patches, i.e. > Why is this check here? > Because the interrupt resource has range of interrupts in one IRQ resource [0]. Let me know if there is any other alternative way to avoid such case. > > + int irq; > > + > > + while ((irq = platform_get_irq_optional(dev, k)) != > > + -ENXIO) { > > Consider 0 as no IRQ. > OK. [0] https://elixir.bootlin.com/linux/v5.16-rc6/source/arch/sh/kernel/cpu/sh4a/setup-sh7724.c#L454 Cheers, Prabhakar > > + if (irq < 0) > > + return irq; > > + ret = devm_request_irq(&dev->dev, irq, sh_mobile_i2c_isr, > > + 0, dev_name(&dev->dev), > > + pd); > > if (ret) { > > - dev_err(&dev->dev, "cannot request IRQ %pa\n", &n); > > + dev_err(&dev->dev, "cannot request IRQ > > + %d\n", irq); > > return ret; > > } > > + k++; > > + }; > > + } else { > > + struct resource *res; > > + resource_size_t n; > > + > > + while ((res = platform_get_resource(dev, IORESOURCE_IRQ, k))) { > > + for (n = res->start; n <= res->end; n++) { > > + ret = devm_request_irq(&dev->dev, n, sh_mobile_i2c_isr, > > + 0, dev_name(&dev->dev), pd); > > + if (ret) { > > + dev_err(&dev->dev, "cannot request IRQ %pa\n", &n); > > + return ret; > > + } > > + } > > + k++; > > } > > - k++; > > } > > -- > With Best Regards, > Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-25 23:45 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-21 17:53 [PATCH v2 0/3] i2c/busses: Use platform_get_irq/_optional() variants to fetch IRQ's Lad Prabhakar 2021-12-21 17:53 ` Lad Prabhakar 2021-12-21 17:53 ` [PATCH v2 1/3] i2c: bcm2835: Use platform_get_irq() to get the interrupt Lad Prabhakar 2021-12-21 17:53 ` Lad Prabhakar 2021-12-21 18:24 ` Florian Fainelli 2021-12-21 18:24 ` Florian Fainelli 2022-01-03 9:18 ` Wolfram Sang 2022-01-03 9:18 ` Wolfram Sang 2021-12-21 17:53 ` [PATCH v2 2/3] i2c: sh_mobile: Use platform_get_irq_optional() " Lad Prabhakar 2021-12-21 17:53 ` Lad Prabhakar 2021-12-22 9:20 ` Geert Uytterhoeven 2021-12-22 9:20 ` Geert Uytterhoeven 2021-12-22 9:49 ` Wolfram Sang 2021-12-22 9:49 ` Wolfram Sang 2021-12-25 17:48 ` Andy Shevchenko 2021-12-25 17:48 ` Andy Shevchenko 2021-12-25 23:45 ` Prabhakar Mahadev Lad [this message] 2021-12-25 23:45 ` Prabhakar Mahadev Lad 2021-12-26 8:40 ` Andy Shevchenko 2021-12-26 8:40 ` Andy Shevchenko 2021-12-26 10:03 ` Lad, Prabhakar 2021-12-26 10:03 ` Lad, Prabhakar 2022-01-03 9:19 ` Wolfram Sang 2022-01-03 9:19 ` Wolfram Sang 2021-12-21 17:53 ` [PATCH v2 3/3] i2c: riic: Use platform_get_irq() " Lad Prabhakar 2021-12-21 17:53 ` Lad Prabhakar 2021-12-22 9:52 ` Wolfram Sang 2021-12-22 9:52 ` Wolfram Sang 2021-12-22 13:00 ` Geert Uytterhoeven 2021-12-22 13:00 ` Geert Uytterhoeven 2022-01-03 9:19 ` Wolfram Sang 2022-01-03 9:19 ` Wolfram Sang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=OSZPR01MB70197F402C7BA0147AD50DF6AA409@OSZPR01MB7019.jpnprd01.prod.outlook.com \ --to=prabhakar.mahadev-lad.rj@bp.renesas.com \ --cc=Chris.Brandt@renesas.com \ --cc=andy.shevchenko@gmail.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=f.fainelli@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=nsaenz@kernel.org \ --cc=prabhakar.csengg@gmail.com \ --cc=rjui@broadcom.com \ --cc=sbranden@broadcom.com \ --cc=wsa+renesas@sang-engineering.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.