From: Jun Li <jun.li@nxp.com>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: RE: [PATCH] usb: dwc3: add 2 registers dump for debugfs
Date: Thu, 16 Mar 2023 04:56:45 +0000 [thread overview]
Message-ID: <PA4PR04MB964011E8D6B0050AE071C83289BC9@PA4PR04MB9640.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20230315195312.4a5x3ziolft6fvaa@synopsys.com>
> -----Original Message-----
> From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
> Sent: Thursday, March 16, 2023 3:53 AM
> To: Jun Li <jun.li@nxp.com>
> Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>; gregkh@linuxfoundation.org;
> linux-usb@vger.kernel.org
> Subject: Re: [PATCH] usb: dwc3: add 2 registers dump for debugfs
>
> Hi,
>
> On Wed, Mar 15, 2023, Li Jun wrote:
> > Add GUCTL3 and GFLADJ register dump for debugfs as they are in use
> > now.
> >
> > Signed-off-by: Li Jun <jun.li@nxp.com>
> > ---
> > drivers/usb/dwc3/debugfs.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
> > index 850df0e6bcab..54d4678e6232 100644
> > --- a/drivers/usb/dwc3/debugfs.c
> > +++ b/drivers/usb/dwc3/debugfs.c
> > @@ -229,6 +229,8 @@ static const struct debugfs_reg32 dwc3_regs[] = {
> > dump_register(GEVNTCOUNT(0)),
> >
> > dump_register(GHWPARAMS8),
> > + dump_register(GUCTL3),
> > + dump_register(GFLADJ),
> > dump_register(DCFG),
> > dump_register(DCTL),
> > dump_register(DEVTEN),
> > --
> > 2.34.1
> >
>
> Do you mind to also add VER_NUMBER and VER_TYPE? There are other
> registers too, but for now those 2 are important.
OK, I will add the 2 ver registers and send v2.
Li Jun
>
> Thanks,
> Thinh
prev parent reply other threads:[~2023-03-16 4:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 10:39 [PATCH] usb: dwc3: add 2 registers dump for debugfs Li Jun
2023-03-15 19:53 ` Thinh Nguyen
2023-03-16 4:56 ` Jun Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PA4PR04MB964011E8D6B0050AE071C83289BC9@PA4PR04MB9640.eurprd04.prod.outlook.com \
--to=jun.li@nxp.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.