[PATCH] usb: dwc3: add 2 registers dump for debugfs

[PATCH] usb: dwc3: add 2 registers dump for debugfs

[Li Jun]

Add GUCTL3 and GFLADJ register dump for debugfs as they
are in use now.

Signed-off-by: Li Jun <jun.li@nxp.com>
---
 drivers/usb/dwc3/debugfs.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
index 850df0e6bcab..54d4678e6232 100644
--- a/drivers/usb/dwc3/debugfs.c
+++ b/drivers/usb/dwc3/debugfs.c
@@ -229,6 +229,8 @@ static const struct debugfs_reg32 dwc3_regs[] = {
 	dump_register(GEVNTCOUNT(0)),
 
 	dump_register(GHWPARAMS8),
+	dump_register(GUCTL3),
+	dump_register(GFLADJ),
 	dump_register(DCFG),
 	dump_register(DCTL),
 	dump_register(DEVTEN),
-- 
2.34.1

Re: [PATCH] usb: dwc3: add 2 registers dump for debugfs

[Thinh Nguyen]

Hi,

On Wed, Mar 15, 2023, Li Jun wrote:
> Add GUCTL3 and GFLADJ register dump for debugfs as they
> are in use now.
> 
> Signed-off-by: Li Jun <jun.li@nxp.com>
> ---
>  drivers/usb/dwc3/debugfs.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
> index 850df0e6bcab..54d4678e6232 100644
> --- a/drivers/usb/dwc3/debugfs.c
> +++ b/drivers/usb/dwc3/debugfs.c
> @@ -229,6 +229,8 @@ static const struct debugfs_reg32 dwc3_regs[] = {
>  	dump_register(GEVNTCOUNT(0)),
>  
>  	dump_register(GHWPARAMS8),
> +	dump_register(GUCTL3),
> +	dump_register(GFLADJ),
>  	dump_register(DCFG),
>  	dump_register(DCTL),
>  	dump_register(DEVTEN),
> -- 
> 2.34.1
> 

Do you mind to also add VER_NUMBER and VER_TYPE? There are other
registers too, but for now those 2 are important.

Thanks,
Thinh

RE: [PATCH] usb: dwc3: add 2 registers dump for debugfs

[Jun Li]

> -----Original Message-----
> From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
> Sent: Thursday, March 16, 2023 3:53 AM
> To: Jun Li <jun.li@nxp.com>
> Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>; gregkh@linuxfoundation.org;
> linux-usb@vger.kernel.org
> Subject: Re: [PATCH] usb: dwc3: add 2 registers dump for debugfs
> 
> Hi,
> 
> On Wed, Mar 15, 2023, Li Jun wrote:
> > Add GUCTL3 and GFLADJ register dump for debugfs as they are in use
> > now.
> >
> > Signed-off-by: Li Jun <jun.li@nxp.com>
> > ---
> >  drivers/usb/dwc3/debugfs.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c
> > index 850df0e6bcab..54d4678e6232 100644
> > --- a/drivers/usb/dwc3/debugfs.c
> > +++ b/drivers/usb/dwc3/debugfs.c
> > @@ -229,6 +229,8 @@ static const struct debugfs_reg32 dwc3_regs[] = {
> >  	dump_register(GEVNTCOUNT(0)),
> >
> >  	dump_register(GHWPARAMS8),
> > +	dump_register(GUCTL3),
> > +	dump_register(GFLADJ),
> >  	dump_register(DCFG),
> >  	dump_register(DCTL),
> >  	dump_register(DEVTEN),
> > --
> > 2.34.1
> >
> 
> Do you mind to also add VER_NUMBER and VER_TYPE? There are other
> registers too, but for now those 2 are important.

OK, I will add the 2 ver registers and send v2.

Li Jun
> 
> Thanks,
> Thinh