From: Jun Li <jun.li@nxp.com>
To: Frieder Schrempf <frieder.schrempf@kontron.de>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"aford173@gmail.com" <aford173@gmail.com>,
"tharvey@gateworks.com" <tharvey@gateworks.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Jacky Bai <ping.bai@nxp.com>
Subject: RE: [PATCH] arm64: dts: imx8m: correct usb power domain
Date: Fri, 29 Apr 2022 10:09:26 +0000 [thread overview]
Message-ID: <PA4PR04MB96405F791707A549A1A69B5F89FC9@PA4PR04MB9640.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1241eccc-5267-b241-7da5-ce5e62cdb6a3@kontron.de>
> -----Original Message-----
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> Sent: Friday, April 29, 2022 5:04 PM
> To: Jun Li <jun.li@nxp.com>; shawnguo@kernel.org
> Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com;
> dl-linux-imx <linux-imx@nxp.com>; l.stach@pengutronix.de;
> aford173@gmail.com; tharvey@gateworks.com; devicetree@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; Jacky Bai <ping.bai@nxp.com>
> Subject: Re: [PATCH] arm64: dts: imx8m: correct usb power domain
>
> Am 29.04.22 um 09:43 schrieb Li Jun:
> > pgc_otg1/2 is for each usb phy and pgc_hsiomix is shared by 2 usb
> > controllers, so assign those power domains to correct controller and
> > phy node, decouple the pgc_otg1/2 from pgc_hsiomix since there is no
> > hardware dependency.
> >
> > Suggested-by: Jacky Bai <ping.bai@nxp.com>
> > Signed-off-by: Li Jun <jun.li@nxp.com>
>
> Thanks for the patch!
>
> In my previous test I probably made some mistake. The second USB controller
> was kept enabled by the onboard hub. When I disable the second port and test
> the patch with the first port only, resuming from autosuspend still doesn't
> work, even when I keep the HSIOMIX as parent for OTG1/2. So there's probably
> still something missing...
My test was done with both second USB port and PCIE disabled, so
while autosuspend of first port, the pgc_hsiomix is off, it works
fine on my HW:
root@imx8mqevk:~# [ 81.021437] usb 1-1: USB disconnect, device number 3
root@imx8mqevk:~# cat /sys/kernel/debug/pm_genpd/usb-otg1/current_state
on
root@imx8mqevk:~# cat /sys/kernel/debug/pm_genpd/hsiomix/current_state
off-0
root@imx8mqevk:~# cat /sys/kernel/debug/pm_genpd/usb-otg2/current_state
off-0
root@imx8mqevk:~# [ 182.196450] usb 1-1: new high-speed USB device number 4 using ci_hdrc
[ 182.356130] usb-storage 1-1:1.0: USB Mass Storage device detected
[ 182.357632] scsi host0: usb-storage 1-1:1.0
[ 183.367923] scsi 0:0:0:0: Direct-Access SanDisk Ultra 1.00 PQ: 0 ANSI: 6
[ 183.370559] sd 0:0:0:0: [sda] 60062500 512-byte logical blocks: (30.8 GB/28.6 GiB)
[ 183.372332] sd 0:0:0:0: [sda] Write Protect is off
[ 183.373061] sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA
[ 183.384709] sd 0:0:0:0: [sda] Attached SCSI removable disk
[ 184.207552] EXT4-fs (sda): mounted filesystem with ordered data mode. Quota mode: none.
root@imx8mqevk:~# ls /sys/bus/platform/devices/*usb* -d
/sys/bus/platform/devices/32e40000.usb
/sys/bus/platform/devices/32e40200.usbmisc
/sys/bus/platform/devices/usbphynop1
So basically you are saying your first port cannot work even both pgc_otg1 and
pgc_hsiomix are on if you disable 2nd port?
Li Jun
WARNING: multiple messages have this Message-ID (diff)
From: Jun Li <jun.li@nxp.com>
To: Frieder Schrempf <frieder.schrempf@kontron.de>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"aford173@gmail.com" <aford173@gmail.com>,
"tharvey@gateworks.com" <tharvey@gateworks.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Jacky Bai <ping.bai@nxp.com>
Subject: RE: [PATCH] arm64: dts: imx8m: correct usb power domain
Date: Fri, 29 Apr 2022 10:09:26 +0000 [thread overview]
Message-ID: <PA4PR04MB96405F791707A549A1A69B5F89FC9@PA4PR04MB9640.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1241eccc-5267-b241-7da5-ce5e62cdb6a3@kontron.de>
> -----Original Message-----
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> Sent: Friday, April 29, 2022 5:04 PM
> To: Jun Li <jun.li@nxp.com>; shawnguo@kernel.org
> Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com;
> dl-linux-imx <linux-imx@nxp.com>; l.stach@pengutronix.de;
> aford173@gmail.com; tharvey@gateworks.com; devicetree@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; Jacky Bai <ping.bai@nxp.com>
> Subject: Re: [PATCH] arm64: dts: imx8m: correct usb power domain
>
> Am 29.04.22 um 09:43 schrieb Li Jun:
> > pgc_otg1/2 is for each usb phy and pgc_hsiomix is shared by 2 usb
> > controllers, so assign those power domains to correct controller and
> > phy node, decouple the pgc_otg1/2 from pgc_hsiomix since there is no
> > hardware dependency.
> >
> > Suggested-by: Jacky Bai <ping.bai@nxp.com>
> > Signed-off-by: Li Jun <jun.li@nxp.com>
>
> Thanks for the patch!
>
> In my previous test I probably made some mistake. The second USB controller
> was kept enabled by the onboard hub. When I disable the second port and test
> the patch with the first port only, resuming from autosuspend still doesn't
> work, even when I keep the HSIOMIX as parent for OTG1/2. So there's probably
> still something missing...
My test was done with both second USB port and PCIE disabled, so
while autosuspend of first port, the pgc_hsiomix is off, it works
fine on my HW:
root@imx8mqevk:~# [ 81.021437] usb 1-1: USB disconnect, device number 3
root@imx8mqevk:~# cat /sys/kernel/debug/pm_genpd/usb-otg1/current_state
on
root@imx8mqevk:~# cat /sys/kernel/debug/pm_genpd/hsiomix/current_state
off-0
root@imx8mqevk:~# cat /sys/kernel/debug/pm_genpd/usb-otg2/current_state
off-0
root@imx8mqevk:~# [ 182.196450] usb 1-1: new high-speed USB device number 4 using ci_hdrc
[ 182.356130] usb-storage 1-1:1.0: USB Mass Storage device detected
[ 182.357632] scsi host0: usb-storage 1-1:1.0
[ 183.367923] scsi 0:0:0:0: Direct-Access SanDisk Ultra 1.00 PQ: 0 ANSI: 6
[ 183.370559] sd 0:0:0:0: [sda] 60062500 512-byte logical blocks: (30.8 GB/28.6 GiB)
[ 183.372332] sd 0:0:0:0: [sda] Write Protect is off
[ 183.373061] sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA
[ 183.384709] sd 0:0:0:0: [sda] Attached SCSI removable disk
[ 184.207552] EXT4-fs (sda): mounted filesystem with ordered data mode. Quota mode: none.
root@imx8mqevk:~# ls /sys/bus/platform/devices/*usb* -d
/sys/bus/platform/devices/32e40000.usb
/sys/bus/platform/devices/32e40200.usbmisc
/sys/bus/platform/devices/usbphynop1
So basically you are saying your first port cannot work even both pgc_otg1 and
pgc_hsiomix are on if you disable 2nd port?
Li Jun
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-29 10:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 7:43 [PATCH] arm64: dts: imx8m: correct usb power domain Li Jun
2022-04-29 7:43 ` Li Jun
2022-04-29 9:03 ` Frieder Schrempf
2022-04-29 9:03 ` Frieder Schrempf
2022-04-29 10:09 ` Jun Li [this message]
2022-04-29 10:09 ` Jun Li
2022-04-29 15:24 ` Frieder Schrempf
2022-04-29 15:24 ` Frieder Schrempf
2022-04-29 15:58 ` Jun Li
2022-04-29 15:58 ` Jun Li
2022-05-02 9:24 ` Frieder Schrempf
2022-05-02 9:24 ` Frieder Schrempf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PA4PR04MB96405F791707A549A1A69B5F89FC9@PA4PR04MB9640.eurprd04.prod.outlook.com \
--to=jun.li@nxp.com \
--cc=aford173@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.