From: Nava kishore Manne <navam@xilinx.com>
To: Tom Rix <trix@redhat.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Michal Simek <michals@xilinx.com>,
"mdf@kernel.org" <mdf@kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>, Rajan Vaja <RAJANV@xilinx.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Amit Sunil Dhamne <amitsuni@xlnx.xilinx.com>,
Tejas Patel <tejasp@xlnx.xilinx.com>,
"zou_wei@huawei.com" <zou_wei@huawei.com>,
Sai Krishna Potthuri <lakshmis@xilinx.com>,
Ravi Patel <ravipate@xlnx.xilinx.com>,
"iwamatsu@nigauri.org" <iwamatsu@nigauri.org>,
Jiaying Liang <jliang@xilinx.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
git <git@xilinx.com>,
"chinnikishore369@gmail.com" <chinnikishore369@gmail.com>
Subject: RE: [PATCH v8 1/5] drivers: firmware: Add PDI load API support
Date: Thu, 8 Jul 2021 11:40:26 +0000 [thread overview]
Message-ID: <PH0PR02MB733670F40206C4AC019448C2C2199@PH0PR02MB7336.namprd02.prod.outlook.com> (raw)
In-Reply-To: <c2c06484-556d-1003-ad45-301e5b22210b@redhat.com>
Hi Tom,
Please fix my response inline.
> -----Original Message-----
> From: Tom Rix <trix@redhat.com>
> Sent: Wednesday, July 7, 2021 2:34 AM
> To: Nava kishore Manne <navam@xilinx.com>; robh+dt@kernel.org; Michal
> Simek <michals@xilinx.com>; mdf@kernel.org; arnd@arndb.de; Rajan Vaja
> <RAJANV@xilinx.com>; gregkh@linuxfoundation.org; Amit Sunil Dhamne
> <amitsuni@xlnx.xilinx.com>; Tejas Patel <tejasp@xlnx.xilinx.com>;
> zou_wei@huawei.com; Sai Krishna Potthuri <lakshmis@xilinx.com>; Ravi
> Patel <ravipate@xlnx.xilinx.com>; iwamatsu@nigauri.org; Jiaying Liang
> <jliang@xilinx.com>; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
> fpga@vger.kernel.org; git <git@xilinx.com>; chinnikishore369@gmail.com
> Subject: Re: [PATCH v8 1/5] drivers: firmware: Add PDI load API support
>
>
> On 6/26/21 8:52 AM, Nava kishore Manne wrote:
> > This patch adds load PDI API support to enable full/partial PDI
> > loading from linux. Programmable Device Image (PDI) is combination of
> > headers, images and bitstream files to be loaded.
> >
> > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> > Reviewed-by: Moritz Fischer <mdf@kernel.org>
> > ---
> > Changes for v2:
> > -Updated API Doc and commit msg.
> > No functional changes.
> >
> > Changes for v3:
> > -None.
> >
> > Changes for v4:
> > -Rebased the changes on linux-next.
> > No functional changes
> >
> > Changes for v5:
> > -None.
> >
> > Changes for v6:
> > -None.
> >
> > Changes for v7:
> > -None.
> >
> > Changes for v8:
> > -None.
> >
> > drivers/firmware/xilinx/zynqmp.c | 17 +++++++++++++++++
> > include/linux/firmware/xlnx-zynqmp.h | 10 ++++++++++
> > 2 files changed, 27 insertions(+)
> >
> > diff --git a/drivers/firmware/xilinx/zynqmp.c
> > b/drivers/firmware/xilinx/zynqmp.c
> > index 15b138326ecc..2db571da9ad8 100644
> > --- a/drivers/firmware/xilinx/zynqmp.c
> > +++ b/drivers/firmware/xilinx/zynqmp.c
> > @@ -1011,6 +1011,23 @@ int zynqmp_pm_set_requirement(const u32
> node, const u32 capabilities,
> > }
> > EXPORT_SYMBOL_GPL(zynqmp_pm_set_requirement);
> >
> > +/**
> > + * zynqmp_pm_load_pdi - Load and process PDI
> > + * @src: Source device where PDI is located
> > + * @address: PDI src address
> > + *
> > + * This function provides support to load PDI from linux
> > + *
> > + * Return: Returns status, either success or error+reason */ int
> > +zynqmp_pm_load_pdi(const u32 src, const u64 address) {
> > + return zynqmp_pm_invoke_fn(PM_LOAD_PDI, src,
> > + lower_32_bits(address),
> > + upper_32_bits(address), 0, NULL); }
> > +EXPORT_SYMBOL_GPL(zynqmp_pm_load_pdi);
> > +
> > /**
> > * zynqmp_pm_aes - Access AES hardware to encrypt/decrypt the data
> using
> > * AES-GCM core.
> > diff --git a/include/linux/firmware/xlnx-zynqmp.h
> > b/include/linux/firmware/xlnx-zynqmp.h
> > index 9d1a5c175065..56b426fe020c 100644
> > --- a/include/linux/firmware/xlnx-zynqmp.h
> > +++ b/include/linux/firmware/xlnx-zynqmp.h
> > @@ -52,6 +52,10 @@
> > #define ZYNQMP_PM_CAPABILITY_WAKEUP 0x4U
> > #define ZYNQMP_PM_CAPABILITY_UNUSABLE 0x8U
> >
> > +/* Loader commands */
> > +#define PM_LOAD_PDI 0x701
> This should be defined in enum pm_api_id
> > +#define PDI_SRC_DDR 0xF
>
> This is only used by versal_fpga_ops_write(), consider moving the #define to
> versal-fpga.c
>
Yes, currently only versal_fpga_write() is using this #define but it’s a generic thing for Versal platform
That’s why we placed it here.
Regards,
Navakishore.
WARNING: multiple messages have this Message-ID (diff)
From: Nava kishore Manne <navam@xilinx.com>
To: Tom Rix <trix@redhat.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Michal Simek <michals@xilinx.com>,
"mdf@kernel.org" <mdf@kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>, Rajan Vaja <RAJANV@xilinx.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Amit Sunil Dhamne <amitsuni@xlnx.xilinx.com>,
Tejas Patel <tejasp@xlnx.xilinx.com>,
"zou_wei@huawei.com" <zou_wei@huawei.com>,
Sai Krishna Potthuri <lakshmis@xilinx.com>,
Ravi Patel <ravipate@xlnx.xilinx.com>,
"iwamatsu@nigauri.org" <iwamatsu@nigauri.org>,
Jiaying Liang <jliang@xilinx.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
git <git@xilinx.com>,
"chinnikishore369@gmail.com" <chinnikishore369@gmail.com>
Subject: RE: [PATCH v8 1/5] drivers: firmware: Add PDI load API support
Date: Thu, 8 Jul 2021 11:40:26 +0000 [thread overview]
Message-ID: <PH0PR02MB733670F40206C4AC019448C2C2199@PH0PR02MB7336.namprd02.prod.outlook.com> (raw)
In-Reply-To: <c2c06484-556d-1003-ad45-301e5b22210b@redhat.com>
Hi Tom,
Please fix my response inline.
> -----Original Message-----
> From: Tom Rix <trix@redhat.com>
> Sent: Wednesday, July 7, 2021 2:34 AM
> To: Nava kishore Manne <navam@xilinx.com>; robh+dt@kernel.org; Michal
> Simek <michals@xilinx.com>; mdf@kernel.org; arnd@arndb.de; Rajan Vaja
> <RAJANV@xilinx.com>; gregkh@linuxfoundation.org; Amit Sunil Dhamne
> <amitsuni@xlnx.xilinx.com>; Tejas Patel <tejasp@xlnx.xilinx.com>;
> zou_wei@huawei.com; Sai Krishna Potthuri <lakshmis@xilinx.com>; Ravi
> Patel <ravipate@xlnx.xilinx.com>; iwamatsu@nigauri.org; Jiaying Liang
> <jliang@xilinx.com>; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
> fpga@vger.kernel.org; git <git@xilinx.com>; chinnikishore369@gmail.com
> Subject: Re: [PATCH v8 1/5] drivers: firmware: Add PDI load API support
>
>
> On 6/26/21 8:52 AM, Nava kishore Manne wrote:
> > This patch adds load PDI API support to enable full/partial PDI
> > loading from linux. Programmable Device Image (PDI) is combination of
> > headers, images and bitstream files to be loaded.
> >
> > Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> > Reviewed-by: Moritz Fischer <mdf@kernel.org>
> > ---
> > Changes for v2:
> > -Updated API Doc and commit msg.
> > No functional changes.
> >
> > Changes for v3:
> > -None.
> >
> > Changes for v4:
> > -Rebased the changes on linux-next.
> > No functional changes
> >
> > Changes for v5:
> > -None.
> >
> > Changes for v6:
> > -None.
> >
> > Changes for v7:
> > -None.
> >
> > Changes for v8:
> > -None.
> >
> > drivers/firmware/xilinx/zynqmp.c | 17 +++++++++++++++++
> > include/linux/firmware/xlnx-zynqmp.h | 10 ++++++++++
> > 2 files changed, 27 insertions(+)
> >
> > diff --git a/drivers/firmware/xilinx/zynqmp.c
> > b/drivers/firmware/xilinx/zynqmp.c
> > index 15b138326ecc..2db571da9ad8 100644
> > --- a/drivers/firmware/xilinx/zynqmp.c
> > +++ b/drivers/firmware/xilinx/zynqmp.c
> > @@ -1011,6 +1011,23 @@ int zynqmp_pm_set_requirement(const u32
> node, const u32 capabilities,
> > }
> > EXPORT_SYMBOL_GPL(zynqmp_pm_set_requirement);
> >
> > +/**
> > + * zynqmp_pm_load_pdi - Load and process PDI
> > + * @src: Source device where PDI is located
> > + * @address: PDI src address
> > + *
> > + * This function provides support to load PDI from linux
> > + *
> > + * Return: Returns status, either success or error+reason */ int
> > +zynqmp_pm_load_pdi(const u32 src, const u64 address) {
> > + return zynqmp_pm_invoke_fn(PM_LOAD_PDI, src,
> > + lower_32_bits(address),
> > + upper_32_bits(address), 0, NULL); }
> > +EXPORT_SYMBOL_GPL(zynqmp_pm_load_pdi);
> > +
> > /**
> > * zynqmp_pm_aes - Access AES hardware to encrypt/decrypt the data
> using
> > * AES-GCM core.
> > diff --git a/include/linux/firmware/xlnx-zynqmp.h
> > b/include/linux/firmware/xlnx-zynqmp.h
> > index 9d1a5c175065..56b426fe020c 100644
> > --- a/include/linux/firmware/xlnx-zynqmp.h
> > +++ b/include/linux/firmware/xlnx-zynqmp.h
> > @@ -52,6 +52,10 @@
> > #define ZYNQMP_PM_CAPABILITY_WAKEUP 0x4U
> > #define ZYNQMP_PM_CAPABILITY_UNUSABLE 0x8U
> >
> > +/* Loader commands */
> > +#define PM_LOAD_PDI 0x701
> This should be defined in enum pm_api_id
> > +#define PDI_SRC_DDR 0xF
>
> This is only used by versal_fpga_ops_write(), consider moving the #define to
> versal-fpga.c
>
Yes, currently only versal_fpga_write() is using this #define but it’s a generic thing for Versal platform
That’s why we placed it here.
Regards,
Navakishore.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-08 11:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-26 15:52 [PATCH v8 0/5]Add Bitstream configuration support for Versal Nava kishore Manne
2021-06-26 15:52 ` Nava kishore Manne
2021-06-26 15:52 ` [PATCH v8 1/5] drivers: firmware: Add PDI load API support Nava kishore Manne
2021-06-26 15:52 ` Nava kishore Manne
2021-07-06 21:03 ` Tom Rix
2021-07-06 21:03 ` Tom Rix
2021-07-08 11:40 ` Nava kishore Manne [this message]
2021-07-08 11:40 ` Nava kishore Manne
2021-06-26 15:52 ` [PATCH v8 2/5] dt-bindings: fpga: Add binding doc for versal fpga manager Nava kishore Manne
2021-06-26 15:52 ` Nava kishore Manne
2021-06-26 15:52 ` [PATCH v8 3/5] dt-bindings: firmware: Add bindings for xilinx firmware Nava kishore Manne
2021-06-26 15:52 ` Nava kishore Manne
2021-07-13 22:15 ` Rob Herring
2021-07-13 22:15 ` Rob Herring
2021-06-26 15:52 ` [PATCH v8 4/5] dt-bindings: firmware: Remove xlnx,zynqmp-firmware.txt file Nava kishore Manne
2021-06-26 15:52 ` [PATCH v8 4/5] dt-bindings: firmware: Remove xlnx, zynqmp-firmware.txt file Nava kishore Manne
2021-07-06 21:09 ` [PATCH v8 4/5] dt-bindings: firmware: Remove xlnx,zynqmp-firmware.txt file Tom Rix
2021-07-06 21:09 ` Tom Rix
2021-07-08 11:42 ` Nava kishore Manne
2021-07-08 11:42 ` Nava kishore Manne
2021-07-13 22:16 ` Rob Herring
2021-07-13 22:16 ` Rob Herring
2021-06-26 15:52 ` [PATCH v8 5/5] fpga: versal-fpga: Add versal fpga manager driver Nava kishore Manne
2021-06-26 15:52 ` Nava kishore Manne
2021-07-06 21:34 ` Tom Rix
2021-07-06 21:34 ` Tom Rix
2021-07-08 11:57 ` Nava kishore Manne
2021-07-08 11:57 ` Nava kishore Manne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR02MB733670F40206C4AC019448C2C2199@PH0PR02MB7336.namprd02.prod.outlook.com \
--to=navam@xilinx.com \
--cc=RAJANV@xilinx.com \
--cc=amitsuni@xlnx.xilinx.com \
--cc=arnd@arndb.de \
--cc=chinnikishore369@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=iwamatsu@nigauri.org \
--cc=jliang@xilinx.com \
--cc=lakshmis@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=michals@xilinx.com \
--cc=ravipate@xlnx.xilinx.com \
--cc=robh+dt@kernel.org \
--cc=tejasp@xlnx.xilinx.com \
--cc=trix@redhat.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.