From: <Kavyasree.Kotagiri@microchip.com> To: <krzysztof.kozlowski@linaro.org>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>, <Claudiu.Beznea@microchip.com>, <UNGLinuxDriver@microchip.com> Cc: <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: RE: [PATCH v7 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema Date: Thu, 7 Jul 2022 05:29:06 +0000 [thread overview] Message-ID: <PH0PR11MB487299A211568CC3614682BC92839@PH0PR11MB4872.namprd11.prod.outlook.com> (raw) In-Reply-To: <fca15370-f977-687a-ff62-22ae43046b58@linaro.org> > > Convert the Atmel flexcom device tree bindings to json schema. > > > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> > > --- > > v6 -> v7: > > - Change filename to atmel,sama5d2-flexcom.yaml > > - Add #address-cells, #size-cells to flexcom node - Fixed warnings. > > > > v5 -> v6: > > - Removed spi node from example as suggested by Rob and > > also pattern properties(spi dt-bindings conversion to yaml patch is under > review). > > Once that is accepted, I will add back spi example through new patch. > > > > v4 -> v5: > > - Fixed indentations. > > > > v3 -> v4: > > - Corrected format of enum used for compatible string. > > > > v2 -> v3: > > - used enum for compatible string. > > - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example. > > - fixed dtschema errors. > > > > v1 -> v2: > > - Fix title. > > > > .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 74 > +++++++++++++++++++ > > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ---------------- > > 2 files changed, 74 insertions(+), 63 deletions(-) > > create mode 100644 > Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml > > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel- > flexcom.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2- > flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2- > flexcom.yaml > > new file mode 100644 > > index 000000000000..864f490ffb83 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2- > flexcom.yaml > > @@ -0,0 +1,74 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mfd/atmel,sama5d2-flexcom.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Atmel Flexcom (Flexible Serial Communication Unit) > > + > > +maintainers: > > + - Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> > > + > > +description: > > + The Atmel Flexcom is just a wrapper which embeds a SPI controller, > > + an I2C controller and an USART. Only one function can be used at a > > + time and is chosen at boot time according to the device tree. > > + > > +properties: > > + compatible: > > + enum: > > + - atmel,sama5d2-flexcom > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 1 > > + > > + ranges: > > + description: > > + One range for the full I/O register region. (including USART, > > + TWI and SPI registers). > > + items: > > + maxItems: 3 > > + > > + atmel,flexcom-mode: > > + description: | > > + Specifies the flexcom mode as follows: > > + 1: USART > > + 2: SPI > > + 3: I2C. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [1, 2, 3] > > + > > As pointed out by Rob's bot - why do you not allow the protocol-specific > children here? spi, serial etc? > usart/serial, spi and i2c dt-bindings are in .txt format. So, I cannot refer them here. Like I mentioned in v5 -> v6 changes description, spi dt-bindings conversion is under discussion. For now, I am removing child nodes from example. I will add it through new patch once below bindings are accepted: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20220629125804.137099-1-sergiu.moga@microchip.com/ > > Best regards, > Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: <Kavyasree.Kotagiri@microchip.com> To: <krzysztof.kozlowski@linaro.org>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>, <Claudiu.Beznea@microchip.com>, <UNGLinuxDriver@microchip.com> Cc: <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: RE: [PATCH v7 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema Date: Thu, 7 Jul 2022 05:29:06 +0000 [thread overview] Message-ID: <PH0PR11MB487299A211568CC3614682BC92839@PH0PR11MB4872.namprd11.prod.outlook.com> (raw) In-Reply-To: <fca15370-f977-687a-ff62-22ae43046b58@linaro.org> > > Convert the Atmel flexcom device tree bindings to json schema. > > > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> > > --- > > v6 -> v7: > > - Change filename to atmel,sama5d2-flexcom.yaml > > - Add #address-cells, #size-cells to flexcom node - Fixed warnings. > > > > v5 -> v6: > > - Removed spi node from example as suggested by Rob and > > also pattern properties(spi dt-bindings conversion to yaml patch is under > review). > > Once that is accepted, I will add back spi example through new patch. > > > > v4 -> v5: > > - Fixed indentations. > > > > v3 -> v4: > > - Corrected format of enum used for compatible string. > > > > v2 -> v3: > > - used enum for compatible string. > > - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example. > > - fixed dtschema errors. > > > > v1 -> v2: > > - Fix title. > > > > .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 74 > +++++++++++++++++++ > > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ---------------- > > 2 files changed, 74 insertions(+), 63 deletions(-) > > create mode 100644 > Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml > > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel- > flexcom.txt > > > > diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2- > flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2- > flexcom.yaml > > new file mode 100644 > > index 000000000000..864f490ffb83 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2- > flexcom.yaml > > @@ -0,0 +1,74 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mfd/atmel,sama5d2-flexcom.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Atmel Flexcom (Flexible Serial Communication Unit) > > + > > +maintainers: > > + - Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> > > + > > +description: > > + The Atmel Flexcom is just a wrapper which embeds a SPI controller, > > + an I2C controller and an USART. Only one function can be used at a > > + time and is chosen at boot time according to the device tree. > > + > > +properties: > > + compatible: > > + enum: > > + - atmel,sama5d2-flexcom > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 1 > > + > > + ranges: > > + description: > > + One range for the full I/O register region. (including USART, > > + TWI and SPI registers). > > + items: > > + maxItems: 3 > > + > > + atmel,flexcom-mode: > > + description: | > > + Specifies the flexcom mode as follows: > > + 1: USART > > + 2: SPI > > + 3: I2C. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [1, 2, 3] > > + > > As pointed out by Rob's bot - why do you not allow the protocol-specific > children here? spi, serial etc? > usart/serial, spi and i2c dt-bindings are in .txt format. So, I cannot refer them here. Like I mentioned in v5 -> v6 changes description, spi dt-bindings conversion is under discussion. For now, I am removing child nodes from example. I will add it through new patch once below bindings are accepted: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20220629125804.137099-1-sergiu.moga@microchip.com/ > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-07 5:29 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-06 11:06 [PATCH v7 0/3] Add support for lan966x flexcom chip-select configuration Kavyasree Kotagiri 2022-07-06 11:06 ` Kavyasree Kotagiri 2022-07-06 11:06 ` [PATCH v7 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema Kavyasree Kotagiri 2022-07-06 11:06 ` Kavyasree Kotagiri 2022-07-06 13:29 ` Rob Herring 2022-07-06 13:29 ` Rob Herring 2022-07-06 15:22 ` Krzysztof Kozlowski 2022-07-06 15:22 ` Krzysztof Kozlowski 2022-07-07 5:29 ` Kavyasree.Kotagiri [this message] 2022-07-07 5:29 ` Kavyasree.Kotagiri 2022-07-07 6:42 ` Krzysztof Kozlowski 2022-07-07 6:42 ` Krzysztof Kozlowski 2022-07-07 6:54 ` Kavyasree.Kotagiri 2022-07-07 6:54 ` Kavyasree.Kotagiri 2022-07-07 6:57 ` Krzysztof Kozlowski 2022-07-07 6:57 ` Krzysztof Kozlowski 2022-07-06 11:06 ` [PATCH v7 2/3] dt-bindings: mfd: atmel,sama5d2-flexcom: Add new compatible string for lan966x Kavyasree Kotagiri 2022-07-06 11:06 ` Kavyasree Kotagiri 2022-07-06 14:43 ` Rob Herring 2022-07-06 14:43 ` Rob Herring 2022-07-07 7:40 ` Kavyasree.Kotagiri 2022-07-07 7:40 ` Kavyasree.Kotagiri 2022-07-06 11:06 ` [PATCH v7 3/3] mfd: atmel-flexcom: Add support for lan966x flexcom chip-select configuration Kavyasree Kotagiri 2022-07-06 11:06 ` Kavyasree Kotagiri
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=PH0PR11MB487299A211568CC3614682BC92839@PH0PR11MB4872.namprd11.prod.outlook.com \ --to=kavyasree.kotagiri@microchip.com \ --cc=Claudiu.Beznea@microchip.com \ --cc=Nicolas.Ferre@microchip.com \ --cc=UNGLinuxDriver@microchip.com \ --cc=alexandre.belloni@bootlin.com \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.