RE: [PATCH v4] media: i2c: imx334: support lower bandwidth mode

[<Shravan.Chippa@microchip.com>]

> -----Original Message-----
> From: Sakari Ailus <sakari.ailus@iki.fi>
> Sent: 02 October 2022 05:59 PM
> To: shravan Chippa - I35088 <Shravan.Chippa@microchip.com>
> Cc: paul.j.murphy@intel.com; daniele.alessandrelli@intel.com;
> mchehab@kernel.org; linux-media@vger.kernel.org; linux-
> kernel@vger.kernel.org; Conor Dooley - M52691
> <Conor.Dooley@microchip.com>; Battu Prakash Reddy - I30399
> <Prakash.Battu@microchip.com>
> Subject: Re: [PATCH v4] media: i2c: imx334: support lower bandwidth mode
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> On Sat, Oct 01, 2022 at 08:51:46AM +0000, Shravan.Chippa@microchip.com
> wrote:
> > > > > > +     case MEDIA_BUS_FMT_SRGGB12_1X12:
> > > > > > +             return imx334_write_regs(imx334,
> > > > > > + raw12_framefmt_regs,
> > > > > > +
> > > > > > + ARRAY_SIZE(raw12_framefmt_regs));
> > > > >
> > > > > I think you'll also need changes to the pixel clock calculation.
> > > > >
> > > > In this driver pixel clock read only variable.
> > > > Pixel clock change maybe in different series.
> > >
> > > Please address it in this patch.
> > >
> > > Is the link frequency affected by this patch as well?
> >
> > I will try to modify my patch with the default link frequency
> > available in the driver
> 
> Also check the frequencies the driver enables will be available in link-
> frequencies.

This patch is not affecting the default link frequency 891Mbps with input clock frequency (24Mhz)
I have cross-checked with the present supported 3840x2160 resolution and imx334 UG.

Thanks,
Shravan

> 
> --
> Sakari Ailus